From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6842309179660566528 X-Received: by 2002:a2e:3e1a:: with SMTP id l26mr5873564lja.63.1602585309214; Tue, 13 Oct 2020 03:35:09 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:ad43:: with SMTP id s3ls868238lfd.2.gmail; Tue, 13 Oct 2020 03:35:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxq7HS27sQjAQAaqDU64TiRHX4lgup6nLjzugCL83WHFu2Tsfdxosk5HuePjOCIsSxaIUaB X-Received: by 2002:a19:f71a:: with SMTP id z26mr8714560lfe.90.1602585308047; Tue, 13 Oct 2020 03:35:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602585308; cv=none; d=google.com; s=arc-20160816; b=QXCru/2DIPZESbOXYpCVMkXq3TafNUjrsclL/jUqqWEleW5G6Th3tyyE2xoZXCAVGW 2WeN7qFUZz8nYMyPb4W2iq4WrRHpjDb3xzFt3VcH8bpMt4cgYnoJU6yjJyAgvjd3KyWN xPnyucT3PwoMM3xo8xt1ikTf398KLLBbd9/wU/UAfRqu9sToommVfoc2WJvo9nNES1Ch bbB/H2iBKho43zRg0wjRolq54lQHcaVBTY20xG3AsjvBz5ty961xxrQkc4rxcsZDyTcJ AyeFJnb3bXrSZFwUzS2b9Avru5ZoIc43NVsBnRWGBXcqAQ9tpYoJIZk/53TiiNrj6fJw Uhxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=ERMkufSFpCVEI+oeR9fq+DIdyWOUccKyOA2q629BPvc=; b=bUWuYVEJhdG4lV/9cH/gLDPGHMX7hIxGM7ZA0vZflQVFxglSosZwuXk1KIM06jRZnh KFOGBepm3psNE3ch19rsBpirC11OuYdn0TXoSL4ekmX92PT64oS6zo7towxp1mrE19Z8 1nA+8YNmtg+WDDyfq2YSwQ1mba/WefqH3BTlXIIOEuYaTfsDKtGLOytTSl9LrNOri69x ZQI+Lga/unOcqEDD5EiWOmlqiaDp5mLgP3SJfs9TTy1Y4RVo04hZuO1e1BDQ2a9Je+dB H4TJEDJ66zByh5x8evpcuYUFUuNrumCSFFUasbLZrrIPKsZuIdCddLX7Ef7Ce1jAArzn 67Hg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id l28si197325lfp.11.2020.10.13.03.35.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2020 03:35:07 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 09DAZ6PU009734 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Oct 2020 12:35:06 +0200 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 09DAZ6mP001150; Tue, 13 Oct 2020 12:35:06 +0200 Subject: Re: [PATCH] image: Run copy_boot_files after rootfs postprocessing To: Harald Seiler , isar-users@googlegroups.com Cc: Claudius Heine , Henning Schild References: <20200625153351.3402179-1-hws@denx.de> <61a681ed-f982-30a4-12f6-5b1b1d49b780@siemens.com> <33231e4d0ef88346879f00e761ede03eb39f1454.camel@denx.de> From: Jan Kiszka Message-ID: Date: Tue, 13 Oct 2020 12:35:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <33231e4d0ef88346879f00e761ede03eb39f1454.camel@denx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: j2dkeBsgL5Iv On 13.10.20 12:26, Harald Seiler wrote: > Hi Jan, > > On Tue, 2020-10-13 at 12:19 +0200, Jan Kiszka wrote: >> On 25.06.20 17:33, Harald Seiler wrote: >>> In some cases, postprocessing might trigger an update of the initramfs >>> which would not appear in the deployed version. Fix this by running >>> copy_boot_files only after all postprocessing completed. >>> >>> Signed-off-by: Harald Seiler >>> --- >>> meta/classes/image.bbclass | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >>> index 0150f2718573..21d634a8f34f 100644 >>> --- a/meta/classes/image.bbclass >>> +++ b/meta/classes/image.bbclass >>> @@ -153,7 +153,7 @@ do_copy_boot_files() { >>> cp -f "$dtb" "${DEPLOY_DIR_IMAGE}/" >>> done >>> } >>> -addtask copy_boot_files before do_rootfs_postprocess after do_rootfs_install >>> +addtask copy_boot_files before do_rootfs after do_rootfs_postprocess >>> >>> python do_image_tools() { >>> """Virtual task""" >>> >> >> There was a lengthy discussion after this, but I don't think the >> conclusion was to hold back this patch, right? We are using it at least >> in one case internally, so this should likely go in now. > > At least from my side we can drop this. In the project where I needed > this it is now gone, because I switched to the alternate initramfs > mechanism over there. Seems that this change in the downstream project didn't hit its master yet. > > Also, the arguments where this patch might break downstream use-cases do > hold some truth so I'd rather err on the side of caution and not go this > route. > OK. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux