From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7136477983660834816 X-Received: by 2002:ac2:5df3:0:b0:494:6f38:5bf9 with SMTP id z19-20020ac25df3000000b004946f385bf9mr5609871lfq.563.1662061623656; Thu, 01 Sep 2022 12:47:03 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3fa:b0:494:799f:170 with SMTP id n26-20020a05651203fa00b00494799f0170ls24232lfq.0.-pod-prod-gmail; Thu, 01 Sep 2022 12:47:02 -0700 (PDT) X-Google-Smtp-Source: AA6agR7aiXrlwDAzokKlHh8e/4I3P5BwR5N6JD/Osyps/exXaUXTtDTgNbbN3ivREJ6Bn1fYaV0e X-Received: by 2002:a19:7017:0:b0:494:649d:f1e2 with SMTP id h23-20020a197017000000b00494649df1e2mr7059029lfc.251.1662061622016; Thu, 01 Sep 2022 12:47:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1662061622; cv=pass; d=google.com; s=arc-20160816; b=aazpv6hn0GOWQ4S+7ooVJezkByGubwUGi69i5YPIAuorbEVYcK/1lN6VbjgurFkd1E jYBzfwxF1IIdtAwN3mWdKnL5WpTgl442Bs0J+aqrx7xqiEDKSgO2C0T4heLxHd5jGltE bPFQRmLkFNQ7Y0cpytkTnT2zLFTuEAYe3xBIfgnNPE/+T5XIqUc1aNGPjs6mfh2jSi50 pCaZsAoyNZnMhE8/LQt2tAGobSpfZIAYVxzjEw8TM+itCX9qJOdhafV0Bbr5cMfAH5bB wobZVTLIHY+ol6NNeS6wgltB7w6yhb4XnohxqBHTZezl7a+Zarhh2BstNGvqvqF9SgML cXTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=56OFebJVeGwnPRLdjY7O1AjSb3lAu51U+5eirZX2YzY=; b=efIi/5aSGg42zvZUvA4isW+aql9pouwBIacwOkJ9LbPg1vwZIEbCa8LBj4BIpQiTTw oUGJ0Vel1YR7KAhwapG1kgnb3zo9lxDKkMuuIgK54qKlasY/m1AVmHY2cOmIYHQEDPJ/ aGZZrS3I+N6+7bIMfkWRAQSBc92NLGpk3KpktkHdV2N/EoUrjLimLupMsW9CoL0a6x10 QpohSonC5s98w9mdQyouATwprf3fHXFIpydsiMj3KQjDaaI0AAFaKrb+iWz7eD9+KQzy MYnz5gmRFImZhR3PTBSDTUpyDNpE1CIdRGBEemVKhaQyoHVsI5B+IvL0aDLxHajY0z8V qb8w== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="lR9n/SBF"; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.8.79 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80079.outbound.protection.outlook.com. [40.107.8.79]) by gmr-mx.google.com with ESMTPS id e6-20020a05651236c600b0049499c0cf28si166293lfs.7.2022.09.01.12.47.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Sep 2022 12:47:01 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.8.79 as permitted sender) client-ip=40.107.8.79; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="lR9n/SBF"; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.8.79 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iehu9PSUpKMMt+AflS4BW4cdXHBEn3sQDzEeCUuwJIkWd6i0CQ6eNVI1lObOTOLSHPi5RfKWMJYKJhIv266aSGUxu44mg+0eOqR8Fd+6mCF/PqEsDtuzf6/4T205VIjERmrTqCn+D8jkbBkXp+x1mw4eMimjPKltV+HCz8AIWo99z4mtGB/KyWgdZBMLZ0G7A41dRFti66wFoO34PLo/DQsDiGE0NZ5s3a7ix9kYEyunL5eJ7iQ2SZkGtp2z1r9ylVVQ5sj/Q7cbLSvZQXlQZTvvWfA98u1E9JkQJF31ELJS7kJ9ElEcAxJV8WRrkZfthNthJ9tUmybrvGHTOMtctg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=56OFebJVeGwnPRLdjY7O1AjSb3lAu51U+5eirZX2YzY=; b=XSyrgWmQNbNi7cXuO4lWhUOxPrUfCWMYw6UnTC7ihdjnV2/nwFFvvYTEwc5qJL7EJAwdMLHqh8/y8O2uH5D2bYGPqjHIK/kluMLUCMWM3Q1lT6n4dsw4M22kWo0q7HKnUXFghOaJBlz+B1bbjUQveJqirGkPwAiRje30tfvm0g2xfvU050qIJDqSFuzmH8pM2YdDdaXfW8St27b4S9uCq3ByPgD9cl+GV3SqjVw9ziatGzZ0mvtEVQjNN21hzbbbqDbmSQwLEpT+TbB7ACBnrUWDs7GdwWs5jwzUMhKDp3RqONIWVMpheFjeOG2Cwdb+eBWPGrIKbrGVhqAzTPyFfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.74) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=56OFebJVeGwnPRLdjY7O1AjSb3lAu51U+5eirZX2YzY=; b=lR9n/SBFxLm+mfvYGS5VyLy5sHuRa5lxFnud18vtnnD37go94iJoJo393rCSRtkI3Ficbizfm0CGXlwVHL3vEkFJs6Hh/I9WMkPC8FCbSfkkIllIsp6Jwxb5InnE9f52YSr03cJ5pjTyefUNfbOj4sG/sHpw9rC1kztlxp5XKx+5fcIfnhFTBPuNIrgeqlzhwoeU+pQykD2M1vQdAuSxW9AS8T4zFqD+3DzLPYpKsbI7mH8Og8HOlPKKvFI3BBd3qbZrWJCJ9Ci/Qw/Q5SPuZZN4nK41k4D1Gz/AOwRgtr6GxCb3MGMSguBZrvfG2eR1UpChl34w1kKgddIkGeMMzQ== Received: from AS8P189CA0002.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::21) by GV1PR10MB6515.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:83::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 1 Sep 2022 19:46:59 +0000 Received: from VE1EUR01FT092.eop-EUR01.prod.protection.outlook.com (2603:10a6:20b:31f:cafe::41) by AS8P189CA0002.outlook.office365.com (2603:10a6:20b:31f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 19:46:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.74) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.74 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.74; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.74) by VE1EUR01FT092.mail.protection.outlook.com (10.152.3.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 19:46:59 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VQA.ad011.siemens.net (194.138.21.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Thu, 1 Sep 2022 21:46:59 +0200 Received: from [139.25.68.37] (139.25.68.37) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Thu, 1 Sep 2022 21:46:58 +0200 Message-ID: Date: Thu, 1 Sep 2022 21:46:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 2/3] linux-module: honor modules Makefile Content-Language: en-US To: Henning Schild CC: , Pingfang Liao , Florian Bezdeka References: <20220827085905.6116-1-henning.schild@siemens.com> <20220827085905.6116-2-henning.schild@siemens.com> <20220901191734.2f22f8a0@md1za8fc.ad001.siemens.net> From: Jan Kiszka In-Reply-To: <20220901191734.2f22f8a0@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [139.25.68.37] X-ClientProxiedBy: DEMCHDC89XA.ad011.siemens.net (139.25.226.103) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--17.652800-8.000000 X-TMASE-MatchedRID: U4jXvEiKZBU5QaOxwNGfvo9bHfxDWoib/SxCr0ylBzmENWFO9FGfqAIL zOoe9wbaKFtl24uIV9vr6lsDXOZho2Jdz9+fRP5S3kp1C8IclkOVkZQpUJVpvvbta0OAYFzyRwD U669267wGmHr1eMxt2UAc6DyoS2rIw/kunvvd5s1XwUttOBWGW7ftpBVRZnYVttAWxuM5sl6w8O vwKwjx3PmHRZjmkZDphfwwa6XqPjnN/EmbYxSseoB2sOVV4gC7Qz7+xFJCtop+J3gtIe0gA35Lm bb/xUuah08Dgy7FgXz3muLh+GPYb6ECEKxEEjjR1qs/xP9nRfm6LacOIlEHv7E3FpMbg63SXgpx NhVX601c6IXBFD5lzPNaEim+BfVwReC9ZA4xp+1LWkiAMtZKLi2lmN4k0NX7JmbrB1j4Xwr5O6v Dzrq6vGh76/bDpGErYG32ZLukpVN6ipWzVkuu8IbXzhjksitpTX7PJ/OU3vKDGx/OQ1GV8rHlqZ YrZqdI+gtHj7OwNO2FR9Hau8GO7qfDnZdVcKQkoUERY0JJKZJSDFB7SFWDkoKzKDpcZ04OQyk81 SJSes0cPUpFPOV4oQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--17.652800-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: 10850D7E94D28DE934C1E42B035CD30DCBD485B599CDA87254C3688082180C9E2000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 943a8adb-185c-4ecc-0153-08da8c52bbf3 X-MS-TrafficTypeDiagnostic: GV1PR10MB6515:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6RDdtMOipPbQCCZ/VhCDcc5+vjbPBwMIx583BFLuhJiNc4APcP+Y8Ge2GmV5Bk2iHY1Z8M41L3rhTaTL+LNovQwizV23MEMhOSNWhh+14G4rN/1p4+O7heD+cRuT/5cG/nT3xHKHJLeigTAqZV/CiW2mo3mMFACRq4mUHccxyTFscZVDzqvof+GmUU7tNykj5eXuvT44k2fryjoPYVZV2OWGrJLrKK60XMchBGw920eJ1N4r47MrC8FdYktywPBviyCnSVs4gYNnp9idyoet9YcfhYSIgoepAyoTrFqRsbK56+Tr659bjkUa8p9pfQibE9fbSKB5hhr3p1BfK8gR2r7rpDZRVGotRmLcgheePcms780+d5b3oK67iJNzwaPISmPJr6Q5TLR0dfTV0gWWow8eEiIHK3Epx3Ia4B1D2eAKoLSTXPIwwAq+ZeiKckBZn94C3h8vtR6+Xi7w3wgY/xOixFlW7kOWzHb/IoFcwybmVS6sNjFdvIQRZlT+jfGBw0QtoRNNKF4o4theQR/uoYC0n/Q7Oeehs/YmncBwgib8VFISxZz1FBG8BEDXP16tgS0OGJAG1EMBXlfaWMFvosh3DnBQ0oVtP93UyHdB6CwmNh99nShMjAVdwVCSwl8P5qXklCauUqsSQZpsGR/uT6Y9TT18JS1MkLxQjyd7kZ5Ok33U9yVPZRTkzFUnJU0/9Cw4QMl9p89/Yg6tLWYeQg8xmKpIuyMvYY9FKPyXIp/J3Fdusy/u/e4emIMDjp8ghqNfazaYzhwMMVl7YL65NlSVBC15hX6FBRST4/z4stM1tg14mJNDrSeE5Ux1UJOOFK0Zccqv6nCA3j9LyuoK+uuFuTyqmsG8ubSxzWkgexQ= X-Forefront-Antispam-Report: CIP:194.138.21.74;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:hybrid.siemens.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(376002)(39860400002)(36840700001)(46966006)(40470700004)(47076005)(6706004)(956004)(7596003)(53546011)(31696002)(2616005)(336012)(16526019)(40480700001)(26005)(186003)(82740400003)(7636003)(356005)(83380400001)(82960400001)(40460700003)(86362001)(2906002)(36860700001)(36756003)(82310400005)(8936002)(37006003)(316002)(6636002)(478600001)(41300700001)(70586007)(6862004)(5660300002)(8676002)(966005)(70206006)(54906003)(31686004)(107886003)(4326008)(16576012)(44832011)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 19:46:59.4193 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 943a8adb-185c-4ecc-0153-08da8c52bbf3 X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.74];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR01FT092.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR10MB6515 X-TUID: M8Td0yvGbQ0K On 01.09.22 19:17, Henning Schild wrote: > Am Thu, 1 Sep 2022 18:08:08 +0200 > schrieb Jan Kiszka : > >> On 27.08.22 10:59, Henning Schild wrote: >>> External modules might have their own appends and target >>> definitions in their Makefile. All we need to give them is the >>> target name and KDIR, not dive into KDIR right away. >> >> My observation with external modules makefile having their own rules >> is that they generally also have their own KDIR variables. There is no >> standard way of telling those pick up the kernel from a standard place >> and install it at the standard location. >> >>> >>> Signed-off-by: Henning Schild >>> --- >>> meta/recipes-kernel/linux-module/files/debian/rules.tmpl | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git >>> a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl >>> b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl index >>> d3bd7dc30f21..0d16186b5ff3 100755 --- >>> a/meta/recipes-kernel/linux-module/files/debian/rules.tmpl +++ >>> b/meta/recipes-kernel/linux-module/files/debian/rules.tmpl @@ >>> -48,13 +48,13 @@ KDIR := $(shell dpkg -L $(KERNEL_DEP) | grep >>> "/lib/modules/.*/build") endif override_dh_auto_clean: >>> - $(MAKE) -C $(KDIR) M=$(PWD) clean >>> + $(MAKE) KDIR=$(KDIR) clean >>> >>> override_dh_auto_build: >>> - $(MAKE) -C $(KDIR) M=$(PWD) modules >>> + $(MAKE) KDIR=$(KDIR) modules >>> >>> override_dh_auto_install: >>> - $(MAKE) -C $(KDIR) M=$(PWD) >>> INSTALL_MOD_PATH=$(PWD)/debian/${PN} modules_install >>> + $(MAKE) KDIR=$(KDIR) INSTALL_MOD_PATH=$(PWD)/debian/${PN} >>> modules_install >>> %: >>> CFLAGS= LDFLAGS= dh $@ --parallel >> >> This breaks existing users with makefile that are unusable or do not >> have own rules. I would refrain from that breakage. >> >> If you have a more complex case than what we support, you can simply >> provide your own rules and can then even account for the other >> specialties that usually come with such module makefiles. >> >> Same arguing applies to patch 3. > > I am not sure i would agree that the example Makefile is indeed valid, > since it does not allow self sustained building with a simple "make > modules_install". But yes for modules with such Makefiles this would be > a breaking change. > > Will go and carry the special rules entries downstream, while i still > think Isar should take that and rather make those weirdos carry their > own rules ... accepting a breakage. > > But i have no clue how "weird" vs "common" it would be to have such a > super-minimal Makefile. And my case is probably also not "common" > enough to ague for too long. Isar implements to official way of writing external module makefiles and invoking them, see https://www.kernel.org/doc/html/latest/kbuild/modules.html#command-syntax. Anything beyond in its generic code would be guesswork about how makefiles were written, what they expect as input etc. Jan -- Siemens AG, Technology Competence Center Embedded Linux