Re: [PATCH 1/4] apt: Generate configs for apt

[Alexander Smirnov <asmirnov@ilbers.de>]

On 10/05/2017 02:14 PM, Claudius Heine wrote:
> Hi,
> 
> On 10/05/2017 12:08 PM, Alexander Smirnov wrote:
>> Generate reprepro configuration files for apt deployment.
>>
>> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
>> ---
>>   meta-isar/conf/layer.conf                            | 10 ++++++++--
>>   meta-isar/recipes-core/images/files/distributions.in |  3 +++
>>   meta/classes/image.bbclass                           | 17 
>> ++++++++++++++++-
>>   3 files changed, 27 insertions(+), 3 deletions(-)
>>   create mode 100644 meta-isar/recipes-core/images/files/distributions.in
>>
>> diff --git a/meta-isar/conf/layer.conf b/meta-isar/conf/layer.conf
>> index 72a103c..0950a34 100644
>> --- a/meta-isar/conf/layer.conf
>> +++ b/meta-isar/conf/layer.conf
>> @@ -1,5 +1,5 @@
>>   # This software is a part of ISAR.
>> -# Copyright (C) 2015-2016 ilbers GmbH
>> +# Copyright (C) 2015-2017 ilbers GmbH
>>   # We have a conf and classes directory, add to BBPATH
>>   BBPATH .= ":${LAYERDIR}"
>> @@ -13,6 +13,12 @@ BBFILE_PRIORITY_isar = "5"
>>   # This should only be incremented on significant changes that will
>>   # cause compatibility issues with other layers
>> -LAYERVERSION_isar = "2"
>> +LAYERVERSION_isar = "3"
>>   LAYERDIR_isar = "${LAYERDIR}"
>> +
>> +# Codename of the repository created by the caching class
>> +DEBDISTRONAME = "isar"
>> +
>> +# Path to the Isar apt repository
>> +DEPLOY_DIR_APT ?= "${DEPLOY_DIR}/apt"
> 
> Thanks!
> 
> I would prefer that being handled the same way the DL_DIR and SSTATE_DIR 
> is handled. So the same variable naming scheme (maybe APT_CACHE_DIR) and 
> similar default paths (maybe "${TOPDIR}/aptcache"). The deploy dir is 
> not really the place to do work in.

This should be in deploy directory, because "${DEPLOY_DIR}/apt" folder 
contains self-contained apt repository that could be exported/published 
by Isar user's demand, like images.

> 
> If you want to have something deployed to the deploy dir then it should 
> be done via a recipe. I would suggest something like a 
> "do_deploy_repository_deb" task in image recipes. But thats a separate 
> patch.

Please see the whole series. Apt repository population is performed in 
image recipe by do_populate task.

Alex