From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6561021830257180672 X-Received: by 2002:a50:c30b:: with SMTP id a11-v6mr915903edb.8.1527676358672; Wed, 30 May 2018 03:32:38 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:e84c:: with SMTP id k12-v6ls19905717edn.7.gmail; Wed, 30 May 2018 03:32:37 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLpkfU9TZ8UOVbT0WzbPPD8mmjcRKAIrH/OvTDdvYAfpka5L/3/N6oShVbkKq0TSnKWCRSu X-Received: by 2002:a50:c30b:: with SMTP id a11-v6mr915878edb.8.1527676357875; Wed, 30 May 2018 03:32:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527676357; cv=none; d=google.com; s=arc-20160816; b=WJUMB9GGl/FqE0V4kuggxX3Ub415X3gteldwrqSEHPWeNVhjDwWXld6ny8l+fVg2su f4Ftac9qrq3Dl+JIgY14nXE6cXK3RbXcltmJ6K9JBo4g9CDLktVYJwG4Vry8tOPH/s7G uV8KYOHBfspkeSQO4ZPp4+7RxxMbyiT5ya8riJaC+1qGhx7QSwUtcgCSxl+oQlycYP4Z Vs1GY1zCTAqMQrLzdrhh4sfySYq9kONdcPNBBjL44BoFTtMm8k/9QUxSOWs3MyoZFAAn ycB9aii/30BRY+wQeVjNS8rQSczJ+UPreNVGXlNiVr4eM9i0f8FBFaZMw92XdKXi3GVB 1oYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:references:in-reply-to:date:to:from:subject:message-id :arc-authentication-results; bh=vn0I6yfAVWetjneyC8PujqIKUQ4ivp7btMxyJP/gEi4=; b=KHrJs/h+26mA0ZWjeXSA1oC2zzKfChcN1PW6oKJJ8QgDyDjfmk+spXD+AF/kvKQ+C4 NAWCqXd7fuidhHwWy54/vmBtkcID2Pt68AV9VC5L8tg1D7x0u0OyNrKmFMFNy+uml9uy MnjHoO8iwPq9wHlSgc6LFFUZsSmDwiq1WXMeHmHFWUBSf1eJqaCRh/qV9yddvb47aKCd Ku7aGuscsSpTPsQC9JBkD/7PaBS7Rxc6XURbg97RCkV3fA3lP/Y67f5NAsigvAUwwbH0 XNUejDRy5T6UdjjanAuj75wUeG6qmyQXVSk4fWXBpmi1tQ/yARmV1ob5xrU6dgY8GQTj jlVg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id u9-v6si1546168edp.3.2018.05.30.03.32.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 May 2018 03:32:37 -0700 (PDT) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 40wn3T3z29z1qvnJ; Wed, 30 May 2018 12:32:37 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 40wn3T3cYqz1qqy3; Wed, 30 May 2018 12:32:37 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 3hoK9oYvDvY6; Wed, 30 May 2018 12:32:33 +0200 (CEST) X-Auth-Info: 1uQZMEHpUB3N7L4/fdV4fC6HUtnL2LUuowY+M9fk0Uw= Received: from Orrorin (p578a821c.dip0.t-ipconnect.de [87.138.130.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 30 May 2018 12:32:33 +0200 (CEST) Message-ID: Subject: Re: [PATCH 1/1] meta/isar-cfg-localepurge: move locale configuration inside bb From: Claudius Heine To: "Maxim Yu. Osipov" , Claudius Heine , isar-users@googlegroups.com Date: Wed, 30 May 2018 12:32:28 +0200 In-Reply-To: <95520f31-8fcd-f012-9f43-0188f5312f09@ilbers.de> References: <20180529151527.6090-1-claudius.heine.ext@siemens.com> <20180529151527.6090-2-claudius.heine.ext@siemens.com> <95520f31-8fcd-f012-9f43-0188f5312f09@ilbers.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-pxmh+nRjooI7Ts7n7Zfm" X-Mailer: Evolution 3.28.2 Mime-Version: 1.0 X-TUID: qMs0vt7wRlFj --=-pxmh+nRjooI7Ts7n7Zfm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Maxim, On Wed, 2018-05-30 at 10:38 +0200, Maxim Yu. Osipov wrote: > Hi Claudius, >=20 > Yesterday you've sent this patch over the same codebase you've sent > 3=20 > hours before (One shot configuration patch series V5). >=20 > Is it possible to avoid in the future such frequency of incremental=20 > patches as process of testing/applying patches is rather time > consuming. Yes I will try do do this, but currently not quite sure how. The problem is that I don't like to change a posted and self contained patchset as long as their is no problem with it, so it can be reviewed and eventually merged. Every change to it might delay that. But I still work on top of it and continue adding features and improvements. So I either wait until the patchset is merged before posting or continue posting new patchsets as I work. If I delay and try to have only one patchset on the ML at any time, then I also delay the development time by single threading it. I can do that, but that would be inefficient. I do have the 'release early, release often' mentality when posting patchsets, just to inform people what I am working on and if the might be a conflict or synergy with what others are working on. Hmmm.. maybe I have also a bit different expectations of the review process. When I review patches I would expect that the developer has done some form of testing before posting already and just start reading the code to see what it does. That can be done relatively fast. If I like what it does then I will merge it into a testing branch and test it, afterwards I merge it upstream. For me applying patches and testing them is something done late in the review process. With this patch I wanted the reviewers just to look over the code and comment on it to see if there might be ideas to improve or if this goes into the right direction and not begin with merging and testing testing. Claudius >=20 > Kind regards, > Maxim. >=20 > On 05/30/2018 10:23 AM, Claudius Heine wrote: > > Hi, > >=20 > > sorry, but I messed this patch up. I will fix it an repost it again > > with=20 > > documentation. > >=20 > > Claudius > >=20 > > On 2018-05-29 17:15, [ext] claudius.heine.ext@siemens.com wrote: > > > From: Claudius Heine > > >=20 > > > To set custom locale configuration it in necessary to overwrite > > > the > > > files of isar-cfg-localepurge before. That can be a bit of a > > > hassle. > > >=20 > > > With this patch the locale configuration is generated based on > > > bitbake > > > variables and therefor can be set from outside. > > >=20 > > > The new variables are `LOCALE_GEN` which is basically the content > > > of the > > > desired `/etc/locale.gen` with each line seperated by '\n' and > > > `LOCALE_DEFAULT` which sets the global default locale of the > > > system. > > >=20 > > > Signed-off-by: Claudius Heine > > > --- > > > .../isar-cfg-localepurge/files/locale.debconf | 12 ------ > > > .../isar-cfg-localepurge/files/locale.gen | 1 - > > > .../isar-cfg-localepurge.bb | 43 > > > +++++++++++++++++-- > > > 3 files changed, 40 insertions(+), 16 deletions(-) > > > delete mode 100644=20 > > > meta/recipes-support/isar-cfg-localepurge/files/locale.debconf > > > delete mode 100644=20 > > > meta/recipes-support/isar-cfg-localepurge/files/locale.gen > > >=20 > > > diff --git=20 > > > a/meta/recipes-support/isar-cfg-localepurge/files/locale.debconf=20 > > > b/meta/recipes-support/isar-cfg-localepurge/files/locale.debconf > > > deleted file mode 100644 > > > index 169c071..0000000 > > > --- a/meta/recipes-support/isar-cfg- > > > localepurge/files/locale.debconf > > > +++ /dev/null > > > @@ -1,12 +0,0 @@ > > > -locales locales/locales_to_be_generated multiselect =20 > > > en_US.UTF-8 UTF-8 > > > -locales locales/default_environment_locale select =20 > > > en_US.UTF-8 > > > - > > > -localepurge localepurge/dontbothernew boolean true > > > -localepurge localepurge/nopurge multiselect en, en_US,=20 > > > en_US.UTF-8 > > > -localepurge localepurge/use-dpkg-feature boolean false > > > -localepurge localepurge/verbose boolean false > > > -localepurge localepurge/showfreedspace boolean false > > > -localepurge localepurge/none_selected boolean false > > > -localepurge localepurge/mandelete boolean true > > > -localepurge localepurge/quickndirtycalc boolean false > > > -localepurge localepurge/remove_no note > > > diff --git=20 > > > a/meta/recipes-support/isar-cfg-localepurge/files/locale.gen=20 > > > b/meta/recipes-support/isar-cfg-localepurge/files/locale.gen > > > deleted file mode 100644 > > > index a66d814..0000000 > > > --- a/meta/recipes-support/isar-cfg-localepurge/files/locale.gen > > > +++ /dev/null > > > @@ -1 +0,0 @@ > > > -en_US.UTF-8 UTF-8 > > > diff --git=20 > > > a/meta/recipes-support/isar-cfg-localepurge/isar-cfg- > > > localepurge.bb=20 > > > b/meta/recipes-support/isar-cfg-localepurge/isar-cfg- > > > localepurge.bb > > > index d2cf1f3..f815717 100644 > > > --- a/meta/recipes-support/isar-cfg-localepurge/isar-cfg- > > > localepurge.bb > > > +++ b/meta/recipes-support/isar-cfg-localepurge/isar-cfg- > > > localepurge.bb > > > @@ -4,12 +4,49 @@ DESCRIPTION =3D "Isar configuration package for > > > locale=20 > > > and localepurge" > > > MAINTAINER =3D "isar-users " > > > DEBIAN_DEPENDS =3D "localepurge" > > > -SRC_URI =3D "file://locale.debconf \ > > > - file://locale.gen \ > > > - file://postinst" > > > +SRC_URI =3D "file://postinst" > > > inherit dpkg-raw > > > +LOCALE_GEN ?=3D "en_US.UTF-8 UTF-8\n\ > > > + en_US ISO-8859-1\n" > > > +LOCALE_DEFAULT ?=3D "en_US.UTF-8" > > > + > > > +def get_locale_gen(d): > > > + locale_gen =3D d.getVar("LOCALE_GEN", True) or "" > > > + return ', '.join(sorted(set(i.strip() > > > + for i in > > > locale_gen.split('\\n')))) > > > + > > > +def get_nopurge(d): > > > + locale_gen =3D d.getVar("LOCALE_GEN", True) or "" > > > + return ', '.join(sorted(set(i.strip() > > > + for j in locale_gen.split('\\n') > > > + for i in > > > (j.split()[0].split("_")[0], > > > + =20 > > > j.split()[0].split(".")[0], > > > + j.split()[0])))) > > > + > > > +do_gen_config[stamp-extra-info] =3D "${DISTRO}-${DISTRO_ARCH}" > > > +do_gen_config() { > > > + cat<<-__EOF__ > ${WORKDIR}/locale.gen > > > + ${@(d.getVar("LOCALE_GEN", True) or > > > "").replace('\\n','\n')} > > > + __EOF__ > > > + cat<<-__EOF__ > ${WORKDIR}/locale.debconf > > > + locales locales/locales_to_be_generated =20 > > > multiselect=20 > > > ${@get_locale_gen(d)} > > > + locales locales/default_environment_locale > > > select =20 > > > ${LOCALE_DEFAULT} > > > + > > > + localepurge localepurge/dontbothernew =20 > > > boolean true > > > + localepurge localepurge/nopurge =20 > > > multiselect=20 > > > ${@get_nopurge(d)} > > > + localepurge localepurge/use-dpkg-feature =20 > > > boolean false > > > + localepurge localepurge/verbose =20 > > > boolean false > > > + localepurge localepurge/showfreedspace =20 > > > boolean false > > > + localepurge localepurge/none_selected =20 > > > boolean false > > > + localepurge localepurge/mandelete =20 > > > boolean true > > > + localepurge localepurge/quickndirtycalc =20 > > > boolean false > > > + localepurge localepurge/remove_no note > > > + __EOF__ > > > +} > > > +addtask gen_config after do_unpack before do_install > > > + > > > do_install() { > > > install -v -d ${D}/usr/lib/${PN} > > > install -v -m 644 ${WORKDIR}/locale.debconf \ > > >=20 >=20 >=20 --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153 Keyserver: hkp://pool.sks-keyservers.net --=-pxmh+nRjooI7Ts7n7Zfm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEb/LlnwDGvCgx2GTBEXPLGZgIsVMFAlsOfb0ACgkQEXPLGZgI sVNVeA//fkzaEPtg4VFQtkstpHfuS5KN9oX9bMb8qtD/1vm3oCQG8xUrBsKqviM2 Zxc1C1ZtAmKUYNT6YJqFhjAx+hW3dkWi1amlnHnDkurNQokJvLvNgIUq5eyugytN JFKQNM76xLdz5xshj3fjfDfrSSoSPa/pnpe4Iopqfg4OsycXhvhVHZrq1nei974b 3ktvuYKk0t38Cl6RX9OsT7Y6N0dxvtbTJk/J9m3tjSBGuU14QxyqfGVfYNdNNhaQ 7hLJtEIEKl+uXKyUVcVDTlIjkSxZ8iZuXHy/dIluZFCjH9G5BRLG9HniI1oRpJr0 dSNRyi+zFLuv8Ci0WZldr5RY35U1p6k7u9pyEyAVs3nk0qelzgyWuk0arQLIfhRx RAC1t6y4m1Ephl4TdlmTQmdQwbhxDJ44Ja58okmfehrscQQxIxVIOy5gc0xg5MA5 Bq46g0mYU2U2QsFJYr+lPjWYJYM+5OQZPUQAhCXK7IPgqtHYbee4TpF7e/g5SLOB ItpRW8cW5AAG7sZ5aTYjDtojMyDW9qnbKlEKmMymGheIzTF3hkoLkkvlf71YmvSZ babmq8lw6gfQb+O21OBa0BUDylZyUO1DB019j7O1BGz5CHSWsqpBpeXi6zOtpIM5 OO7Fu0bApVYN6TEMA1kd31ysX8urlT65pDi7XQIFq+deuJHnxkY= =m+vi -----END PGP SIGNATURE----- --=-pxmh+nRjooI7Ts7n7Zfm--