Re: [PATCH] Remove unwanted inherits of base-apt-helper

[Jan Kiszka <jan.kiszka@siemens.com>]

On 19.08.19 12:54, vijaikumar.kanagarajan@gmail.com wrote:
> From: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> 
> After bff4e89a changes, we do not require to inherit the base-apt-helper
> class in isar-bootstrap.inc and base-apt.bb files. Remove them.
> 
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
>   meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 --
>   meta/recipes-devtools/base-apt/base-apt.bb          | 2 --
>   2 files changed, 4 deletions(-)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> index ff8ab01..3410b64 100644
> --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> @@ -32,8 +32,6 @@ HOST_DISTRO_APT_SOURCES += "conf/distro/${HOST_DISTRO}.list"
>   
>   DISTRO_APT_PREMIRRORS ?= "${@ "http://ftp\.(\S+\.)?debian.org/\S* file:///${REPO_BASE_DIR}/${BASE_DISTRO} \n" if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')) else "" }"
>   
> -inherit base-apt-helper
> -
>   python () {
>       distro_bootstrap_keys = (d.getVar("DISTRO_BOOTSTRAP_KEYS", False) or "").split()
>   
> diff --git a/meta/recipes-devtools/base-apt/base-apt.bb b/meta/recipes-devtools/base-apt/base-apt.bb
> index 1c0b4c6..9f55ad5 100644
> --- a/meta/recipes-devtools/base-apt/base-apt.bb
> +++ b/meta/recipes-devtools/base-apt/base-apt.bb
> @@ -3,8 +3,6 @@
>   
>   SRC_URI = "file://distributions.in"
>   
> -inherit base-apt-helper
> -
>   BASE_REPO_KEY ?= ""
>   
>   CACHE_CONF_DIR = "${REPO_BASE_DIR}/${BASE_DISTRO}/conf"
> 

Good cleanup, thanks.

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux