From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6726829733448777728 X-Received: by 2002:ac2:4c12:: with SMTP id t18mr12091675lfq.134.1566213955732; Mon, 19 Aug 2019 04:25:55 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:5053:: with SMTP id z19ls1315013lfj.7.gmail; Mon, 19 Aug 2019 04:25:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwcbUwcRytmyTkicz/PwzCDHjjV4pxm134BMOQgQrDrZQgc/dMkzwH17sIGQqePFW8fkXxx X-Received: by 2002:ac2:5ec3:: with SMTP id d3mr11540929lfq.44.1566213955106; Mon, 19 Aug 2019 04:25:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566213955; cv=none; d=google.com; s=arc-20160816; b=Qf/YCsZwjtyoEQaUsWIQeyRwsrqgEv1xEAF+7gMbGCuCFDxcSWgQ2BUVr7v/LrZwDG RlOOBkdDsCsvDqs0ZdIBk2v07q/0KSkmJLWqWXNoPaaxkTNz0wisF0QVEsr1ySY2FRmj YG4p8bGHbI3ZzfS/XDlyGl7Vr32210QLmiHekkxmqWWrFqtW36Ka+kCECG18P58jZtLz RrSPVNOpiZW6yw3vEYPEckYzaviq0Wcy4ClK2BUgWEsJJxg9Ee0i5gZMzd0hDNaP16S6 UEN/JrAnJ34lm9Ce13A8IPR+XfydW+3f924sob78cGJwY4DW+PV0HSlOpxdeHwG1l7y8 nLig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=hnHwHa2B+ZPR6lNZ47t89pdylTWzXAy8CLQLcppMZok=; b=GFtkkiXO40DeK1ygcA0snt8lVdoDF0XL8T1/A8NbA7lBTbhE4wI1tzW5ztAERX0r+k F/ODvh5viSaiTZNJdC4XclY3CzIRI0iImwywHjb7rLv0E852Db18ljSMnNslC5iKciSs FKlsvL+2u86IKW19D7qnHPVsMvGGki1Nv06GXdHr0UCH1CUMufXuFmtfJR6COe+DjcI1 duCpHjCnWvTY98quBLS0CqnTgBYuW/Ud9hVdFxI6tjZRz2VNMX16k7GkFAF1tLFypk+C PROWkPHOK14cP9BVtetveoViHmNuyg8m8m23v9KWSP/FPTxZOWHafTskeYT81qTELkdr rjdQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id h19si675748ljj.3.2019.08.19.04.25.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 04:25:54 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x7JBPrN9005133 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Aug 2019 13:25:53 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x7JBPrKV010861; Mon, 19 Aug 2019 13:25:53 +0200 Subject: Re: [PATCH] Remove unwanted inherits of base-apt-helper To: vijaikumar.kanagarajan@gmail.com, isar-users@googlegroups.com, henning.schild@siemens.com, claudius.heine.ext@siemens.com Cc: Vijai Kumar K References: <20190819105447.5852-1-Vijaikumar_Kangarajan@mentor.com> From: Jan Kiszka Message-ID: Date: Mon, 19 Aug 2019 13:25:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190819105447.5852-1-Vijaikumar_Kangarajan@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: jlstRb7QlXue On 19.08.19 12:54, vijaikumar.kanagarajan@gmail.com wrote: > From: Vijai Kumar K > > After bff4e89a changes, we do not require to inherit the base-apt-helper > class in isar-bootstrap.inc and base-apt.bb files. Remove them. > > Signed-off-by: Vijai Kumar K > --- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 2 -- > meta/recipes-devtools/base-apt/base-apt.bb | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > index ff8ab01..3410b64 100644 > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > @@ -32,8 +32,6 @@ HOST_DISTRO_APT_SOURCES += "conf/distro/${HOST_DISTRO}.list" > > DISTRO_APT_PREMIRRORS ?= "${@ "http://ftp\.(\S+\.)?debian.org/\S* file:///${REPO_BASE_DIR}/${BASE_DISTRO} \n" if bb.utils.to_boolean(d.getVar('ISAR_USE_CACHED_BASE_REPO')) else "" }" > > -inherit base-apt-helper > - > python () { > distro_bootstrap_keys = (d.getVar("DISTRO_BOOTSTRAP_KEYS", False) or "").split() > > diff --git a/meta/recipes-devtools/base-apt/base-apt.bb b/meta/recipes-devtools/base-apt/base-apt.bb > index 1c0b4c6..9f55ad5 100644 > --- a/meta/recipes-devtools/base-apt/base-apt.bb > +++ b/meta/recipes-devtools/base-apt/base-apt.bb > @@ -3,8 +3,6 @@ > > SRC_URI = "file://distributions.in" > > -inherit base-apt-helper > - > BASE_REPO_KEY ?= "" > > CACHE_CONF_DIR = "${REPO_BASE_DIR}/${BASE_DISTRO}/conf" > Good cleanup, thanks. Reviewed-by: Jan Kiszka Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux