Re: [PATCH 0/7] "apt-get source" fetch/unpack support

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi Henning,

On 17/01/2019 17.38, [ext] Henning Schild wrote:
> Am Thu, 17 Jan 2019 17:04:20 +0100
> schrieb Henning Schild <henning.schild@siemens.com>:
> 
>> From: Henning Schild <henning.schild@siemens.com>
>>
>> This series includes support for fetching upstream sources with
>> "apt-get source". This will make sure we fetch exactly what matches
>> out distro, without rewriting debian fetch/unpack logic.
>> I did consider implementing it as an "apt://" extension to the regular
>> fetcher but decided against that. You have to set SRC_APT and
>> effectively pass arguement to apt-get. That fetcher can only work in
>> packages and depends on buildchroot and mounting, so it can not be
>> part of the general fetcher. But maybe the general fetcher could
>> ignore "apt://" lines and this task will ignore anything but "apt://"
>> so we can still use SRC_URI instead of SRC_APT.
> 
> Filtering all the "apt://" entries out does not really work. There is a
> call to bb.fetch.get_checksum_file_list where i can not filter, at
> least i did not yet figure out how.
> 
> And it seems that the fetcher can not be extended with a new protocol
> without touching the bitbake core. Otherwise an empty implementation of
> "apt://" would have been the trick to let debian do it in a completely
> different step.
> Not sure it is worth forcing it into SRC_URI, we are in two worlds
> anyways, no need to pretend otherwise.

Ok thx! As for variable conflict: There is "APTSRCS" in isar-bootstrap, 
which it IMO far enough away from "SRC_APT", so that name would be OK.

Claudius

> 
> Henning
> 
>> Let us talk about the
>> interface. The documentation is still missing, but i thing it is
>> ready for a first review.
>>
>> The idea and parts of the code came from Mentor.
>>
>> Henning Schild (7):
>>    conf: add deb-src entries to all our distro configs
>>    dpkg-base: introduce an "apt-get source" fetch/unpack step
>>    meta: move debianization code into a class and into dpkg-base
>>    debianize: allow changlog version change
>>    meta-isar/recipes-app: add upstream hello rebuild example
>>    local.conf: remove example-hello from the default build
>>    local.conf: enable rebuilding "hello" for all distros
>>
>>   meta-isar/conf/distro/debian-buster.list      |  3 +
>>   meta-isar/conf/distro/debian-jessie.list      |  3 +
>>   .../conf/distro/debian-stretch-backports.list |  1 +
>>   meta-isar/conf/distro/debian-stretch.list     |  3 +
>>   meta-isar/conf/distro/raspbian-jessie.list    |  1 +
>>   meta-isar/conf/local.conf.sample              |  2 +-
>>   meta-isar/recipes-app/hello/hello.inc         | 19 +++++
>>   meta-isar/recipes-app/hello/hello_2.10.bb     |  8 ++
>>   meta-isar/recipes-app/hello/hello_2.9.bb      |  8 ++
>>   meta/classes/debianize.bbclass                | 82
>> +++++++++++++++++++ meta/classes/dpkg-base.bbclass                |
>> 20 +++++ meta/classes/dpkg-raw.bbclass                 | 76
>> ----------------- 12 files changed, 149 insertions(+), 77 deletions(-)
>>   create mode 100644 meta-isar/recipes-app/hello/hello.inc
>>   create mode 100644 meta-isar/recipes-app/hello/hello_2.10.bb
>>   create mode 100644 meta-isar/recipes-app/hello/hello_2.9.bb
>>   create mode 100644 meta/classes/debianize.bbclass
>>
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de