From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145516460113920 X-Received: by 10.46.31.2 with SMTP id f2mr119609ljf.31.1504538268017; Mon, 04 Sep 2017 08:17:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.199.198 with SMTP id x189ls1350047wmf.17.canary-gmail; Mon, 04 Sep 2017 08:17:47 -0700 (PDT) X-Google-Smtp-Source: ADKCNb6bKEKTZ/TO+V3G75LjLKYYtBbdN+I84Suc6a86E9nJS97zY5zLI/kknFI9OKoZHcPagmEf X-Received: by 10.28.16.71 with SMTP id 68mr100888wmq.12.1504538267237; Mon, 04 Sep 2017 08:17:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504538267; cv=none; d=google.com; s=arc-20160816; b=pU9eg9hBMYP5XREBowFByLnkzvA7YpEWKIWNk+yA2hewtG/9e6wnQtyqEzB2iu5pKp ATEV7Bo8vhfUoCLGSpM7ehhMSTALzpQVPdHHGp8Qdq6I9nOkMJeLY84ASQ7oQ46DPMSQ WrRi1OLa8xZuvYewqIUJmOCC9TLygBPk0T7BNkBNZ7bJXk1S+lSjLrMvxsRTn+aNKFD0 ZlvcX48G4/BqN0obJQfwVQHbJG5v0f8OI8NXBtwd2xrcxfLgmXbnqsMQf70/FuEfJx8m hRAletT5lTes812G81KAmiXE3BW49PNJjrolIpRoCcUwrHbz2LLkpm7lt8uTzBundM7R +FKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=1DcZW6gqaV5w0f+ZHVWXbcAZO1k2yMyedkbsuWhc998=; b=qJKKKjCHeazj8Cxkpc4FbRreRLZeirn+ufX0ClhbeSR3r4kpNafSwSMoZxJ4KS3tDO IOVpMJhGJ7MNzl3GDt0cI2BntmsJerKe43aQWfe78TuJRfIYm5RYeTFdEgYIwGGac17g gqEO4NFlCG0FkqPfRmK9R2AwAxlj0TWOmT1OisDEbS5ijxpg4vaEHtvWSEYfy/9oA1h6 GjXAZVswlBJgESy2QpSi6SP6+jJFcVnGJcEyX3SFWttKOUN3ag1jU//2yOtEIVbvcBhm CLoOJUlSqeMxMPMKAeyyr4roqIwAcu2m1AbN13uwlqCKcnvGm4XrFlmMmDaSwocNkN1O Jxmg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id y62si719981wme.1.2017.09.04.08.17.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Sep 2017 08:17:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v84FHi8n008967 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Mon, 4 Sep 2017 17:17:46 +0200 Subject: Re: [PATCH 3/6] meta/dpkg: rename to dpkg-debian and add comment To: isar-users@googlegroups.com References: <9e4ec5fd512461f19aebdda5420544bc91fadb17.1504119538.git.henning.schild@siemens.com> From: Alexander Smirnov Message-ID: Date: Mon, 4 Sep 2017 18:17:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <9e4ec5fd512461f19aebdda5420544bc91fadb17.1504119538.git.henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: S0ENb9Q151/R On 08/30/2017 10:03 PM, Henning Schild wrote: > Issues: > In order to have multiple classes that create debian packages we need to > come up with different names for them. > Please describe, what do you mean by multiple classes to create debian packages? Why single class is not enough? What should do the other classes? -- With best regards, Alexander Smirnov > Change: > Give the class a name that is supposed to reflect that this class should > be used if you have sources and a /debian directory for them. Also add a > small comment to the header to make that more clear. > Update the one user in the Isar repository as well. > > Impact: > This patch does not change the behaviour of Isar. It addresses the > issue. However, all forks of Isar will have to update all recipes that > inherited the class. > > Signed-off-by: Henning Schild > --- > meta-isar/recipes-app/hello/hello.bb | 2 +- > meta/classes/{dpkg.bbclass => dpkg-debian.bbclass} | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) > rename meta/classes/{dpkg.bbclass => dpkg-debian.bbclass} (84%) > > diff --git a/meta-isar/recipes-app/hello/hello.bb b/meta-isar/recipes-app/hello/hello.bb > index 56424fb..30cf8a8 100644 > --- a/meta-isar/recipes-app/hello/hello.bb > +++ b/meta-isar/recipes-app/hello/hello.bb > @@ -15,4 +15,4 @@ SRCREV = "ad7065ecc4840cc436bfcdac427386dbba4ea719" > > SRC_DIR = "git" > > -inherit dpkg > +inherit dpkg-debian > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg-debian.bbclass > similarity index 84% > rename from meta/classes/dpkg.bbclass > rename to meta/classes/dpkg-debian.bbclass > index 0b8c7c4..7466254 100644 > --- a/meta/classes/dpkg.bbclass > +++ b/meta/classes/dpkg-debian.bbclass > @@ -1,5 +1,9 @@ > # This software is a part of ISAR. > # Copyright (C) 2015-2016 ilbers GmbH > +# > +# This class allows you to build debian packages from sources. > +# These sources need to be enabled for that, they need to have the > +# debian/ folder. > > # Add dependency from buildchroot creation > DEPENDS += "buildchroot" >