From: Alexander Smirnov <asmirnov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>, isar-users@googlegroups.com
Subject: Re: [PATCH 1/2] buildchroot: Do not call 'apt-get update'
Date: Mon, 5 Feb 2018 20:06:06 +0300 [thread overview]
Message-ID: <b3f527d7-2ed6-3564-2d53-10353d17662c@ilbers.de> (raw)
In-Reply-To: <61174b4b-84a8-aca5-f163-5137fe932e81@siemens.com>
On 02/05/2018 07:51 PM, Jan Kiszka wrote:
> On 2018-02-05 17:43, Alexander Smirnov wrote:
>> We should not do this to avoid local Packages.gz update.
>>
>> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
>> ---
>> meta/recipes-devtools/buildchroot/files/configscript.sh | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/buildchroot/files/configscript.sh b/meta/recipes-devtools/buildchroot/files/configscript.sh
>> index 9813c9a..458c94b 100644
>> --- a/meta/recipes-devtools/buildchroot/files/configscript.sh
>> +++ b/meta/recipes-devtools/buildchroot/files/configscript.sh
>> @@ -44,5 +44,4 @@ mount -t devtmpfs -o mode=0755,nosuid devtmpfs /dev
>>
>> #configuring packages
>> dpkg --configure -a
>> -apt-get update
>> umount /dev
>>
>
> Can you also explain why we (no longer?) need this? Just to ensure that
> there are no subtle issues waiting to be surfaced.
Multistrap calls 'apt-get install' for the list of packages, so at this
point the '/var/lib/apt' folder is created. So the upstream state used
to generate buildchroot is cached.
The line I removed in this patch, is called *after* rootfs generation,
so upstream state in cache could be possibly updated, do we need that?
Alex
next prev parent reply other threads:[~2018-02-05 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 16:43 [PATCH 0/2] mounts for buildchroot Alexander Smirnov
2018-02-05 16:43 ` [PATCH 1/2] buildchroot: Do not call 'apt-get update' Alexander Smirnov
2018-02-05 16:51 ` Jan Kiszka
2018-02-05 17:06 ` Alexander Smirnov [this message]
2018-02-05 17:25 ` Jan Kiszka
2018-02-06 9:12 ` Alexander Smirnov
2018-02-06 9:13 ` Alexander Smirnov
2018-02-06 9:38 ` Jan Kiszka
2018-02-05 16:43 ` [PATCH 2/2] buildchroot: Permanently mount '/dev', '/sys' and '/proc' Alexander Smirnov
2018-02-05 16:53 ` Jan Kiszka
2018-02-05 17:16 ` Alexander Smirnov
2018-02-05 17:30 ` Jan Kiszka
2018-02-05 17:32 ` Jan Kiszka
2018-02-05 17:50 ` Jan Kiszka
2018-02-05 18:03 ` Jan Kiszka
2018-02-05 18:03 ` Alexander Smirnov
2018-02-05 18:06 ` Jan Kiszka
2018-02-06 9:38 ` Jan Kiszka
2018-02-06 9:43 ` Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f527d7-2ed6-3564-2d53-10353d17662c@ilbers.de \
--to=asmirnov@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox