Re: [PATCH] meta/classes/sdk.bbclass: add --transform in TAR_OPTIONS

[Jan Kiszka <jan.kiszka@siemens.com>]

On 31.03.23 12:33, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
> 
> When we untar the SDK rootfs archive file, all the contents are extracted
> into the current directory, not a folder, this looks ugly hence fixed
> it with the file name transformations option.
> 
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
>  meta/classes/sdk.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index 06cae02..50f718c 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -53,6 +53,7 @@ ROOTFS_MANIFEST_DEPLOY_DIR:class-sdk = "${DEPLOY_DIR_SDKCHROOT}"
>  ROOTFS_DPKGSTATUS_DEPLOY_DIR:class-sdk = "${DEPLOY_DIR_SDKCHROOT}"
>  
>  IMAGE_FSTYPES:class-sdk = "${SDK_FORMATS}"
> +TAR_OPTIONS:append:class-sdk = " --transform="s|.|$(basename ${PP_DEPLOY}/${IMAGE_FULLNAME})|""
>  
>  # bitbake dependencies
>  SDKDEPENDS += "sdk-files ${SDK_INSTALL}"

To my understanding, this will move the content of the SDK tarball into
a subfolder. What will that name be? ${IMAGE_FULLNAME}? And isn't
$(basename ${PP_DEPLOY}/${IMAGE_FULLNAME}) the same as just
${IMAGE_FULLNAME}?

I'm fine with the relocation per se, I'm just wondering if we documented
or otherwise referred to the structure of an unpacked SDK somewhere, in
the user manual eg., and if that then also needs updating.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux