From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7184872845710721024 X-Received: by 2002:a17:906:2b54:b0:7c0:e6da:e25a with SMTP id b20-20020a1709062b5400b007c0e6dae25amr5370155ejg.22.1672903129229; Wed, 04 Jan 2023 23:18:49 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:3d62:b0:7ad:9efd:4692 with SMTP id r2-20020a1709063d6200b007ad9efd4692ls7915273ejf.4.-pod-prod-gmail; Wed, 04 Jan 2023 23:18:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXtbN+DqU0Ed5VsoDSvFll+8kn6vZNNuc8ok1l26cs4UYqClTOZlc4txPmdul9vkrVCAjZnd X-Received: by 2002:a17:907:1b8f:b0:7c0:d2b2:eb07 with SMTP id mz15-20020a1709071b8f00b007c0d2b2eb07mr42145680ejc.26.1672903127885; Wed, 04 Jan 2023 23:18:47 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1672903127; cv=pass; d=google.com; s=arc-20160816; b=CNCAkMgK5tfdv+Fbr7a1i7wuqmahzH+IHuuz0QP7gGSW/Sw+VRPFZRTy5dBQkD1tKm 26ce0pVowebnCZoPbsmvIupmKlOj2nklNgSiYs2lLjP40rFRejpgeFkBKBa+bfq+rM8F Sh5Z6NcuZrer0JbqcxLgjY3IzTDktt7GMN7+CXig0Nj8jVDrdoLape2z1Lvz+pb8//Hk 2KqMROnwgqy7D1PTgQOV41g8ScCRKcULa7olt3G8mza7jp6AcoDp6LNxm7b/YSazuifg LzHEA5b8dfbrBGcEbb3LS8IDnCAWIs27Ljy5Iqhq9ytLJVz8CiG0jNNXHOyPRkd3OyKH Prlg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=zAf/yrBLZUcpN9+17Ec0716YW2tFI042IL5z8V1oXcU=; b=s4UPWgjCXHnNODVPjNu2PV53SAXZFcq6qT8bVswMqRr8rYIvigqOvTeQH6NF1PMPz1 DxWXvgaG5W51E+HgqXf/e1NvwuAZ4MJC3WopRnmKmRrp8PLWUToIApx71EXC9E3oepIm ySMJxxqAz18KmUAiMr3SED2keOeu94fml+LiN58zlHB64vKoa/J6W7Esjj5p5D18D4lU ZSmBSzuzumW6+RFiIGJSIE+yCT6DS1czEfCeffDWfyU2gZ5QBfQjJol4ylSULB+1GT2V oow+YjqbIz2jY70O3snszikD++xEiDkwTbWBX2S+pIudcJ1yqxdgVFsC2Cho80JKaioC rSSQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="j0MUE/jP"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.83 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2083.outbound.protection.outlook.com. [40.107.7.83]) by gmr-mx.google.com with ESMTPS id hx9-20020a170906846900b007ba8b8a416fsi1386638ejc.2.2023.01.04.23.18.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jan 2023 23:18:47 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.83 as permitted sender) client-ip=40.107.7.83; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="j0MUE/jP"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.83 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHREOv9mBMpmdW3OhXGUJIGjfzh0z8JyqCo7t7aHhZLP+V1Oub5zc5WDT9OBV3/6OqkovDZryhaoQt4r/eyT/47evdXJK2Rz4/ppBPWSjerviiy2onOQkPK5WCSK5fYh/dE2r86IUyIlN3r8opGL69WpCrkTSLt237wRMqeFL0WZagh6P7ZBuJU7RxsfgGqZ0UmMOzqXqAMKhGqfuMsGwPFK71L41FsEZLLH/8oUbAnDEIUIXzLZ5gYYxKqtpATIN6i9rdsL/sUGFj7jiEOy9fla9gnSSpAZ8aOVZKaQr6fKmQh0aRO9VIs1Lhf/M3/A7a7oguRN3pcJpw1h1I5p5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zAf/yrBLZUcpN9+17Ec0716YW2tFI042IL5z8V1oXcU=; b=VknoghxrG5q8HOZSNWc9mM5KE2st2dGbIWvTvT2OsfX4ZmaR7vsuW15o4NhU/X6fm7SyXlMPAqeTsrdut3lZHJlXeMEHC9ZFEq9118XC0bGACW6WyVeOSrlCIEl0npZbWa0wAwe34sNMnHKI1U/JI7yzv/rDHhQggwxVnHNgpLZiqAS+ASCtCgDOIp95AR3CskBLy5prznXFVXf3JpNLYqSRICsDcXtZiQYKllHvzyGLo5WH7IyKYb4rD6tthKX5bdLJV1xlmFRQ4OthRTUtwjR6+uJZ/xccxXXNCDQEqlPyJl11+w6NUjvyJ+HHBC44nkxjkSn1+uQ+c+hXHm9f5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zAf/yrBLZUcpN9+17Ec0716YW2tFI042IL5z8V1oXcU=; b=j0MUE/jPLVnrT+jb/k0QoBzBfutqTqd3XBuA+1soYjQAnBhWuHirSmsW82ul+m/SAzzjKLL05CicZuFFbxHIXwjxWKeVYyUEsk4+IKKe8Bkom19f8TsY5GXaPuk8aGPJiLG6lTmdgxgUTD4aV8zc63OPeLXpGVez4WYgMWGaV65OBYtKVED1qI1HxNKFwxjnaf9lyT4vz5KOuy/gxVuqAJaOeVI5jZuHwNgzbQVZZgihMCfUsvqzFJ0tj2HrNcl4YAXa4ZgX/mcfRZZjA8GdaihvG7Mi9DAZA+r50Isq5SAZclHS7qOdR7vNrZD18MTb83xyoKFaYp7nYvHnrkjqZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by VI1PR10MB3983.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:800:138::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 07:18:46 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2957:50e8:8ce6:124a]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::2957:50e8:8ce6:124a%9]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 07:18:46 +0000 Message-ID: Date: Thu, 5 Jan 2023 08:18:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] rootfs class lock undefined in corner cases fix Content-Language: en-US To: roberto.foglietta@gmail.com, isar-users@googlegroups.com References: <20230104194646.2545099-1-roberto.foglietta@gmail.com> From: Jan Kiszka In-Reply-To: <20230104194646.2545099-1-roberto.foglietta@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0148.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::7) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|VI1PR10MB3983:EE_ X-MS-Office365-Filtering-Correlation-Id: f4b87612-f521-4972-c4e0-08daeeed157f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JpNVXwotokHULBYyO6EtkKsqsXVoID/XQg+8At+acSB/0A3noVNPTU/5zj83eSQkJgZ0K8LxuYfGdEiIkm7+4gxbzzAEZyrYrzH2rCe7ECOnEOKAE97RLAMZ8UhaU/8v1Zebs9m+tvXMjK2+GhqgJM4TDT/2NzLrrS+nCtbJCW5fzXwjaQZiT3su63soD6p8tFvl7kkiY0nS0CLN7p2G7Yg363Q+csMbp2x3mp3wtR0+7d1eNT9QADTZO4ANi/ZZUPLyMGWyMjyvQ4+qW7QRSg0cE5Q52ortbukASRYbRibymG15d0NYd5P/2rRrotgUy4d49XTfd+nCIcViZbIMUoApbWLx118RFC70PJhsrrjpBNuUY1MQj8ljumdXruiNLX+5wrw+xL3wsILFJsmIkwLbIsqh10lA5/c+BG5t0z6cPEyzrK7VuWoNfWw6vYe+qxcceUYNqgIVHiuKGTj6jbxhinElEXemyrowvjGOXL6gwJupJPgHCqENUZtqyDcLGCo58FiisH4d6CqxFg9mQWWIo1SjCVV24Vw2owV9W8pby8EvqnMuNzIEmmsrdNks5FfnonXUTX1TZoGB1WqRScn23T37y2/E8scvEeYhYCVfg+sRMOts6/FQVIpew1jYr2uZcGmRllWypjPUNam3GLaIr6Z+XhdaQCDNRkrLhrW39aFvIfoivGm7fMsOjGcvVpqkfWfzC6M05InCH5BYWGU4fwyTbUBUXp52JVCN6kQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(451199015)(38100700002)(83380400001)(66556008)(82960400001)(86362001)(5660300002)(478600001)(31696002)(44832011)(8676002)(2906002)(66946007)(66476007)(41300700001)(186003)(26005)(6666004)(8936002)(2616005)(53546011)(6506007)(6486002)(316002)(31686004)(6512007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWIycWlJS2lYQlVvMnA1NTBwK1Bxd3lScW84TmpEbWQxWDlRaXVGQTZFYVRG?= =?utf-8?B?TGM1WjJVejQ3RnZiRU5MMWR2a1hUMWtpWkVNT1luNWZibTFzSEdKbDV6RVBJ?= =?utf-8?B?bEpGc0t4dEcvaTNmaEFtWHVvc1JoS1ZaWEJ6bnJSOWFESjhSbCt6RThPR0pH?= =?utf-8?B?YUZLUWNLVC90Q0JtZTEzaE1sQXN5UUQ4NWlnbkhzZzd5bFFBN29haE1DSjBB?= =?utf-8?B?Mm5ZMUFRT0doQndvekhuSkxIZGVrUVNpL05nVDJjTlAzRWJGMUNhUU54bDl1?= =?utf-8?B?ZWdkODFDczlleDViV1EvVmtoT3JwVTkzZE95VGh0c2JMTDVGSkFmZWwxNm5r?= =?utf-8?B?RW1xS29RWFVXZkQ4ZHdzT0xlYVBpQ1pSM2RkSlNoM1FCVFZQekpQck9ZMFdO?= =?utf-8?B?QzRNbHN6WmRaMFZCTCttd04rKzNtdlU4WTZXUlJBZ281Q0g2NHM2akNRd2ZL?= =?utf-8?B?Z0pxTEhqY2dFSnhiTm4ydm45Q2NHd1FjMVhqVmRjZGptK1IzNndaRFZKNDFW?= =?utf-8?B?cW9hRVROY21PZ1RjcjZMY2c1WVM0cVR4T2d0ZHo0aVU1WHpMM1dZemt6ZFJh?= =?utf-8?B?cTJzYXNIemd3MktWdW5naG1yK0JPM0lyaFNuL0lOWVFOZnY5akhTeW5EdW1r?= =?utf-8?B?aTdKZ3dYV1dzbWVRbUwzc2RZMFVac0FtY1RsTnZhL21rNWJUeWpRZWYwREt5?= =?utf-8?B?eEVQRnRxQlRENmQySk9KWC9CTmxOd21GOWlIRkl2WmNES3AyWkFHYjBQYm1r?= =?utf-8?B?YU9EZS9PRWl5b2tZemkwSllXUWpJUDVuUzRiWDUzWTRTYndkdjNmS0FJTU5Z?= =?utf-8?B?Qm5UckdqOTBaTy9Fdnc1Q3pBNU42Smo4WEwyVHZTL01TVVZpVFhKcnp0Tm9t?= =?utf-8?B?akJSRWhtLzllV2VDQVAvSGhRUUJLeDhJSlh5azNoQm01VjdJNWJiZ1BtOThi?= =?utf-8?B?SzYzaUd0bjNGRkNTTzFJMGdHNVZiMWJHL1d1R1pyQVd0MWI1TUdZUmRqYTNj?= =?utf-8?B?b3RMVEJEWmJ0MjdKUFRMVlpQSTRFQlJGcFdMZ0VBb3kzeExwRjZ4Ym9TOGpT?= =?utf-8?B?TDcwOTh5S0FzZ3VuQ2lSc3ZJa0wvTjByODQ4Y2p4ZVVtcnIvQlhMNDZ6NW9B?= =?utf-8?B?UTNzZFN5cHp3R3ZKaFpuMFZ4Q1FUUURRU1RXcTZQdWJGOEZKVzdRdk4vQlFv?= =?utf-8?B?UHNJbEhaUEFqWW1PQnI5V1phVW9MOXdLSDBYOHZNRlUzT2JHNnJkN0ZIN1Rx?= =?utf-8?B?NEwyQk53TzhTUS9xVjNGS3hLV1l4RWlXM2FUY0o0WVFUa2U0NG02WmYvSFRB?= =?utf-8?B?c05XQlVuckQ0cDNSNElhcmgxZjQ4dzRvRnozVGo5VnBnQW00TDNyVGNMRU9B?= =?utf-8?B?MnpWaDZxUnZCa0JMRFEyUkRHOGZEMlFHTHZ4b3M3bzJCejhHM05xOGlsWGFy?= =?utf-8?B?Wi9ERm56bjVBOE1YTFVaQXZvWEI2cTArWGxlaUJFTkFWblFXMXcwSFhpNGNU?= =?utf-8?B?ZUZvQzBRemJVdThFWWVxOUM2WENvK3liSEx3RUV2a1ZNK1FSWTZpSmVpQzZl?= =?utf-8?B?TGdvSUVMVWkrd2ZKb1NTTkZleG93MnVwSldzaUp5TnV4UHhlczU1QmlnRkh5?= =?utf-8?B?clpVSFo0MEh2cmYxaUg4WTdmSVZBYjBBZG0vZ3NCeXFheVFOMzBtK2FKM1N4?= =?utf-8?B?cGJ3RzZXZnF5NndGTVlyckRHRzJtMzVuN1h2RjUwWEJLRDMvUjA5R2V6dk9F?= =?utf-8?B?cnZPWU5NeGpTc3lSME4zVldBaEpJem45QkRzVkZVNWdYTGN4RWlyejVseVkz?= =?utf-8?B?TzdmUTZxWDdub2hFQXhSTHU5K3VjVDd0aVFmOEdreHN1K0hwSGs4N0o1VGpZ?= =?utf-8?B?aGpNUWx5Rm1CVmw2cEFvLzhaWUZxQm9LOXRmVVA2bzcyMVhuNjJpNGZqNkVj?= =?utf-8?B?WVNQUHJjaEdWRjJtamQxclNXSlJwVUdtUVVVTmNaQ2pJdFZaa2xGeGJqWTZR?= =?utf-8?B?THNiZ2dtQXorb3ZGVktOTnB0UXVWVmtHNmIvSUpTNEl4S2xhNzFxSmxtUzFm?= =?utf-8?B?b0IvOXdnOFJCeUtCMmp0UVhjb0NQeFF0Z2pmbG1tclcvWGVtdGhJekZmUEQz?= =?utf-8?B?R2tQaUI5Y3F1Q3BaWmFsRzdqcXBFNGFQN1gwa00yNlcxbHovbEtWR3FHVU9l?= =?utf-8?B?b0E9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4b87612-f521-4972-c4e0-08daeeed157f X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2023 07:18:46.2794 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7H3v9LlCBqdqArDRjaGU6dje9LQ6j6IJwa60v710fzO34tvf2CcEGMTZ7X136AXJ1Un2vrVU5Ix31x7it3rJcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3983 X-TUID: h5TL2iZ2t48h On 04.01.23 20:46, roberto.foglietta@gmail.com wrote: > From: "Roberto A. Foglietta" > > rootfs class lock undefined in corner cases fix > > Signed-off-by: Roberto A. Foglietta > --- > meta/classes/rootfs.bbclass | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index b3faade..63735d4 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -198,11 +198,14 @@ python do_rootfs_install() { > if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "acquire-before": > lock = bb.utils.lockfile(d.getVar("REPO_ISAR_DIR") + "/isar.lock", > shared=True) > + else: > + lock = "" > > bb.build.exec_func(cmd, d) > > if (d.getVarFlag(cmd, 'isar-apt-lock') or "") == "release-after": > - bb.utils.unlockfile(lock) > + if (lock != ""): > + bb.utils.unlockfile(lock) > progress_reporter.finish() > } > addtask rootfs_install before do_rootfs_postprocess after do_unpack I thinks you didn't understand the logic yet when you are proposing such a change and you are rather papering over a downstream issue: missing "acquire-before" in a commend chain that later on has a "release-after". We can improve detecting such bugs by asserting on lock being defined when running into a "release-after". Jan -- Siemens AG, Technology Competence Center Embedded Linux