Re: [PATCH 1/3] dpkg-base: Fix buildchroot dependency

[Alexander Smirnov <asmirnov@ilbers.de>]

On 11/21/2017 10:10 PM, Henning Schild wrote:
> Am Tue, 21 Nov 2017 21:49:38 +0300
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
>> Existing code forces recipe to depends from 'do_build' task for all
>> the items listed in DEPENDS, what actually makes no sense. This task
>> only produces binary deb package and it can't satisfy any dependencies
>> for another task.
> 
> With DEPENDS you would also say that application1 that you build in
> buildchroot needs lib1 and lib2 and buildtool3, and you have recipes
> for all of those (they are not upstream debian).
> Now requiring .debs makes some sense because now the "apt-get install
> -y $DEPS" could actually install them in buildchroot. I do not think
> that works at the moment, because the Isar repo is not in buildchroot
> multistrap.
> 
> Technically both versions are wrong, so applying that patch does not
> seem to improve the situation.

IMHO not so bad. Current usage of DEPENDS is invalid, so the patch drops 
this from Isar. I should come back with complete dependency implementation.

Also I'd like to split deps from buildchroot and deps between packages. 
They are different. Also packages possibly will use different task to 
implement interpackages deps, for example:

  - buildchroot:do_build
  - package_X:do_populate_buildchroot

So anyway it needs to explicitly set dependency from buildchroot:do_build.

> 
> We need an example of two packages from Isar that actually DEPEND on

That's true.

Alex

> each other in buildchroot. I think Christian has patches for that
> problem.
> 
> Henning
> 
>> Original idea was to add dependency from 'buildchroot:do_build' task,
>> so this patch fixes this.
>>
>> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
>> ---
>>   meta/classes/dpkg-base.bbclass | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/dpkg-base.bbclass
>> b/meta/classes/dpkg-base.bbclass index 35af6d5..4941f9b 100644
>> --- a/meta/classes/dpkg-base.bbclass
>> +++ b/meta/classes/dpkg-base.bbclass
>> @@ -2,8 +2,7 @@
>>   # Copyright (C) 2017 Siemens AG
>>   
>>   # Add dependency from buildchroot creation
>> -DEPENDS += "buildchroot"
>> -do_build[deptask] = "do_build"
>> +do_build[depends] = "buildchroot:do_build"
>>   
>>   # Each package should have its own unique build folder, so use
>>   # recipe name as identifier