From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6490941990528614400 X-Received: by 10.223.157.206 with SMTP id q14mr734951wre.11.1511292836743; Tue, 21 Nov 2017 11:33:56 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.170.72 with SMTP id q8ls487942wrd.3.gmail; Tue, 21 Nov 2017 11:33:56 -0800 (PST) X-Google-Smtp-Source: AGs4zMYTpZohO1LFtGvCvhCliWn381TWd2cnzTQEi+bwpaIfB/xojLjNSRoB0tCN4CTCQC036wvS X-Received: by 10.28.156.76 with SMTP id f73mr314391wme.4.1511292836498; Tue, 21 Nov 2017 11:33:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511292836; cv=none; d=google.com; s=arc-20160816; b=X4Tal+PwhVpc3l6KBMYKbMjMuMMVQn9P7LOlujDxA40diO4M06QpkFRR7AtYQz+qoo krRUwd0S4i0suVP+vhC0J5H0/CnHOCjqBRsEmo00I+ZlwZ88z6I1WFyo14IVfZ5bTLWN 5EFnu2MmQfcxhOYNhyoZE9G44xt/vW1IkvDTtw0dvPVBbBEhRuxh5/3VL/0RCGxyY/ek zHmDFOkZlXbo8SgLkfiklsYdA7RGT8cw18Gm5D0wPYtbiPLcVql7unvZvu0KjSTm2j6E Nhesei+nEw5it35lr8ohJqhnDGYXjhMXD0s4UBsnTEMH8IpizkOQpNgl7QKSfgJvZMul 98yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=k6IqphPd//RGHV6H30Pp9C6f+ZWxgl2LRQEHncHM2Xo=; b=zv+g1TXex+N2eHyFxcTlrcPJfz6WJQm3iLBBf2JrUsFctymsWve1LKX65U497nLszs JcCy26YkJypP9GxgUQVpFySDQ8CPCQb6nBfEZROaBYHiCqndsLw++wVP4uw3Ouh0bNGM N4GNuOX/7xhoNKyb9munqP873CHBkiS2QsTaC8ecyVsb8wcIYO4Tu4RKI7Al0HR5JiVx QWu/19/MzIVXvRUapfPZSHhHnXuSVTu7t2bAoGOj2r/6bgEvrUK6dwSI86x3281vFIm4 4qQVbG1gWrtq3kkbQKxWscwSVn7t+cJAQeywEXYqhFvz7Ja0N3XnTbbN1xY45Fd0urC1 AQtQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id e80si199065wmi.2.2017.11.21.11.33.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2017 11:33:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id vALJXq0Z001663 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 21 Nov 2017 20:33:54 +0100 Subject: Re: [PATCH 1/3] dpkg-base: Fix buildchroot dependency To: Henning Schild Cc: isar-users@googlegroups.com, Christian Storm References: <20171121184940.5425-1-asmirnov@ilbers.de> <20171121184940.5425-2-asmirnov@ilbers.de> <20171121201027.197aec5e@md1em3qc> From: Alexander Smirnov Message-ID: Date: Tue, 21 Nov 2017 22:33:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171121201027.197aec5e@md1em3qc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: kv/0s3XwAMYN On 11/21/2017 10:10 PM, Henning Schild wrote: > Am Tue, 21 Nov 2017 21:49:38 +0300 > schrieb Alexander Smirnov : > >> Existing code forces recipe to depends from 'do_build' task for all >> the items listed in DEPENDS, what actually makes no sense. This task >> only produces binary deb package and it can't satisfy any dependencies >> for another task. > > With DEPENDS you would also say that application1 that you build in > buildchroot needs lib1 and lib2 and buildtool3, and you have recipes > for all of those (they are not upstream debian). > Now requiring .debs makes some sense because now the "apt-get install > -y $DEPS" could actually install them in buildchroot. I do not think > that works at the moment, because the Isar repo is not in buildchroot > multistrap. > > Technically both versions are wrong, so applying that patch does not > seem to improve the situation. IMHO not so bad. Current usage of DEPENDS is invalid, so the patch drops this from Isar. I should come back with complete dependency implementation. Also I'd like to split deps from buildchroot and deps between packages. They are different. Also packages possibly will use different task to implement interpackages deps, for example: - buildchroot:do_build - package_X:do_populate_buildchroot So anyway it needs to explicitly set dependency from buildchroot:do_build. > > We need an example of two packages from Isar that actually DEPEND on That's true. Alex > each other in buildchroot. I think Christian has patches for that > problem. > > Henning > >> Original idea was to add dependency from 'buildchroot:do_build' task, >> so this patch fixes this. >> >> Signed-off-by: Alexander Smirnov >> --- >> meta/classes/dpkg-base.bbclass | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/meta/classes/dpkg-base.bbclass >> b/meta/classes/dpkg-base.bbclass index 35af6d5..4941f9b 100644 >> --- a/meta/classes/dpkg-base.bbclass >> +++ b/meta/classes/dpkg-base.bbclass >> @@ -2,8 +2,7 @@ >> # Copyright (C) 2017 Siemens AG >> >> # Add dependency from buildchroot creation >> -DEPENDS += "buildchroot" >> -do_build[deptask] = "do_build" >> +do_build[depends] = "buildchroot:do_build" >> >> # Each package should have its own unique build folder, so use >> # recipe name as identifier