From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7016230395466219520 X-Received: by 2002:a05:600c:4108:: with SMTP id j8mr13393815wmi.15.1634135365729; Wed, 13 Oct 2021 07:29:25 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:2983:: with SMTP id p125ls3294989wmp.2.canary-gmail; Wed, 13 Oct 2021 07:29:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFXBTYnrSSXWniTGjvlTYMBvkUCOWeKEA+jupLgd9E2/4lAkJp4fjePAzWPI9CttnmiYWh X-Received: by 2002:a1c:3847:: with SMTP id f68mr12899677wma.152.1634135364639; Wed, 13 Oct 2021 07:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634135364; cv=none; d=google.com; s=arc-20160816; b=mEY2f5tstgrI5e71xX7F610gPSuJr8zVG16HPn6e8tfcwPij2GOZt3h3oePc7wUBOi 4//FD9yLYgp4HdKSSJWVYc48skkcf2uXtTXvhjDoDMLd2ioueK/GP7IGIbD+f45yJqMJ qcVvJY3YX1mNqYpWW6G/44wU8ARqzzRm8QbI2mGa1MainFmHJC4tZML+OrzX8ls9T9oS agCSLdpfdrqvBE4SD/MlARGjHDMktCLJ41liwdbgx/mUddBWmaCZgiXHArprdR1IuoRk w4OjwkKBPx1Rj4oqn488UJIl2sUqp9g9x4i6nWmcX7NPr/rF/L2arFCl+E8NEWo08+N8 DkRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=qJo2DxeI3J8ugBEji/N+RaELV1ehTmFSDeLpC8NiZd0=; b=ALIXHSpTG45vdFiFjrQOoPnHihckajbYXBBAm0ecRasl/OYUqM4xnaHNrcRJEOu/l5 6QAJil/dgHg48s4L7G5UzalGkBo3IfMghAJIL2lPon2/eAS3Q6oYb2UtDPJIKQBYvvre COcBVk5v3wmKAND/8jBKlTctRW8ttas6cdGnEOjIzMsolWGAi5hG1F1m7ayfJST5Lm6k SpCcDnxWEEW5DqfeWEQXhC1n95khJH758TdRwQjSEaV5Gln1EAA8wEoxz5eu52ILJFm9 D64mC3taeAG2e4WcrFdcLhyujZ+r4azkJqXf/3z3sBwP6gdIjGn+jkUwVGrkpgZj+msF ECpA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id h11si530688wrs.3.2021.10.13.07.29.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Oct 2021 07:29:24 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 19DETOxK028398 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 13 Oct 2021 16:29:24 +0200 Received: from [167.87.2.42] ([167.87.2.42]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 19DETNm3015772; Wed, 13 Oct 2021 16:29:23 +0200 Subject: Re: [PATCH v2 03/10] rootfs: recursively depend on packages To: Adriaan Schmidt , isar-users@googlegroups.com References: <20211012123625.1703627-1-adriaan.schmidt@siemens.com> <20211012123625.1703627-4-adriaan.schmidt@siemens.com> From: Jan Kiszka Message-ID: Date: Wed, 13 Oct 2021 16:29:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211012123625.1703627-4-adriaan.schmidt@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: Wvt0dku4Qsnm On 12.10.21 14:36, Adriaan Schmidt wrote: > This fixes a bug. > So far, this only worked when the dependency-of-dependency packages > were in isar-apt because they were just built. This explicitly > enforces do_deploy_deb on *all* dependencies. More curiosity: I'm not yet understanding the error scenario. A rootfs depends on a package recipe A, and that means on the completion of that recipe's do_deploy_deb task. If that recipe A depends on another package recipe B that one needs to be in isar-apt, thus has to finish its do_deploy_deb as well. But why could A have finished its build when B didn't even run do_deploy_deb yet? If A depends on B, it also depends on B's do_deploy_deb task, no? Jan > > Signed-off-by: Adriaan Schmidt > --- > meta/classes/rootfs.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index f9151c5..bd8a241 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -152,7 +152,7 @@ rootfs_install_pkgs_install() { > do_rootfs_install[root_cleandirs] = "${ROOTFSDIR}" > do_rootfs_install[vardeps] += "${ROOTFS_CONFIGURE_COMMAND} ${ROOTFS_INSTALL_COMMAND}" > do_rootfs_install[depends] = "isar-bootstrap-${@'target' if d.getVar('ROOTFS_ARCH') == d.getVar('DISTRO_ARCH') else 'host'}:do_build" > -do_rootfs_install[deptask] = "do_deploy_deb" > +do_rootfs_install[recrdeptask] = "do_deploy_deb" > python do_rootfs_install() { > configure_cmds = (d.getVar("ROOTFS_CONFIGURE_COMMAND", True) or "").split() > install_cmds = (d.getVar("ROOTFS_INSTALL_COMMAND", True) or "").split() > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux