Re: [PATCH 1/1] refactor: drop useless sudo from do_generate_keyrings

["'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>]

On 18.02.26 10:18, 'Jan Kiszka' via isar-users wrote:
> On 18.02.26 09:30, 'Felix Moessbauer' via isar-users wrote:
>> This task does not execute sudo, so we don't need to set the
>> corresponding bitbake hint.
>>
> 
> You should also argue whether the does does no networking - because that
> is what <task>[network] = "${TASK_USE_SUDO}" means as well.
> 

...which it never did. The USE_SUDO actually dates back to "sudo apt-key
add", and that was changed via 9ae41e0325fd7ba64a0517c34976738d6c5bf81f.
Please clarify the history.

Jan

> Jan
> 
>> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
>> ---
>>  meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
>> index d5bbae70..9b4f62df 100644
>> --- a/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
>> +++ b/meta/recipes-core/isar-mmdebstrap/isar-mmdebstrap.inc
>> @@ -51,7 +51,6 @@ def get_apt_opts(d, param):
>>  do_generate_keyrings[cleandirs] = "${WORKDIR}/trusted.gpg.d"
>>  do_generate_keyrings[dirs] = "${DEBDIR}"
>>  do_generate_keyrings[vardeps] += "DISTRO_BOOTSTRAP_KEYS THIRD_PARTY_APT_KEYS"
>> -do_generate_keyrings[network] = "${TASK_USE_SUDO}"
>>  do_generate_keyrings() {
>>      export GNUPGHOME="$(mktemp -td gpghomeXXXXXXXXXX)"
>>      if [ -n "${@d.getVar("THIRD_PARTY_APT_KEYFILES") or ""}" ]; then
> 
> 

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/b5687cd5-a93d-401b-9093-913ce4c7c7ba%40siemens.com.