public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Uladzimir Bely <ubely@ilbers.de>
To: Cedric Hombourger <cedric.hombourger@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH] dpkg: use find to create symlinks to downloaded .deb files vs ln -sf wildcard
Date: Thu, 29 Feb 2024 16:17:09 +0300	[thread overview]
Message-ID: <b57ce14dd12c2dbf669f05aeb5ccf3cec6f5c606.camel@ilbers.de> (raw)
In-Reply-To: <20240226095517.66032-1-cedric.hombourger@siemens.com>

On Mon, 2024-02-26 at 10:55 +0100, 'Cedric Hombourger' via isar-users
wrote:
> If no .deb files were downloaded from remote feeds, use of "ln -sf
> *.deb" will
> create a dangling symlink named "*.deb" in the target directory and
> will be a
> broken link and make the cp command used in the finished-build-
> commands fail.
> Use "find <dir> -exec ln -t <target> -sf {} +" to create symlinks
> instead of
> "ln -sf wildcard". For consistency and optimization, the find command
> used to
> copy newly downloaded .deb files from the sbuild env back to the
> build env is
> also changed to use the "{} +" -exec flavor (instead of "{} ;" which
> spawns
> one cp command for each single match). The issue of a dangling
> symlink named
> "*.deb" was found while building against file:// sources and no
> remote feeds.
> 
> Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
> ---
>  meta/classes/dpkg.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied to next, thanks.

      parent reply	other threads:[~2024-02-29 13:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26  9:55 Cedric Hombourger
2024-02-26 10:08 ` cedric.hombourger
2024-02-27  9:10   ` Uladzimir Bely
2024-02-27  9:46     ` cedric.hombourger
2024-02-27 11:40       ` Uladzimir Bely
2024-02-28  9:09       ` Baurzhan Ismagulov
2024-02-29 13:17 ` Uladzimir Bely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b57ce14dd12c2dbf669f05aeb5ccf3cec6f5c606.camel@ilbers.de \
    --to=ubely@ilbers.de \
    --cc=cedric.hombourger@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox