From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7339847101007790080 X-Forwarded-Encrypted: i=2; AJvYcCVx7Lj/RUKxnsqI/MYO7gInern8TMLvdWpPnbvGswc86eGBn/lJveOVxHVAAss/FY8x4FpKSW/y8yQzyvWzSrG8TZCbhyQoBq+OHko= X-Received: by 2002:a19:7715:0:b0:513:1fe7:d450 with SMTP id s21-20020a197715000000b005131fe7d450mr1297313lfc.4.1709212634933; Thu, 29 Feb 2024 05:17:14 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:b87:b0:512:fc01:6e76 with SMTP id b7-20020a0565120b8700b00512fc016e76ls265617lfv.1.-pod-prod-05-eu; Thu, 29 Feb 2024 05:17:12 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUnnrxO4296uRPs/+XiC/3NKND+SdfhQOLFhLdGFzlLxInY/7YwPQnDdKu0u2T+F0LYRBAxUSXcSFzCnmRoHdtMzZsTSVLZBgC+SVQ= X-Google-Smtp-Source: AGHT+IHFdQ0NV9wXnXcJspvhno9iTWoQV1vILBh2dEKmoyWiuPMoWEIi6A3sBhMo8yXNUkqo+cpu X-Received: by 2002:a2e:91cd:0:b0:2d0:adde:cb6c with SMTP id u13-20020a2e91cd000000b002d0addecb6cmr1394824ljg.22.1709212632460; Thu, 29 Feb 2024 05:17:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1709212632; cv=none; d=google.com; s=arc-20160816; b=nLoOM+jidaZA0raM6p8gR8WAJ+VwYD/Ts88rVN5GQ7LiMsan3wW/z3hF9g/dvI7egd urPMkNvgnoTM+GfonYcUluzGBnkbIjV3/zWwbWvPK3GF4H2I2MYXRM7/EtgdpHBw6GXI 7xi453kunPox5a0fuCRNUD/uxCd+Hkv5pm/n/YOa4uxAxnI2pGiv4MwhZ7iAP3f2Huo1 DDHYicsdLJ6dGqeNSUTgKbKNU198Kt/NWPfJosgugVPfmyugXLSafYcqQwt20QI+WRih hcCv3AaNBARK3WAjkerjrj4Oczk1UleHYrJJDNJwVgMCce6L/pokakQDPRNQdoo76Bpp wJJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=tfRJ1N/Vr564iExxofF3Uv5JufzKjWDVlXwtb3p9r7Q=; fh=1x/T85rXr8yhgzXWAa7zssXnuyt2jGlhJYPIGFWr6UE=; b=vfQwYbu72v7rCuPr3NruznB/5dSATwF4lLTsSzqTXUC78z59Ic+6P9vErhfufNUJye r28RDNXf4Da7BRtDXsKOeiAJdnNa+i46czBEpwMdpLQZ+tXDzqXaM9/8j3XZXBHmFaOO tvlrhDMwpow5bI4HZB1AYyMATHcEG9vIHQqXJLnYKjfRbW7b/+hPPf9LB5kH73757FSc 8V7kk3vaCd/ylaJJJ46DUq8/fvABDjyllUEBenDYEeuuCxjpc7riIj0l2b/fhmJYi6UL 7fLC/RpsSAxf9HSvk9A4yl5+1h3uYv8usW1pirksCK59Q3nlnAFLXUoj7RP92B5oQyi6 DsBQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id s25-20020a2e81d9000000b002d2ddef9d5asi85042ljg.8.2024.02.29.05.17.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Feb 2024 05:17:12 -0800 (PST) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 41TDH9cx009962 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Feb 2024 14:17:11 +0100 Message-ID: Subject: Re: [PATCH] dpkg: use find to create symlinks to downloaded .deb files vs ln -sf wildcard From: Uladzimir Bely To: Cedric Hombourger , isar-users@googlegroups.com Date: Thu, 29 Feb 2024 16:17:09 +0300 In-Reply-To: <20240226095517.66032-1-cedric.hombourger@siemens.com> References: <20240226095517.66032-1-cedric.hombourger@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: r7HLgmYJjUN8 On Mon, 2024-02-26 at 10:55 +0100, 'Cedric Hombourger' via isar-users wrote: > If no .deb files were downloaded from remote feeds, use of "ln -sf > *.deb" will > create a dangling symlink named "*.deb" in the target directory and > will be a > broken link and make the cp command used in the finished-build- > commands fail. > Use "find -exec ln -t -sf {} +" to create symlinks > instead of > "ln -sf wildcard". For consistency and optimization, the find command > used to > copy newly downloaded .deb files from the sbuild env back to the > build env is > also changed to use the "{} +" -exec flavor (instead of "{} ;" which > spawns > one cp command for each single match). The issue of a dangling > symlink named > "*.deb" was found while building against file:// sources and no > remote feeds. >=20 > Signed-off-by: Cedric Hombourger > --- > =C2=A0meta/classes/dpkg.bbclass | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 Applied to next, thanks.