public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH] meta-isar: example-module: Fix ISAR_CROSS_COMPILE setting
Date: Mon, 12 Nov 2018 09:27:31 +0100	[thread overview]
Message-ID: <b5d638d5-84a1-40f7-3cfb-884753b413d2@web.de> (raw)

From: Jan Kiszka <jan.kiszka@siemens.com>

Make sure ISAR_CROSS_COMPILE is updated prior to inheriting buildchroot
indirectly via module.inc. Otherwise, setting it to 0 will come too
late.

Fixes: 301f52378052 ("meta-isar: example-module: Only disable cross-compilation for Debian kernels")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta-isar/recipes-kernel/example-module/example-module.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-isar/recipes-kernel/example-module/example-module.bb b/meta-isar/recipes-kernel/example-module/example-module.bb
index 996b5e2..b62ef65 100644
--- a/meta-isar/recipes-kernel/example-module/example-module.bb
+++ b/meta-isar/recipes-kernel/example-module/example-module.bb
@@ -5,8 +5,6 @@
 #
 # SPDX-License-Identifier: MIT
 
-include recipes-kernel/linux-module/module.inc
-
 # Cross-compilation is not supported for the default Debian kernels.
 # For example, package with kernel headers for ARM:
 #   linux-headers-armmp
@@ -17,6 +15,8 @@ python() {
         d.setVar('ISAR_CROSS_COMPILE', '0')
 }
 
+include recipes-kernel/linux-module/module.inc
+
 SRC_URI += "file://src"
 
 S = "${WORKDIR}/src"
-- 
2.16.4

             reply	other threads:[~2018-11-12  8:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  8:27 Jan Kiszka [this message]
2018-11-14  3:16 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5d638d5-84a1-40f7-3cfb-884753b413d2@web.de \
    --to=jan.kiszka@web.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox