Re: [PATCH 1/9] isar-bootstrap: Add routin to determine host arch

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-06-15 13:11, Alexander Smirnov wrote:
> Hi Henning,
> 
>> Am Wed, 13 Jun 2018 15:07:59 +0200
>> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
>>
>>> This method will be used to distinguish host and target bootstraps.
>>> The standard python platform module is not robust here, because it
>>> provides the architecture label from kernel. For example running
>>> platfotm.machine() on Fedora kernel will return 'x86_64', what is
>>> invalid specificator for Debian systems.
>>>
>>> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
>>> ---
>>>  meta/classes/isar-bootstrap-helper.bbclass | 9 +++++++++
>>>  1 file changed, 9 insertions(+)
>>>
>>> diff --git a/meta/classes/isar-bootstrap-helper.bbclass
>>> b/meta/classes/isar-bootstrap-helper.bbclass index 3c10fc7..2598ea3
>>> 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass
>>> +++ b/meta/classes/isar-bootstrap-helper.bbclass
>>> @@ -14,6 +14,15 @@ def reverse_bb_array(d, varname):
>>>      array = reversed(array.split())
>>>      return " ".join(i for i in array)
>>>  
>>> +python () {
>>> +    import subprocess
>>> +    host_arch = subprocess.Popen("/usr/bin/dpkg
>>> --print-architecture",
>>> +                                 shell=True,
>>> +                                 stdout=subprocess.PIPE
>>> +                                ).stdout.read().decode('utf-8').strip()
>>> +    d.setVar("HOST_ARCH", host_arch);
>>> +}
>>
>> Consider not using an absolute path. That defeats the magic of PATH.
> 
> I agree with you here, but btw, do you (or probably somebody else) know how to workaround this in
> python subprocess? An attempt to run just 'dpkg' fails with the error:
> command not found.

I think your invocation of Popen just misses to pass in the env. Check
other call sites for the right pattern.

Jan