Re: [PATCH] meta: Drop lazy and recursive unmounts

["'Florian Bezdeka' via isar-users" <isar-users@googlegroups.com>]

On Fri, 2024-09-06 at 17:34 +0300, Anton Mikanovich wrote:
> 29/08/2024 15:26, Florian Bezdeka wrote:
> > I think this is the relevant line from "mount":
> > 
> > tmpfs on /builds/<project>/build/tmp/work/debian-bookworm-amd64/sbuild-
> > chroot-target/1.0-r0/rootfs/dev type tmpfs
> > (rw,nosuid,size=65536k,mode=755,inode64)
> > 
> > Florian
> 
> So it is sbuild who should manage mount in this rootfs. Not sure how 
> this patch
> influence on internal sbuild mount/unmount logic. But sbuild shouldn't 
> left any
> mounts without any errors. Do you have any packages failed to be built?
> 
> Are there any lost schroot sessions running before external rm you have 
> issue
> with? This can be checked with 'schroot -la' command.

This one, right after the build completed, delivers:

W: No chroots are defined in ‘/etc/schroot/schroot.conf’ or
‘/etc/schroot/chroot.d’

> 
> You can also try to add some verbose to sbuild with following change:
> 
> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> index bcc3f828..b54e3ab9 100644
> --- a/meta/classes/dpkg.bbclass
> +++ b/meta/classes/dpkg.bbclass
> @@ -113,6 +113,8 @@ dpkg_runbuild() {
>       DSC_FILE=$(find ${WORKDIR} -maxdepth 1 -name 
> "${DEBIAN_SOURCE}_*.dsc" -print)
> 
>       sbuild -A -n -c ${SBUILD_CHROOT} \
> +        -D \
> +        --chroot-setup-commands="mount" \
>           --host=${PACKAGE_ARCH} --build=${BUILD_ARCH} ${profiles} \
>           --no-run-lintian --no-run-piuparts --no-run-autopkgtest 
> --resolve-alternatives \
>           --bd-uninstallable-explainer=apt \
> 
> This will be very helpfull to get some build logs from your setup.

I scanned the logs and searched for /dev mounts. Typical example:

tmp/work/debian-bookworm-amd64/isar-exclude-docs/0.2.2-r0/temp/log.do_dpkg_build.18089
521:devpts on /dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=666)
522:tmpfs on /dev/shm type tmpfs (rw,relatime,inode64)

At the end I still have one active /dev mount:
tmpfs on /builds/myproject/build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev type tmpfs (rw,nosuid,size=65536k,mode=755,inode64)

Trying to delete the sbuild-chroot-target delivers:

rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/shm': Device or resource busy
rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/termination-log': Device or resource busy
rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/mqueue': Device or resource busy
rm: cannot remove 'build/tmp/work/debian-bookworm-amd64/sbuild-chroot-target/1.0-r0/rootfs/dev/pts': Device or resource busy

mqueue and termination-log are host specific. That might be the reason
why I can only reproduce in CI setups. k8s has some "specials" like
termination-log here.

It seems that the mount comes from the rootfs_postprocess task of
sbuild-chroot-target. Which task should undo/clean them up?

Florian 

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/b631604383ed020ce51c0c3f75aa3693509c4293.camel%40siemens.com.