Re: [PATCH] meta: image: detect broken symlinks

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2018-02-27 18:23, [ext] Henning Schild wrote:
> Switch get_image_name from os.path.lexists to os.path.exists because the
> latter detects broken symlinks correctly.
> 
> Issue:
> If you build a kernel without CONFIG_BLK_DEV_INITRD the postinst hook will
> still call "linux-update-symlinks" and create a broken symlink. After
> that os.path.lexists will return True and "sudo cp" in do_copy_boot_files
> will fail.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  meta/classes/image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 2c255f4..46d3560 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -8,7 +8,7 @@ IMAGE_ROOTFS   = "${WORKDIR}/rootfs"
>  def get_image_name(d, name_link):
>      S = d.getVar("IMAGE_ROOTFS", True)
>      path_link = os.path.join(S, name_link)
> -    if os.path.lexists(path_link):
> +    if os.path.exists(path_link):
>          return os.path.basename(os.path.realpath(path_link))
>      return ""
>  

Makes sense. Wondering if the original commit didn't already want to do
this, just accidentally picked the wrong function.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux