From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6527286083495919616 X-Received: by 10.28.3.11 with SMTP id 11mr141496wmd.4.1519993227161; Fri, 02 Mar 2018 04:20:27 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.182.17 with SMTP id f17ls2762001wre.14.gmail; Fri, 02 Mar 2018 04:20:26 -0800 (PST) X-Google-Smtp-Source: AG47ELvwFKS1oHo6w5Z2iKCsmt/SLmuwPwWn3/DsuZp14UlqoT2cZYQsCd1luUmVG217Vq/EZBCS X-Received: by 10.223.185.72 with SMTP id b8mr549014wrg.3.1519993226518; Fri, 02 Mar 2018 04:20:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519993226; cv=none; d=google.com; s=arc-20160816; b=WLjHP4HF/6sIaheWuB5rS4h9OvPpipZw5wLwlhEEbYLPE9LPgQhBowre19vDtIMNun YHWssv+mLQ1S9O6u/o2sCbUNiAZuQCaMiv+dN5JsswdV99NK3Tthg7zJ2bWfnm6YJl/1 AyryHWoF5DYw67v1BizaRb+Prif2j+RUBOL/8Py1wU8HH+k+7lP5Obn69dT0VtN9mAnO bTjgFSWxicPRuXOKo+Y9e7ns+L0y4QY1MJHK1EEM2sC06LlB1xgH+n+VhFj89zL/P0fb 6HJcpIbZZhJijkSX2SjQHuCHRz8fYzMV72Ts3VzuH2pCFyz1F4IWWX4NCV/6rpJDN1LQ GS0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=k3xurYEYE66SUxpsdEuTSBTrwYfJHHeBRTmq9thQYUY=; b=WbQMp/ha6+IuTd3SOTq3OWcOUgInfiLP2jL8Pp6PFyHjyIKcJf/jla0you4ozoO6LG pDHsrfni26dS0KILwVWZYLjLIvEYTQZK8dxVQnZvqk03URyS/HabML1g5x1LPn5nc2p7 vOal/PDDUNtyvwZhK87fEqGFID77E/6f7wCrhIxSGzixR+yK5ptoZ0hBLqt+O0p+rhxf 0LNkq7mwBCZNaR3fZKSsgNgP2H/a14l1+Jjybzy+6KbvOvhwi7B4kmNPeUOBH1FpunMs Exs8aZdLoq4ZG2Lj1YpJlXi9S6dRC4KaUotR81xKBw2xvJJdCU9d37q9yZNci7lTSMnh s+nw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id a72si37643wme.1.2018.03.02.04.20.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Mar 2018 04:20:26 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w22CKQQS000841 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 2 Mar 2018 13:20:26 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w22CKPJs024465; Fri, 2 Mar 2018 13:20:25 +0100 Subject: Re: [PATCH] meta: image: detect broken symlinks To: "[ext] Henning Schild" , isar-users@googlegroups.com References: <20180227172336.19786-1-henning.schild@siemens.com> From: Jan Kiszka Message-ID: Date: Fri, 2 Mar 2018 13:20:25 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180227172336.19786-1-henning.schild@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 8pLoDNgB/rp7 On 2018-02-27 18:23, [ext] Henning Schild wrote: > Switch get_image_name from os.path.lexists to os.path.exists because the > latter detects broken symlinks correctly. > > Issue: > If you build a kernel without CONFIG_BLK_DEV_INITRD the postinst hook will > still call "linux-update-symlinks" and create a broken symlink. After > that os.path.lexists will return True and "sudo cp" in do_copy_boot_files > will fail. > > Signed-off-by: Henning Schild > --- > meta/classes/image.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 2c255f4..46d3560 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -8,7 +8,7 @@ IMAGE_ROOTFS = "${WORKDIR}/rootfs" > def get_image_name(d, name_link): > S = d.getVar("IMAGE_ROOTFS", True) > path_link = os.path.join(S, name_link) > - if os.path.lexists(path_link): > + if os.path.exists(path_link): > return os.path.basename(os.path.realpath(path_link)) > return "" > Makes sense. Wondering if the original commit didn't already want to do this, just accidentally picked the wrong function. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux