From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6924962081797046272 X-Received: by 2002:a05:6512:2251:: with SMTP id i17mr1220055lfu.566.1612345418747; Wed, 03 Feb 2021 01:43:38 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4adc:: with SMTP id m28ls1091541lfp.0.gmail; Wed, 03 Feb 2021 01:43:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwi0WpBmePgL3O3klan4ORQ54g0YXoF09LjMx6823oMjVxTVtjCt7CabagYwGOLqMDb0fHn X-Received: by 2002:ac2:5331:: with SMTP id f17mr1219472lfh.21.1612345417578; Wed, 03 Feb 2021 01:43:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612345417; cv=none; d=google.com; s=arc-20160816; b=L1VpONs7qRH6ly4ygKd+N3LTKzGnb/Bg1VwXpjAbZiYTidxPf0adEo0ttBroDfOoou hVz/j8RrUs51kZXoTkj1Wr6rVhcrwtJ1H/CJQQSSEu56uuIXym20p7rNFEuM636w8+T4 3BpIMV/8nlmC8FrIzFA83qBRYWmeQM/1UunulxqY9E384nKmfyIX27z/DZqAuowQN+eo wv0l0P3XDfeBt5d7ra34HtRg4jrPFaWBXclmZ3VKk54o/pd6rMs89ZV2IMjeBrXrAiDs kBnLGA9+oxubWNhZBQI9gn5QPw2onjH05/mW2sCyffwa5gpe5U/GM2dAdsPHjbzipdXl Xtiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=AX4jA2TVKIQJU3DTgJZ9riJh9gOF1fWDKUyDNbPwtcc=; b=z5N/zrwE9TIa2geZA8NESo7Usge76G+J6FEAV/fEdzGm75bZ1auGgZbAmIex1qEV2A 8zARwrFXdOeJhY3kC+kHcxH7YYbCuG/umgRSC4726uzmrK9pE0wd2Ug0JYQE/SQL1mdw afLIt2dae1QQicV/2N0gdOEVShEt0h+W2t6jkmZJgc1k6si6xseAYNG36W5Sm9vCJ+xU vy9rvoD6WkF6s9Nfd4NqIAgV/Qo2xPvHH8w+35dfEUmjQYHqxJ/gb5/e4xHu9kj+bgHW ValRkmzFqI4D6lc+truXMHDdm9OErS2HeCF9U3zHeEfoTHLP4fLD8V2fHIyjupaoqw8f hCaw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id u7si64096lfg.2.2021.02.03.01.43.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Feb 2021 01:43:37 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 1139hat9004925 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 3 Feb 2021 10:43:36 +0100 Received: from [167.87.20.189] ([167.87.20.189]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 1139haBq021181; Wed, 3 Feb 2021 10:43:36 +0100 Subject: Re: [PATCH] meta/conf/distro: Fix filling of DISTRO_APT_SOURCES with default sources To: "Bezdeka, Florian (T RDA IOT SES-DE)" , "isar-users@googlegroups.com" References: <20210203090927.97067-1-florian.bezdeka@siemens.com> From: Jan Kiszka Message-ID: Date: Wed, 3 Feb 2021 10:43:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210203090927.97067-1-florian.bezdeka@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 4aiRWGEWhW2S On 03.02.21 10:09, Bezdeka, Florian (T RDA IOT SES-DE) wrote: > From: Florian Bezdeka > > The following (quite minimal) distribution inheritance did not work: > > own-distro.conf: > require conf/distro/debian-buster.conf > > Build result (error): > E: option suite may not be empty > > The reason for the build failure was that own-distro did not have any APT > sources configured. This was broken with f3b4f74a869a. ${DISTRO} is set > to "own-distro" in this case and the apt source file (${DISTRO}.list) > might not exist. > > Fixes: f3b4f74a869a ("meta/conf/distro: Cleanup DISTRO_APT_SOURCES") > Signed-off-by: Florian Bezdeka > --- > meta/conf/distro/debian-common.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/conf/distro/debian-common.conf b/meta/conf/distro/debian-common.conf > index cb7f8ed..aa32b24 100644 > --- a/meta/conf/distro/debian-common.conf > +++ b/meta/conf/distro/debian-common.conf > @@ -6,7 +6,7 @@ > BASE_DISTRO = "debian" > > HOST_DISTRO_APT_SOURCES ?= "conf/distro/${HOST_DISTRO}.list" > -DISTRO_APT_SOURCES ?= "conf/distro/${DISTRO}.list" > +DISTRO_APT_SOURCES ?= "conf/distro/${HOST_DISTRO}.list" > This isn't correct. DISTRO_APT_SOURCES points to the target distro, HOST_DISTRO_APT_SOURCES to the host distro. If we want to ease defining deviating distros under own names that can easily include debian-xxx.conf, we need to revert that cleanup commit, hard-coding the association between distro conf an chosen list files again. Jan > WIC_IMAGER_INSTALL = "parted \ > gdisk \ > -- > 2.29.2 > -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux