From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6491554293275951104 X-Received: by 10.80.242.138 with SMTP id f10mr677455edm.11.1513022211549; Mon, 11 Dec 2017 11:56:51 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.159.161 with SMTP id c30ls3859410edf.1.gmail; Mon, 11 Dec 2017 11:56:51 -0800 (PST) X-Google-Smtp-Source: ACJfBosu5PDNSg0pihZn2e8zdQB2xqwZVzPSKKsFagqKT9VHHbrl3R6lv8LZBBgTWAfKYbkTJZu8 X-Received: by 10.80.242.138 with SMTP id f10mr677453edm.11.1513022211173; Mon, 11 Dec 2017 11:56:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513022211; cv=none; d=google.com; s=arc-20160816; b=Ho+9jgBM8E6uhzN26lDO/ypqr6jBD5ZZDSwiYlm4RQVffcvca5xke4Oyjs73/7fMjN vw9nhwO2qW12b5vdRfQpyp7aGp+Eh7Rvy4H9Z7LLmvEvzmvRPZe+A1p1SHV5t8cBzE7r rLAU+Enr+e0N14V6THAYpQHvl7LT+nAWFgqSJKikUnDdFpGYnmhTFGaNi2L4jVPyTbpV mKlnYK4usxnlsEO5I0MsVrm1T6MvuC6z7PPPXUQrAFxmeLgkzu+Yf2U5pbhpN6mUOPUn rHPCLUT0ksprn0l93pbqZUbBGzRls9qR4Mv+OUxMphkyQgSC77cge/BMiTORxaNvU8Yh YY9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=xqTCB8bjE1pmKYSHJXL8fRyaFP/tIseug+xuzjFfMLo=; b=GiYnCwzzrtyRSvntNlMU5ssIU6Fjtv3R+l0fleIDU9oUcGetlfBRsQRj8lUhCcSS3L dhpOqsF9M+Qjm7YTIN5pBK7zdnUHsze6DCOzH8JJWEayvl+icbTaJ4DlR+F3A9kN7wnL paHmUxPdn+g/BA0Xy/hxGd6ID6TNVFrQFFjCSsHD8ePqW11S2DDJaB5O/QN7TXU4iJG8 tWmJu4yHecAAscH0fQkx+YEYneNff9Knj8m791c3WUA8Hsxm6OZ1zUTRqzyv94jnd1D2 gXxRCSdZL8BU7fSiWzCK8LwpD8LwI8z4OJF4nJ21Te2vDi8fH2xUhq8QpYu+vDd5y+7z 5PGA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id h45si1460254eda.2.2017.12.11.11.56.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2017 11:56:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id vBBJumaN025292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 11 Dec 2017 20:56:50 +0100 Subject: Re: [PATCH 3/4 v2] buildchroot: Add prepare and cleanup tasks To: Henning Schild Cc: isar-users@googlegroups.com References: <20171123102532.26274-1-asmirnov@ilbers.de> <20171123102532.26274-4-asmirnov@ilbers.de> <20171211192958.79ff98e6@md1pvb1c> From: Alexander Smirnov Message-ID: Date: Mon, 11 Dec 2017 22:56:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171211192958.79ff98e6@md1pvb1c> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: VXNcyvyPtWtI Hi, On 12/11/2017 09:29 PM, Henning Schild wrote: > Just found another issue with this one. Building something on current > next. > >>> ERROR: Nothing PROVIDES '${IMAGE_INSTALL}' (but >>> multiconfig:qemuamd64-stretch:/builder/isar/meta/recipes-devtools/buildchroot/buildchroot.bb >>> DEPENDS on or otherwise requires it) > > a 'IMAGE_INSTALL ?= ""' fixes that. > Thanks for this catch. It would be helpful if you describe your changes from upstream Isar that leads to this issue. Am I right, that you do not set IMAGE_INSTALL variable in local.conf file? Also an ideas how to handle such cases in pure Isar are welcome. Alex > Henning > > Am Thu, 23 Nov 2017 13:25:31 +0300 > schrieb Alexander Smirnov : > >> Some packages could require builchroot filesystem tunning, for >> example share Isar downloads folder with chroot filesystem. >> >> This patch adds two tasks for buildchroot: >> >> 1. 'do_prepare': This task is executed after buildchroot rootfs >> generation and before 'do_build' from packages to be built. >> Some notes: >> - An individual task is required for the case when you want to >> rebuild some package, this would require to run this preparation >> stuff for existing buildchroot rootfs. >> - This task should not have stamp. This means that anytime you want >> to build something, 'do_prepare' should be executed. >> >> 2. 'do_cleanup': This task is executed after all the packages are >> deployed. Some notes: >> - This task also should not have stamp. >> - This task depends from the recipes listed in IMAGE_INSTALL. >> >> Signed-off-by: Alexander Smirnov >> --- >> meta/classes/dpkg-base.bbclass | 2 +- >> meta/classes/image.bbclass | 1 + >> meta/recipes-devtools/buildchroot/buildchroot.bb | 21 >> +++++++++++++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) >> >> diff --git a/meta/classes/dpkg-base.bbclass >> b/meta/classes/dpkg-base.bbclass index 4941f9b..21ae88d 100644 >> --- a/meta/classes/dpkg-base.bbclass >> +++ b/meta/classes/dpkg-base.bbclass >> @@ -2,7 +2,7 @@ >> # Copyright (C) 2017 Siemens AG >> >> # Add dependency from buildchroot creation >> -do_build[depends] = "buildchroot:do_build" >> +do_build[depends] = "buildchroot:do_prepare" >> >> # Each package should have its own unique build folder, so use >> # recipe name as identifier >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index 7813b16..b0f645c 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -83,6 +83,7 @@ do_populate() { >> >> addtask populate before do_build after do_unpack >> do_populate[deptask] = "do_deploy_deb" >> +do_populate[depends] = "buildchroot:do_cleanup" >> >> do_rootfs[stamp-extra-info] = "${MACHINE}-${DISTRO}" >> >> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb >> b/meta/recipes-devtools/buildchroot/buildchroot.bb index >> 6a94733..fe88e98 100644 --- >> a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ >> b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -67,7 +67,28 @@ >> do_build() { # Install package builder script >> sudo install -m 755 ${WORKDIR}/build.sh ${BUILDCHROOT_DIR} >> >> + # Create share point for downloads >> + sudo install -d ${BUILDCHROOT_DIR}/git >> + >> # Configure root filesystem >> sudo chroot ${BUILDCHROOT_DIR} /configscript.sh >> _do_build_cleanup >> } >> + >> +do_prepare[nostamp] = "1" >> + >> +do_prepare() { >> + sudo mount --bind ${GITDIR} ${BUILDCHROOT_DIR}/git >> +} >> + >> +addtask prepare after do_build >> + >> +DEPENDS += "${IMAGE_INSTALL}" >> +do_cleanup[deptask] = "do_deploy_deb" >> +do_cleanup[nostamp] = "1" >> + >> +do_cleanup() { >> + sudo umount ${BUILDCHROOT_DIR}/git >> +} >> + >> +addtask cleanup after do_prepare > -- With best regards, Alexander Smirnov ilbers GmbH Baierbrunner Str. 28c D-81379 Munich +49 (89) 122 67 24-0 http://ilbers.de/ Commercial register Munich, HRB 214197 General manager: Baurzhan Ismagulov