From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6724322178273116160 X-Received: by 2002:a2e:12c8:: with SMTP id 69mr20693868ljs.189.1565684255699; Tue, 13 Aug 2019 01:17:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9dc8:: with SMTP id x8ls12053976ljj.2.gmail; Tue, 13 Aug 2019 01:17:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6C60qPh9kDz9R7AM+QrqCi8qrbeCAFkYB7VcKs8XnqfMiHCXxC3fu2/82LSkQscYlRiO1 X-Received: by 2002:a05:651c:ca:: with SMTP id 10mr4813206ljr.144.1565684255163; Tue, 13 Aug 2019 01:17:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565684255; cv=none; d=google.com; s=arc-20160816; b=DbCF5CNb7YaIiPFqW4R8MQ83YjzOYdtqwR12stbfOZC61Ji+/aqpVhAvEk0gqaUgna +HbRk02rn4SSJpfT66HskHlljN4AVaV7kFmgDI0CSBbwZZcFr7hHbPgagyBLw919j3YE aHUwX1omfyNUQ5acZdr/VW4/MgvLUUu5Lit5RIDXxksRQ2Um8nDHiEp2211HODqjgAEZ zLsKkuWxpGd9LqiQWXvz7FkoXq3z3bX6M7MIFDISBcxoy5Ja7rxalN44SQOTHYaViTcs 7b5QLAqrCpPLi6EpdSPp2eT+0w783DMIaL+S09rhjcqU8DWCujGECLR0/lSuzvcPU6Bi A1ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=Mz0TO25TNTbtqv85W2XpmnpSyICHvWwdjKj1+N19sfY=; b=M0rF7tI9nXORN3XLK5fWWJomrdIrEmhNGk25O/qBHs6P/Y9Pwb5AtoSPwtyXP9CgKn hBFom6sJrhVfev9rXZ890dp1hn2ITzPhXC2Sxvg7GW7awUD8vEgIJYi/DBEqUrlU82lw 83MMYPVCYu+HmeOERRqSkyoavnaVYJdEG84JCP5olL4MjbmU6ETqdu9umWwWO8y9EYJl 3Io8Ltd51IOtsmcIsgsBreru1hEranFkxPCK2iFNJHzhM1TYDJjxMLs9T/HDB9VvuD/E J/tKp0Y6nx5MVD6ByidNFo42nF73o92he0ipNHBvLzDwqUfpNeq+CKqgdwBlh1U1wnqG DQWA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id q11si5621724ljg.2.2019.08.13.01.17.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 01:17:35 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x7D8HX5g019179 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Aug 2019 10:17:34 +0200 Received: from [139.25.69.208] (linux-ses-ext02.ppmd.siemens.net [139.25.69.208]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7D8HXAv020073; Tue, 13 Aug 2019 10:17:33 +0200 Subject: Re: [PATCH v2] Set STAMPCLEAN variable To: Jan Kiszka , isar-users Cc: Claudius Heine References: <4b5f25df-8a9d-fa99-59e0-1a2730f12654@siemens.com> <81fcc2f2-341e-4730-abeb-58b4d8bc06de@siemens.com> From: Claudius Heine Message-ID: Date: Tue, 13 Aug 2019 10:17:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: Ru/0GVpdeb5N On 13/08/2019 10.01, Jan Kiszka wrote: > On 13.08.19 09:27, Claudius Heine wrote: >> Hi Jan, >> >> On 12/08/2019 19.15, [ext] Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> This ensures that stamp files are cleaned when a task is rebuilt. Not >>> providing this pattern likely caused a lot of failures when doing >>> partial rebuilds. >>> >>> As we are at it, switch do_clean to STAMPCLEAN as well. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>>   meta/classes/base.bbclass | 4 ++-- >>>   meta/conf/bitbake.conf    | 1 + >>>   2 files changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >>> index ca80bf8..b6638ca 100644 >>> --- a/meta/classes/base.bbclass >>> +++ b/meta/classes/base.bbclass >>> @@ -206,8 +206,8 @@ python do_clean() { >>>       workdir = d.expand("${WORKDIR}") >>>       subprocess.check_call(["sudo", "rm", "-rf", workdir]) >>> -    stamppath = bb.data.expand(d.getVar('STAMP', False), d) >>> -    stampdirs = glob.glob(stamppath + ".*") >>> +    stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d) >>> +    stampdirs = glob.glob(stampclean) >>>       subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs) >>>   } >>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >>> index 3d18223..003fb01 100644 >>> --- a/meta/conf/bitbake.conf >>> +++ b/meta/conf/bitbake.conf >>> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}" >>>   AUTOREV = "${@bb.fetch2.get_autorev(d)}" >>>   SRC_URI = "file://${FILE}" >>>   STAMP = "${TMPDIR}/stamps/${PF}" >>> +STAMPCLEAN = "${STAMP}*" >> >> I would rather go with "${TMPDIR}/stamps/${PN}-*". >> >> OE/YP remove the stamps of other recipe versions as well. >> >> This is what OE/YP does: >> >>    STAMPS_DIR ?= "${TMPDIR}/stamps" >>    STAMP = >> "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/${EXTENDPE}${PV}-${PR}" >>    STAMPCLEAN = "${STAMPS_DIR}/${MULTIMACH_TARGET_SYS}/${PN}/*-*" > > What would be the scenario where this helps? Just trying to understand. Good question, that I don't have an answer for. I looked at the commit messages, but it seems to be that this part of the STAMPCLEAN variable goes back to the first commit that introduced it. It is probably just a general philosophy, should different versions of the same recipe invalidate the stamps of each other or not. regards, Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de