RE: [PATCH v3 2/2] isar-image: refactor do_rootfs()

["Hombourger, Cedric" <Cedric_Hombourger@mentor.com>]

Hi Jan,

> Why making this a python function?

To align with Yocto and ease extension of do_rootfs should we need to (we probably want to have some guidelines for public APIs and one of them should be: make them Python functions because it allows children classes to use the full Python paradigm instead of the somewhat limited shell environment)

> What is the reasoning for the chosen split-up? 

If you are referring to the split of do_rootfs() into smaller functions, the primary objective was the reduction of the function complexity. Another candidate for such refactoring is IMO setup_root_file_system(): it's a function doing dozens of little things. It also allows classes inheriting from isar-image to hook themselves at specific points in the do_rootfs flow instead of being limited to pre-processing and post-processing extension points (do_rootfs_prepend / do_rootfs_append).

> These are all recipe APIs, so we must be more careful with such declarations.

You are right. If isar-image-base was viewed as an API, we probably want to highlight the change in the ChangeLog. I can do that.

Cedric