From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6522397978051739648 X-Received: by 10.25.152.80 with SMTP id a77mr175959lfe.2.1518700832628; Thu, 15 Feb 2018 05:20:32 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.25.210.77 with SMTP id j74ls892909lfg.4.gmail; Thu, 15 Feb 2018 05:20:32 -0800 (PST) X-Google-Smtp-Source: AH8x227ixV+xY/4IvTrLTmxwC/KD/gUc39muAvryBF0a/WWVeRwDqcFpUtGYGdg7Ab5cwtzUPjuD X-Received: by 10.25.26.66 with SMTP id a63mr173953lfa.19.1518700832075; Thu, 15 Feb 2018 05:20:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518700832; cv=none; d=google.com; s=arc-20160816; b=zlt2CsONKDHVQJUMCD/kERoDL8JGUwNCWy9eGLkeLpq/DVDFPHYU7xpTCBLAsO+QW8 0UIf7hk+8YrQoRO8Y0RZqkVgLZvdwRx8fMo1FMmNlhOc8XOwOU2mvjOCkOsYu4rdVXMl Vu49UcBH+yPGV/Qspeq0hsaw6a5o5AGRGW38gclD8YYJp2x1EWsQ+XsfG1RIQXT9wfUP 2nOiLN1aJjgoEaZjFC2VpJmw6x3H9l1e36LOUP1Rh1jAlN99DgK0Y42q5fAVd6jIMHrM +TuqClaKr3+afYAqCwRnV1JQFouQU8o7VAh0XkTM2eNwFdCeEfDie/KfAnODO57NWray s5pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=ngYafzU2N5jG6RLBHvlNvn0uRlYWedioLxFGX48pVaw=; b=Dwf74WtlYUxfb/ACwu3WRzT5TWQMoBizREIMFZ81+dOpzRwAIC+zl74fzpuC5w4Luo ZJMDk/8FRlG9zXr5e3+x7vgFyCdHuvXVckF41BIT0nshBFyCVBghgv1wTCTWDm+y8Glq yOAolB4geleI8ksILo7MpqgUQY9cM6ZxwSryZhvVVD3LvWdYBAPuFq76NqOBrhU0e8tw nkghPQ34IfZmx2JPOFZ4qCSE6gfyhEi0IHj8o17cdxCo3YIbwnZrWrw74JLWmwt21KLd meQKW7VlGah+PywrPp4g+k9LdDOawm4yhFiDlLdliVtzIiABjDAPwincAVvV99OdxVGJ RCJw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id w20si794933ljd.2.2018.02.15.05.20.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 05:20:31 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w1FDKUxK004949 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2018 14:20:31 +0100 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w1FDKUOT002559; Thu, 15 Feb 2018 14:20:30 +0100 Subject: Re: [PATCH 2/2] centralize multistrap configuration generation To: Alexander Smirnov , isar-users@googlegroups.com, Baurzhan Ismagulov References: <20180214131509.16361-1-claudius.heine.ext@siemens.com> <20180214131509.16361-3-claudius.heine.ext@siemens.com> <20180215114214.GC5374@yssyq.radix50.net> <1619976eb38.27ac.034a6b0541ed39b7fb4e17f4ac219eaa@ilbers.de> From: Claudius Heine Message-ID: Date: Thu, 15 Feb 2018 14:20:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1619976eb38.27ac.034a6b0541ed39b7fb4e17f4ac219eaa@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: ej7uYn8mUp9J On 02/15/2018 01:37 PM, Alexander Smirnov wrote: > > Claudius Heine 15 февраля 2018 г. > 15:08:50 написал: > >> Hi Baurzhan, >> >> On 02/15/2018 12:42 PM, Baurzhan Ismagulov wrote: >>> On Wed, Feb 14, 2018 at 02:15:09PM +0100, >>> claudius.heine.ext@siemens.com wrote: >>>> From: Claudius Heine >>>> >>>> Previous there was redundant code between the buildchroot and >>>> isar-image-base recipe. >>>> >>>> This patch moves the generation of the multistrap configuration to a >>>> central python script that can be parametrized by both recipes. >>>> >>>> Signed-off-by: Claudius Heine >>>> --- >>>>   .../recipes-core/images/files/multistrap.conf.in   | 38 ---------- >>>>   meta/lib/isar/multistrap.py                        | 80 >>>> ++++++++++++++++++++++ >>>>   .../buildchroot/files/multistrap.conf.in           | 37 ---------- >>> >>> Could you please post two final multistrap.confs you'd like to get >>> with your >>> changes? >> >> 'like to get'? I don't want to get any other multistrap.conf than >> before. This is not a change of the multistrap.conf files, but just how >> they are generated. The python configparser created ini-file format only >> puts spaces around the '=' characters, but the resulting deserialized >> objects is the same. > > The difference that I see IMHO: now you need to feed multistrap by > community-standardized input, you propose to add custom tool that eats > proprietary input. I don't get this point. What do you mean by that? > >> >> Ok, that is not 100% true, I changed the name of the isar repository >> section. Now its called 'isar' in the image (previously 'Isar') and >> buildchroot (previously 'isar-apt') multiconfig. But that is it. It has >> no different effect outside of multistrap. >> >>> I'd like to understand the reasons for moving from templates to a magic >>> generator. >>> >>> In my experience, magic is usually poorly documented (if at all) and >>> very >>> ununderstandable for users. Simple change of a line requires locating >>> the >>> generator, understanding what it does (they tend to be hairy with >>> tons of >>> conditions) and patching the upstream [Isar] code. Templates have their >>> disadvantages, but are straightforward for users. In general, I'd >>> like to keep >>> the current UX and stick with templates, which is possible most of >>> the time. >> >> You prefer duplicated code? Two slightly different templates for two >> buildchroot and image recipe? >> > > AFAIK the key idea is to have the only single multistrap that works with > upstream repos. Other multistraps fetch packages from local cache. So > after this is done, the problem with duplicacations in configs will go. > >> Also this patch is only an intermediate step of the way for multi-repo >> support. IMO it has value on its own, since it centralized the >> generation of the multistrap configuration. >> The current kind of 'template' does not support creating repository >> entries on the fly. > > What is the use case to have them "on the fly"? See: Also this patch is only an intermediate step of the way for multi-repo support. Use-case for multi-repo: docker-ce repository available. > > Alex > > It might be possible to extent the multiconfig with >> shell scripting, but I prefer using python for such advanced logic. > > I don't care about python or bash At least Baurzhan seems to care, because he doesn't like debootstrap because of it being in shell. Cheers, Claudius > >> >> regards, >> Claudius >> >> -- >> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de >> >> -- >> You received this message because you are subscribed to the Google >> Groups "isar-users" group. >> To unsubscribe from this group and stop receiving emails from it, send >> an email to isar-users+unsubscribe@googlegroups.com. >> To post to this group, send email to isar-users@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/isar-users/d58343b9-c284-81e7-f743-2672c1f5f8ef%40siemens.com. >> >> For more options, visit https://groups.google.com/d/optout. > > > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de