Re: [PATCH] classes/sdk.bbclass: remove additional "/" in new_target finding

[Jan Kiszka <jan.kiszka@siemens.com>]

On 28.06.23 07:19, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> We observed that one additional / present in finding the new_target,
> here target already start with /, hence no need to append the additional
> /.
> 
> In functionality wise there is no change.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/classes/sdk.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/sdk.bbclass b/meta/classes/sdk.bbclass
> index c6dc689..f14b447 100644
> --- a/meta/classes/sdk.bbclass
> +++ b/meta/classes/sdk.bbclass
> @@ -100,7 +100,7 @@ sdkchroot_finalize() {
>  
>          if [ "${target#/}" != "${target}" ]; then
>              basedir=$(dirname $link)
> -            new_target=$(realpath --no-symlinks -m --relative-to=$basedir ${ROOTFSDIR}/${target})
> +            new_target=$(realpath --no-symlinks -m --relative-to=$basedir ${ROOTFSDIR}${target})
>  

Can you guarantee that ROOTFSDIR comes with a trailing / in ALL case?
I'm skeptical about that.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux