From: "'Jan Kiszka' via isar-users" <isar-users@googlegroups.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>,
isar-users@googlegroups.com
Cc: cedric.hombourger@siemens.com
Subject: Re: [RFC 1/1] speedup localepurge task by emulating less
Date: Thu, 21 Aug 2025 17:24:41 +0200 [thread overview]
Message-ID: <b8e4485d-9f36-4b3e-9566-b2d7685ee5d7@siemens.com> (raw)
In-Reply-To: <20250821144519.298099-1-felix.moessbauer@siemens.com>
On 21.08.25 16:45, Felix Moessbauer wrote:
> The download and dpkg status tasks do not need to be emulated, as these
> properly support running without a chroot and for a foreign architecture.
>
> The install task itself does support running without a chroot, however
> not for a foreign architecture. By that, we keep the emulation of the
> install task for now.
Can we always parse with older dpkg newer installations? Or does this
silently assume that builder-release == target-release then?
To avoid emulation, I would use the dpkg from the host-chroot instead.
Jan
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
> meta/classes/image-locales-extension.bbclass | 8 +++++---
> meta/classes/rootfs.bbclass | 1 +
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/image-locales-extension.bbclass b/meta/classes/image-locales-extension.bbclass
> index 9149d643..787719cd 100644
> --- a/meta/classes/image-locales-extension.bbclass
> +++ b/meta/classes/image-locales-extension.bbclass
> @@ -29,8 +29,10 @@ ROOTFS_INSTALL_COMMAND_BEFORE_EXPORT += "image_install_localepurge_download"
> image_install_localepurge_download[weight] = "40"
> image_install_localepurge_download[network] = "${TASK_USE_NETWORK_AND_SUDO}"
> image_install_localepurge_download() {
> - sudo -E chroot '${ROOTFSDIR}' \
> - /usr/bin/apt-get ${ROOTFS_APT_ARGS} --download-only localepurge
> + sudo -E apt-get \
> + ${ROOTFS_APT_ARGS} \
> + ${NO_CHROOT_APT_ARGS} \
> + --download-only localepurge
> }
>
> ROOTFS_INSTALL_COMMAND += "image_install_localepurge_install"
> @@ -63,7 +65,7 @@ __EOF__
> sudo -E -s <<'EOSUDO'
> set -e
> localepurge_state='i'
> - if chroot '${ROOTFSDIR}' dpkg -s localepurge 2>/dev/null >&2
> + if dpkg --root '${ROOTFSDIR}' -s localepurge 2>/dev/null >&2
> then
> echo 'localepurge was installed (leaving it installed later)'
> else
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index 4de684a4..1098a100 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -20,6 +20,7 @@ ROOTFS_BASE_DISTRO ?= "${BASE_DISTRO}"
> ROOTFS_FEATURES ?= ""
>
> ROOTFS_APT_ARGS="install --yes -o Debug::pkgProblemResolver=yes"
> +NO_CHROOT_APT_ARGS ?= "-o APT::Architecture=${DISTRO_ARCH} -o Dir=${ROOTFSDIR}"
>
> ROOTFS_CLEAN_FILES="/etc/hostname /etc/resolv.conf"
>
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/b8e4485d-9f36-4b3e-9566-b2d7685ee5d7%40siemens.com.
prev parent reply other threads:[~2025-08-21 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 14:45 'Felix Moessbauer' via isar-users
2025-08-21 15:24 ` 'Jan Kiszka' via isar-users [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8e4485d-9f36-4b3e-9566-b2d7685ee5d7@siemens.com \
--to=isar-users@googlegroups.com \
--cc=cedric.hombourger@siemens.com \
--cc=felix.moessbauer@siemens.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox