From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 24 Oct 2024 12:41:24 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wm1-f62.google.com (mail-wm1-f62.google.com [209.85.128.62]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 49OAfBUv017925 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 24 Oct 2024 12:41:16 +0200 Received: by mail-wm1-f62.google.com with SMTP id 5b1f17b1804b1-4315e8e9b1csf4222575e9.1 for ; Thu, 24 Oct 2024 03:41:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1729766466; cv=pass; d=google.com; s=arc-20240605; b=g5/iXkA1oduvfcnsJcU19Qm1jPe6RWEdPbv9YiacRUGLZSypr4v6sGgWVwWiOlQqMI OL16+HpU5Dx6PvzTVL6IiJnEtjR44ZuPytw+fNx/FHnXLGcZy2MBJobh/h1zvUIhJDn+ B1/R/bGDPp1HbBwuHbDFekBVfHrCmbH+zAHhcD53Tv17uCF1CMeSPn2UbK2053jstLPc geD9av6QsibEvyIUawTieHBQdmV0SbeRT7k3p/ICXeS4vbfX7ihRMyCGIAt603maKJik 0ExATAkuD+eQHvTyGSbT2XF2zGTlNoCnaAKoxrGoU4EvWz2tkhX6MAwbeZhYjUCZKAIj G6ag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:sender:dkim-signature; bh=FAC/PFUGqGb8cOS2axlgth00ko2Ztgs7tVmTu+EBpy8=; fh=XHu+LNYCaC+c7myfFZJWf5xWlz35w4n/dzMQ4iQJCd8=; b=cOQoGA0DQV7xoBlw1JB7vcQ8ek9eaby/Kevrqyna08QY2LUM4EQRClOxlFhJ5Lo4ee TBhossYBavStxc3csqDet1uISGYF8Lqa95XzSr1J2MGoTI81QbHlgdfLgl2IcmhCzWnJ HnetEnKuMva2RxNklouVc8PHd2KvCX+MYGpZ9LWN1wXQNWupIeCr9H8n7XMP2+v+twmE /ksSBjWkXKk264xwHEDmgyAn/Wqiv1dLsaHZyEp3V9Pql4jCuTi3UGHvGPgLf7P9/Ir4 +kJ1S1cIeU8vw6/MdGWehn5IsoPLbD+/mpT82gRy6ABItY5hEzfx8DZ1NbySuOAWknP0 4gAg==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1729766466; x=1730371266; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :references:in-reply-to:date:to:from:subject:message-id:sender:from :to:cc:subject:date:message-id:reply-to; bh=FAC/PFUGqGb8cOS2axlgth00ko2Ztgs7tVmTu+EBpy8=; b=LwecbMmu164bJlWKg9OyxwipeFkGn6GBQaJYzdsBqjh6WpBGC8cSHSuhbOe32s3m83 PGUO0M8im5R/xQ3KIVRVt46zhxKeiLkJK3Faaup+uN/nnb1q9R8ANftmV0s4NCtawExh nxp795ExsCpDHYiQB1j0QbVVJqFJjhwz0V+UbxEDfQGFO4cBZFQJMQgCe5juhYC21ikH qBeEmJTKW3Blz8pauTcp4SIGqTLFgiNqZvDxhAyKBzgkc7Ka7tzFPFkn8FCHyWHBSrx5 9TnTAUmljk7MLIRH5ewgwb1J13z6gwWMP2+Rn+VZk+W9C6GbjxHismcJaYLN6/mw4cXi r6Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729766466; x=1730371266; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:references:in-reply-to:date:to :from:subject:message-id:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=FAC/PFUGqGb8cOS2axlgth00ko2Ztgs7tVmTu+EBpy8=; b=ryu/k5e7GcLtaQfFTtUzPFjhQokW5HTqgAYXjkuMM46nS2eZ400wTcol9bg1VkKpIz OVuk9H1QWJPmZMLn+HNFFNLHjhKg+UIZ+r7ApQkKv7dOFctw1V/4pf0HVabvVy7Wtmfx v3aaHo17N8xEH+1NW9thKUzfmSrRMj3wGtG3op+ZNqEfjYA/3yClB8xuqCax6oQ2rJER 0MrYaz9t/EuabvsSXssGBlrRlc0CU8gD4Fwm7qOjPpfljLN6xWAaUHwk/528HiMywfjI 5MuYB8xDMkbNiCZk3AfV4Ag0mePZqjba7UIudXOPYaaEJvO9NvxK3sh/BpSiraDm02tw p4cg== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVI6t0srAPVsOihrBa6hzts+Emg8MLR/yCUqVATWVZ3gyuuxTPlxnJMbCmmAjCxtR7nOd+8@ilbers.de X-Gm-Message-State: AOJu0Yx53jSvdfy89FMSn95Jh0igso7yf5dmNgj1X2wFHybEzsRdTFwU DXlcSeUH1WIIXl/oi7LlKyy6CjvTB6xj8RU2ytN9kB3HFhcQAt/V X-Google-Smtp-Source: AGHT+IGDYhYy7fAZRxo/KghVuACormmBOJXK7tAtd1v6AuJwwmWuLu0lM6H/ZhZDNd8Wl3URm8PMrQ== X-Received: by 2002:a05:600c:190c:b0:431:4e33:98b6 with SMTP id 5b1f17b1804b1-4318b5bbe53mr10387905e9.5.1729766465355; Thu, 24 Oct 2024 03:41:05 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:4e88:b0:430:549c:8d59 with SMTP id 5b1f17b1804b1-4318a2173d3ls2805695e9.0.-pod-prod-00-eu; Thu, 24 Oct 2024 03:41:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVLINriC5p++sNov+auqgEHKjLs7PmwHlctbV6MsuEbqO57JTLtG/nRxXzXk9g3ckFmpIj00bDf5BIo@googlegroups.com X-Received: by 2002:a05:600c:1da7:b0:42c:b166:913 with SMTP id 5b1f17b1804b1-4318bc86492mr10216305e9.11.1729766463005; Thu, 24 Oct 2024 03:41:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729766462; cv=none; d=google.com; s=arc-20240605; b=cI2LsfofoyrLzYUpAYrDz0dyhPC4CtCFZejA7STtFaNAG3NDFLHbUr24JDMt51LZP6 Rl88zRRLcx9bsT947J2fuREkrgjmGMBT08BsXUoTJszqiISz3sskUhvtRh7exjLXmb5R youFS3/sYB0OpQmnAknwGBpYEvzA2dRYtZ2qYc9FQxcHV2jrYw7/Fwhr13OqqLH2y25y hrTKN+NyknpCC9bLa4M36r1k9zjv2nuSQZLo31HXagUg/vRrbVC/pSWdMP2QSxVgRwMG ctyC3X0KGC8wX/EHy6MrhvzJaCqjBOmDegjG3l1MxKU0s2v5Rx+cgKLYGkYK6paFul1A kJ/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=intt41SyB+WXJiXGdJNgaY0z7JkmK6SmpvgY/vWgGSY=; fh=JZvUnqoG0jWph92hWpw0EINycbLveqkIcdkusZDYok4=; b=K65fQdpTrvyhuIABmWM+hWd0SDHzZKxWqHFmSsXMFvSUN6rLB5RzXd//efEkMbv22J pBcEvKyQhznWO8vx/6fnrUHz+YmCnS0yFSgwmYVqJ5qjuhT4xX6f0hik5P8U+ZrBMkDs pnQT2HNXUjfaDJoKZ05++IJIRo1T4z5OrDX50esTfWagrg5AAt9aVpsgK79Z52BIoAgY zwvvTtRj3KxOxAYOthafyLpM0kOpXcUsfwLXUMLg4U1Fr+JfFVzsK2DsvF9WO1T4853h W1hVDIzB9vKNHB9GcjPgTgUI/AgM8nH24Zbes5d8X2S473fyD3XG4z3hY18BLWoeVwxw XQOQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id ffacd0b85a97d-37ee0bdb338si349649f8f.6.2024.10.24.03.41.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Oct 2024 03:41:02 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 49OAetr3017918 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Oct 2024 12:41:01 +0200 Message-ID: Subject: Re: [PATCH v2] initramfs: Avoid hanging mounts on failed update-initramfs From: Uladzimir Bely To: Anton Mikanovich , isar-users@googlegroups.com Date: Thu, 24 Oct 2024 13:40:54 +0300 In-Reply-To: <20241024101004.214465-1-amikan@ilbers.de> References: <20241024101004.214465-1-amikan@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: Jr8GwAdb9ac2 On Thu, 2024-10-24 at 13:10 +0300, Anton Mikanovich wrote: > If update-initramfs fails during do_generate_initramfs task execution > there will be mounts left behind: >=20 > > E: /usr/share/initramfs-tools/hooks/isar-example failed with return > > 1. > > update-initramfs: failed for /boot/initrd.img-6.1.0-26-amd64 with > > 1. > > WARNING: exit code 1 from a shell command. > ERROR: Task (mc:qemuamd64-bookworm:isar/meta-isar/recipes- > initramfs/images/isar-initramfs.bb:do_generate_initramfs) failed with > exit code '1' > NOTE: Tasks Summary: Attempted 38 tasks of which 27 didn't need to be > rerun and 1 failed. > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/isar-apt left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/sys left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/proc left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/dev/pts left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/dev/shm left mounted, unmounting... > WARNING: build/tmp/work/debian-bookworm-amd64/isar-initramfs- > qemuamd64/1.0-r0/rootfs/dev left mounted, unmounting... >=20 > Protect mounting with a trap for cleanup in case of failure. >=20 > Signed-off-by: Anton Mikanovich > --- > =C2=A0meta/classes/initramfs.bbclass | 4 ++++ > =C2=A01 file changed, 4 insertions(+) >=20 > diff --git a/meta/classes/initramfs.bbclass > b/meta/classes/initramfs.bbclass > index 42013356..0197a60b 100644 > --- a/meta/classes/initramfs.bbclass > +++ b/meta/classes/initramfs.bbclass > @@ -35,6 +35,10 @@ do_generate_initramfs[sstate-inputdirs] =3D > "${DEPLOYDIR}" > =C2=A0do_generate_initramfs[sstate-outputdirs] =3D "${DEPLOY_DIR_IMAGE}" > =C2=A0do_generate_initramfs() { > =C2=A0=C2=A0=C2=A0=C2=A0 rootfs_do_mounts > + > +=C2=A0=C2=A0=C2=A0 trap 'exit 1' INT HUP QUIT TERM ALRM USR1 > +=C2=A0=C2=A0=C2=A0 trap 'rootfs_do_umounts' EXIT > + > =C2=A0=C2=A0=C2=A0=C2=A0 rootfs_do_qemu > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 sudo -E chroot "${INITRAMFS_ROOTFS}" sh -c '\ > --=20 > 2.34.1 >=20 Since patch v2 is technically a v1 with updated commit message, already well-tested in CI, we would like to merge it soon (e.g. 2024-10-), if there are no objections. --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= b93c0e5ae4d4c71a0e380b6db7a2e50e2201d85a.camel%40ilbers.de.