From: Alexander Smirnov <asmirnov@ilbers.de>
To: Jan Kiszka <jan.kiszka@siemens.com>,
isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH v5 0/5] Provide infrastructure and examples for custom kernels and modules
Date: Thu, 15 Feb 2018 14:24:33 +0300 [thread overview]
Message-ID: <b95d6954-e042-2a9c-4760-aff13a95c6ca@ilbers.de> (raw)
In-Reply-To: <cover.1518599595.git.jan.kiszka@siemens.com>
On 02/14/2018 12:13 PM, Jan Kiszka wrote:
> This is now finally the promised patches to provide simple patterns for
> building custom kernels for Isar images that replace the distro kernels.
> It also provids the same pattern for custom out-of-tree kernel modules.
>
> Changes in v5:
> - dropped merged patches
> - reworked kernel packages naming and selection mechanism to use
> flavor/arch rather them overwriting upstream names
> - fixed rebuilds of the kernel (.version was causing problems)
> - moved kernel build into script - and switched back to include pattern
> - provided note on origin of exemplary defconfig
> - add KERNEL_DEFCONFIG variable
>
Looks good to me, applied to next. Should I wait documentation for this
feature?
One small issue: you use @XYZ@ pattern for substitution, while ##XYZ##
is used in multistrap configs. I'm with unified style in Isar. I'd
prefer your variant, so just as TODO for somebody - replace remaining
##XYZ## patterns in Isar to @XYZ@.
Alex
next prev parent reply other threads:[~2018-02-15 11:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 9:13 Jan Kiszka
2018-02-14 9:13 ` [PATCH v5 1/5] Make distro kernel replaceable Jan Kiszka
2018-02-14 9:13 ` [PATCH v5 2/5] Provide include for easy custom kernel builds Jan Kiszka
2018-02-14 19:35 ` [PATCH v6 " Jan Kiszka
2018-02-14 9:13 ` [PATCH v5 3/5] Add custom kernel examples Jan Kiszka
2018-02-14 9:13 ` [PATCH v5 4/5] Provide include file for easy custom module builds Jan Kiszka
2018-02-14 9:13 ` [PATCH v5 5/5] Add exemplary kernel module Jan Kiszka
2018-02-14 15:21 ` [PATCH v6 " Jan Kiszka
2018-02-15 7:15 ` Alexander Smirnov
2018-02-15 7:35 ` [PATCH v6 4/5] Provide include file for easy custom module builds Jan Kiszka
2018-02-15 7:54 ` Alexander Smirnov
2018-02-15 7:54 ` Jan Kiszka
2018-02-15 8:01 ` Alexander Smirnov
2018-02-15 11:24 ` Alexander Smirnov [this message]
2018-02-15 15:14 ` [PATCH v5 0/5] Provide infrastructure and examples for custom kernels and modules Jan Kiszka
2018-02-15 14:43 ` Alexander Smirnov
2018-02-15 15:00 ` Jan Kiszka
2018-02-15 15:04 ` Alexander Smirnov
2018-02-15 15:13 ` Jan Kiszka
2018-02-15 15:27 ` Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b95d6954-e042-2a9c-4760-aff13a95c6ca@ilbers.de \
--to=asmirnov@ilbers.de \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox