From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7350220502645866496 X-Forwarded-Encrypted: i=3; AJvYcCUPs9hO43cFGcZ7wCAGwNrZg3jqlybv34fRe8gu3703JUSag9Vp5/iA5PCbJuJ43N1eTleqrwhzBxdyHzF6m8/kDJY8EWcNUCULiCQ= X-Received: by 2002:a17:903:186:b0:1dd:7df8:9ed7 with SMTP id z6-20020a170903018600b001dd7df89ed7mr10531202plg.15.1711373451826; Mon, 25 Mar 2024 06:30:51 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:902:f687:b0:1dd:c936:c9f4 with SMTP id l7-20020a170902f68700b001ddc936c9f4ls1077768plg.0.-pod-prod-08-us; Mon, 25 Mar 2024 06:30:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX9IMr55QqOZVzE67sFY8QmLpvlh58wvP1CN/dmMnK8DLK/jOFH3p4zMNMcFbb1cWNPL2J1jgYGwO6x29RSVKNO+EoRdWbiWiLSwMI= X-Google-Smtp-Source: AGHT+IHqrIRMveuh0c2B/LXut6dcERb59wdCq0yXMitP5GtLI96OOImYC4NElJ9ieQ+p9IlEXQI+ X-Received: by 2002:a17:902:ebcd:b0:1e0:bb04:7776 with SMTP id p13-20020a170902ebcd00b001e0bb047776mr4446983plg.37.1711373450136; Mon, 25 Mar 2024 06:30:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711373450; cv=pass; d=google.com; s=arc-20160816; b=x+FWjR3j8JIJVnHMrKTyHWyUfs6D9Xap2rZfFdZjp2r+lOQhYv32+sSe1DDUmNhS/7 88odAChePo2sdORuvVwUZUY/lUHdO9zSaFkHPEeizqPdruJWpsdzeFASSt/rgBYDjFNb spuMOQRc+KlLjpLVjSU0V3h00kaApYrnEGYjeTc7Tj23tfta7uH/iiOIRJ+tyoyOVhnq mW9BwGRVmOgg+O7WMEp5djpCeHxxdRPva92153Dz3sJSxQt1KV2NcVnkBxZP5khJaV1k 6QvQb8e7P/cHU9/uV12KUpU3zE42tdtdfw0aS8V18blYs+q0hELY1Ya+2c/m/zJ2L1t2 E9uQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=+xz81CCDaE4TNEueGDJ3v3PnsAtkWRPSxScTopDjz0A=; fh=O8qOVoyC4kVwjYhl6ndzNlnWHnJpUJcq4mpswxQLIKQ=; b=rTVucwEvv0b/RpvLVIwlfNm1fis5Vo1eZMglfh2jxqN947hYiuvNT+ZKF3HMfYKp5d O7AWXEUGvGE/f4QeB+jqVitlok1hEEG5DMkZle/Wb0U5TdmRoiS6+JqyKW2/mV8Vj3gi L2CM0A5RnG6NlGIZnoogs3WC2QA2YJ1avIl9zxYAopEspEp0oGEwHi51+kyA8s8AdKIl gH79ztZ3Yh52nf2j+beVmZoAnbMzUSav+lKJHTk2DYMw/kjtCwR5j3DiLnm4FVwxkNoc rAmHPHNMyMTA6qPfpe6L395/+DfLydXR5qyw5FKtIfDTyvqNMLaO6fwUCn5ha1/6yP6l OhfA==; dara=google.com ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="R8X2/D47"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2608::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20601.outbound.protection.outlook.com. [2a01:111:f403:2608::601]) by gmr-mx.google.com with ESMTPS id s2-20020a170902c64200b001defa30ea2bsi333970pls.9.2024.03.25.06.30.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2024 06:30:50 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2608::601 as permitted sender) client-ip=2a01:111:f403:2608::601; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="R8X2/D47"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f403:2608::601 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLIDbKCPOueySu7Txvn5uQHM8E2WTGsE7OrVUOIvWEbKOr7jcJrZZcOl3gf762yxXPQGrDirxUjepcizu2HdHFksVIjx0KtJsWIk0Pk7fP84nMbM6YbqD+pR9ojc7/4KkaH4I8YfCMCQg1pQLOJkFA2oO+qNwBjtYhPTgMneLX0zqO6f1p2QV43IBxXklFzvToCtYHx1H7P+1Ec42mlxiZnOI0nbemqdVz4fnsK1v2YopIcq60DTXQDjgFRZYwchEzKui4zNCoX16+3bDbnXeHF5Rf/zk3b43glmxwCt9c/Vrg4YX8hnfGxS8A42OKYNPLFetkYI2WmcpTyxWKuVAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+xz81CCDaE4TNEueGDJ3v3PnsAtkWRPSxScTopDjz0A=; b=CdYCAdUkuRezrF0Orrh0NBa0Yw1QOgS2OrsKEtb0sNPC4K/E7i216a1Qwj4yGLyhtz9dsnKLXwk+wBWFGN6j/C8znFUblVMKgUyQavxcGh7wPT2aKwwonWP1n4yFAWFH08jklViv4JpEdgetzWGIAA1WluJBrqJLbbfM/hsudSUolHtbLO1dJdqbDsF42eiIjNXgnSIVPasu1cBoQgu2XX3ABwjWk/3kbtNG4lESVX/8Uji8Ay/EPDgUnKEeMsqosbpEScxi4nMy/v68SHVkPhH1dnjl2893u1kRjcjSP/N+ZFFx9GqvVZB3pPvFL3hXgwVMIJ9Cvczg7CJQTPtafA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+xz81CCDaE4TNEueGDJ3v3PnsAtkWRPSxScTopDjz0A=; b=R8X2/D47Ot7qljLjZNTjy8c5L9k0wkxJ6/wHqz1PRmgQXgbm/XLXhzCfSZHlWj087ogqdGkr6mC1ECgBgH2cPTDCH5aOCfp5XmNv8eDOUXPQIMfjAH7n5Y6GHlsMe/otn+a7lfSEEOS2PGt/kBPsGHvSSvTOwJkoU2vX/Q7BKCECa2BZqFVegcgYPqBQJ5KB+x3jkkSbfzzwsEN7cagEL/SZ6zgRPwKlSW6blz1guGnZJpVDQYKWwvyI41I3UQAmjGRkl51eKnobNzkDs3IBFPgr8CpU3cnAiAp5svVtk0z6ys4OAdgT6PRF69pWiRUDqGpUB8XfVmvKx8YNhI22EQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DU0PR10MB5583.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:31b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Mon, 25 Mar 2024 13:30:44 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::4e33:3630:e08:77b9]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::4e33:3630:e08:77b9%4]) with mapi id 15.20.7409.028; Mon, 25 Mar 2024 13:30:44 +0000 Message-ID: Date: Mon, 25 Mar 2024 14:30:40 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wic: bootimg-efi-isar: use static method for _copy_additional_files Content-Language: en-US To: srinuvasan.a@siemens.com, isar-users@googlegroups.com References: <20240325084904.2036784-1-srinuvasan.a@siemens.com> From: Jan Kiszka In-Reply-To: <20240325084904.2036784-1-srinuvasan.a@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR14CA0040.namprd14.prod.outlook.com (2603:10b6:610:56::20) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DU0PR10MB5583:EE_ X-MS-Office365-Filtering-Correlation-Id: a9d142e8-0a49-4ac5-e401-08dc4ccfc5c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ASV54IvIi3UbGm2JmCOfBcXkcpxt+avV5AdDhk1yuSFRPx05cEql5ozOA9LiJPhYwunVLWK2Q7T2qUKS/PT5j4ckIZWRvMBCj3y5HD/Iy+hV0dqO5XRcK9tYjhLFBvQtkmtr5jLO3xCJ6sYIiGa1un4vseHkQK5x6l9YjJ6wO9mWG/SJ4tJJfJ9yvo6yD2nVhhoujIKUS/Suu6x3EmC3w6GXcpXtnP3ePj/aISuign0Xytjv+q86LWEhsyE6ixIN+Vk6yoCUOL56OmTSsBs8WK4wdI1RBohgh7OKATBmnRnkJ2Akuh/zajGfIoEeELeWYwEHbKFvFZLrYJ04x97WMuVruZvdWXJT0y3coFnCKEGkCrIyJOX+eqa1QGbeaM4NUO/kZyYHG5Uc9huafu08s2spnkaiIV2AoTrwht0Ouj6z3EDDzQmrZAM1JioLSPiT34qvcUoOfy40xvyy7RNedaYsVNmoC/bNLaWn1R4M2oq1lQw0Ct7euCCPINZ6YwPLjUnUL9seWN1rHRczlujBCuqRfW4p4Q9i3iS65b6vm3Lbb3Z4laQEXZyJWehtFPad5OQ/yiBW09KXiD4FdyrTxi74aguic1S/PMjTtuRCLeDmMEJRb6Axmc8TwVzL+dZ4E4nzmYfDFC1uJN1NkY7sDLkOCxgy5ezJ4oNDc5KO9yE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUh6RERYMjFJZE1BcXAvZXBoVndiLzFhN1FCYVhwWDl0V3RkVHNtVkRWNHpR?= =?utf-8?B?QU5ybXdHTUZneDJ0SEVqWkxMeTk1MXRLSkJKenRaTjV0clI3RVhNWFBDa0Jk?= =?utf-8?B?SThuS0xweUJsc0U5VXZwNktuZWhFSFk2QnB4QU1LVmg4WmIxNlIvNzBSTHM0?= =?utf-8?B?ZFd6U0U1MXlhMmY3NlF0MmNJelV2VS91UVN3Z3M1MXg3SlVjZTZGb1F6RWYr?= =?utf-8?B?TjlSNDd5dXVXTGFXbER6dExhc2JYTEVzT0VLdmgvcytUTGwzK3FLQlkrbVVo?= =?utf-8?B?ZlpTeUo2OTRQVFgxYnVWdE1xZWp3aE82WlVyTVlzcWJYakg1RDZJS0RDcDFz?= =?utf-8?B?TkpFckFGT2h4SXZrNUdpRWZqZ0J3cHdBdDBLS0l0Y0UzazZ1TlZqeFBWcndk?= =?utf-8?B?YTJyTHpUbE1UaUptejVMUUxrb0dsRjBnZklwRkNqVXVVVmxkeGdvQjhkMFFK?= =?utf-8?B?bWpuT1dDNnBkdmZPVU9HQ3NSWm9QQ2ROb1kzYWduT2pnY3hjNWV6WTdYUTR0?= =?utf-8?B?ZUs4UnkwVXBWTktnUjk5c1BoK1lNT1d2WGpqTS9MeC8zL2M5SjlFTFB1ZGhy?= =?utf-8?B?Q3NwSGM2aVRVcEd5WkVKcWE2ZWE5ako5UEFHNE9NOVNVWnJlV0JYajBRL3V0?= =?utf-8?B?cm81ZUpsTDdYeUpnRVZObUdla2QwNGVxZmdHV1VITGMyVVExOXlCS3VmYmEv?= =?utf-8?B?TWxJaktvR3JMSlkyVkJYWFNJV1FCYURJTEpObVR2TU5GL2UwTisxb1dHdkw2?= =?utf-8?B?L1JTVEdVNE1QSFE3ekhTb1VicnV2dVBiMGR2NW5wWmFrVmhxUXdwMm5IdTJU?= =?utf-8?B?SE1KdlNLdkpIN20xS1grTm1qTGg5WnRiVGRjbFVQVXZXK2NXbmE2U05OaHJl?= =?utf-8?B?eERIeng4eXVMbFpic2I3Qm5NVjlwUys0V3FzNzhpdWRzaFV0a0hZb1dNeVFa?= =?utf-8?B?M2Z5K2VjOFZ0NlNDamprRjNpckZ4b3VtTXdNRzVnVWdnblZweTZEbUt2M1Ew?= =?utf-8?B?RWliUzBFOGZ4RHZ3bGd1R0tUZGVhVkhhenhieFVFYTB3RlZ3aElrUGVackgy?= =?utf-8?B?K1c1bFVIQlZkZ1BURFZUMGdNbm1SM0VUQXFaSzRjMGpLU0hpemNwMjdwOW9a?= =?utf-8?B?a1hQZW1hNThJazRUQStLQkNkaEg3dFlwM1BmMGhyaWJnaytzYnBLemJSNCtV?= =?utf-8?B?d3cwZHFvbGhydVFOWU5IaG9mU284YWZ2ZnZzNlJ2ZG9XbUhCRjZNdTVubjdU?= =?utf-8?B?WjdaMG1Sa3d5LzhHSmNaRXhHQzU1RzFyTzZnYUhSWW5Xak5vOHJ0UHNMSWRP?= =?utf-8?B?MmJpVXhheVBmeUNKdFJqOUV0UTBlZnd2QjdqOWNhYWFCSDRYOS84ZHl2MHd3?= =?utf-8?B?L09mSC80ZmV2WWlLVlRISDRGcTFtNU5UVmhGVkNBd0NnV1RQdCtUbjI4MDJv?= =?utf-8?B?a0xUOUdTSXZSamlpMi9CZUtCdkRRQytLZjZtWWFlNENWOVQ4azQya0dRL1Bw?= =?utf-8?B?WEJwRzg4akJ1MmpMNGNkbTBsdDlsNEVwalhUZTRMTGxnTGpYSTNXNXdkL3J3?= =?utf-8?B?ZzZYSmtOOTZ3MXQ2Q1hlUWJjQkVrQ2xVck9SVm0xR3RvVCtrajJZOHdUSlhG?= =?utf-8?B?SjAvRndPYThIZUMyc2ZIYytqcG1RallVbTBBRTlIOCsyVUJEL3Z5TUpGT2tp?= =?utf-8?B?ODk1cHhacVFuNzAyWXBlRUFXR05nM3dYUGhvcTVVOHAwZ2RzQXRRNTVPa013?= =?utf-8?B?Z0p0b1c1cGxibWxsanNqc01Xc2ZFeW9pL0tLN092SjlkbmJRaUVoVklqTzBV?= =?utf-8?B?UXBpNjc5ckRSaGNKcG5OV0k2UjVmRXY3MFFZYkl2eFgrL1AvdW4ya2I4SEdx?= =?utf-8?B?bElFOUdnOEZLYUNWU0VjUE4wb1NqTFp3K2ZqNTRjOUR4Nk5QMFo3UVVBMWkw?= =?utf-8?B?NlhJNC80V2R4UmRpVDJhR3hLSG1ldU0ycm1uR1MvWEFpclpFdGptS2lNYlhB?= =?utf-8?B?c2swYnptZzZJcmVwUm9FeVJTSDZEdzZ1VnYrQWhSTFVTSkFVd01saUx1Z3FC?= =?utf-8?B?WGpKWVY2bWZuVkJsTkZwU1plUFp6bjUyMnVyclRTQzlldjBTN2hTdys0VUQz?= =?utf-8?Q?JcYXY5xSyOuN+gy62L6DkFg92?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9d142e8-0a49-4ac5-e401-08dc4ccfc5c8 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 13:30:44.2071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ctKh5dlmqaMAi0Fqc0u/02oB+n6br2C88WgsrVZ+HNQZoX1MakIvL/mIHGo6nKOzfPgTbBrLUs/63nXzrtJEpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB5583 X-TUID: m1IkiKpng6Qy On 25.03.24 09:49, srinuvasan.a via isar-users wrote: > From: Srinuvasan A > > Presently we uses classmethod decorator for _copy_additional_files > method, and actually this not needed becuase we are not accessing any > class variable or method in this function. > > Change to static method for the below reason > - We are performing the generic functionality > - Moreover this should be initialized only once > > Signed-off-by: Srinuvasan A > --- > meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > index 4bfb70a0..5fe9bcb0 100644 > --- a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > +++ b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > @@ -40,8 +40,8 @@ class BootimgEFIPlugin(SourcePlugin): > > name = 'bootimg-efi-isar' > > - @classmethod > - def _copy_additional_files(cls, hdddir, initrd, dtb): > + @staticmethod > + def _copy_additional_files(hdddir, initrd, dtb): > bootimg_dir = get_bitbake_var("DEPLOY_DIR_IMAGE") > if not bootimg_dir: > raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting") This is not Isar-specific. Please address this in OE first. Jan -- Siemens AG, Technology Linux Expert Center