Re: [PATCH v5 0/5] Restore downstream mounts compatibility

[Jan Kiszka <jan.kiszka@siemens.com>]

On 18.08.21 18:24, Jan Kiszka wrote:
> On 17.08.21 14:38, Anton Mikanovich wrote:
>> Revert commit d21d49578e5a3b0019075d1946bd93a95914fcca which has broken
>> compatibility with downstream projects. Move try-finally from
>> dpkg_runbuild(), etc. to the caller, do_dpkg_build().
>>
>> Also enable reference counting for image mounts for several image tasks
>> running in parallel (like e.g. ubi-ubifs-img).
>>
>> Tested with kas-iot2050-example project from:
>> https://github.com/siemens/meta-iot2050
>>
>> ---
>> Changes sinse v4:
>> - Fix while loop counts.
>> - Move unmount warnings under debug.
>> Changes since v3:
>> - Warn on first entering in umount while loop.
>> - Do not warn on left mounts by default.
>> - Remote incorrect dpkg unmount usage protection.
>> - Rebase on next.
>> - Improve commit messages.
>> Changes since v2:
>> - Remove incorrect buildchroot/rootfs mount/unmount usage protection.
>> - Remove task fail handler.
>> - Implement double mount protection by try-finally.
>> Changes since v1:
>> - Get back while loop in dpkg_undo_mounts.
>> - Exit dpkg_undo_mounts if already mounted.
>> - Do not ignore exceptions in safe_exec.
>>
>> Anton Mikanovich (5):
>>   Revert "dpkg: Make mount buildroot reliable"
>>   dpkg: Limit unmount loop
>>   image: Add reference counter
>>   dpkg-base: Clean up unmounting in do_dpkg_build()
>>   events: Do not warn on left mounts by default
>>
>>  meta/classes/dpkg-base.bbclass   | 125 +++++++++++++------------------
>>  meta/classes/dpkg-gbp.bbclass    |   8 +-
>>  meta/classes/dpkg.bbclass        |  14 +---
>>  meta/classes/image.bbclass       |  39 +++++++++-
>>  meta/classes/isar-events.bbclass |   2 +-
>>  5 files changed, 97 insertions(+), 91 deletions(-)
>>
> 
> I've pushed that to our CI as well, and if that runs fine, I can give a
> try in one or two downstream layers (which are not on any mount change
> so far). But from reading things, it looks good and fairly consistent now.

Unfortunately:

Setting up git-buildpackage (0.8.12.2) ...
umount: /builds/BLKE9aZ_/2/ebsy/debian/isar/build/tmp/work/debian-stretch-amd64/buildchroot-target/1.0-r0/rootfs/sys/fs/cgroup: target is busy.
WARNING: exit code 32 from a shell command.
ERROR: Logfile of failure stored in: /builds/BLKE9aZ_/2/ebsy/debian/isar/build/tmp/work/debian-stretch-amd64/cowsay/git-r0/temp/log.do_install_builddeps.32372

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux