From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6997052726746021888 X-Received: by 2002:a2e:8107:: with SMTP id d7mr9105673ljg.68.1629308347450; Wed, 18 Aug 2021 10:39:07 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:c13:: with SMTP id z19ls1925902lfu.0.gmail; Wed, 18 Aug 2021 10:39:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwK75cltsWdidOP0jghwjJXUuhogs8DkfVaMdSU8AttRlo34rNyjZnjImKgz4tXBOx4578h X-Received: by 2002:a05:6512:443:: with SMTP id y3mr6885858lfk.97.1629308346184; Wed, 18 Aug 2021 10:39:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629308346; cv=none; d=google.com; s=arc-20160816; b=Tgccj+YpZqkrQ0jz02E7bQnZdFt22lIy2bGLvbwwfWK/eUKmtXOcazAnGjXakvJDu1 fJJDPtaTGrdmnE/oeTZbv9euUHtBAi9wcwWLY1ZEdGWGsfiKEzMOfKDO2wvslxy3EidG KHMjqnS5t8nBu5JG037aw2EQV1/GmxwBhl4Fn19WbiNzxWWotsHAe2M3sI3cATaser4e ajF84+aIEhQw1/Vr4DRajo4sipUmfCQSJ8nAUm8TB9Ua6+mGMo4yk71OAUdlTx+hf+Pb 1q/aMfulb6/cJP9xr/QpO4OgaWwSe7R/VR8xX7XEcI1/DWLhmS+8toTcmmP0LoYbnAkO vhiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=tNm0v+MmIxrp68k/yCvRHtzysSv4ZWtQ2y/xcDpYUsM=; b=YO28Vuwo/Ic7e/6v45HcQ/mwURVWkypb85V6xuDauJtL3VceuavzJ8h0VbTezBnZ2j N5hQ55fzcYFIapMMxEjgGIa4ThXFTdVZNfcBx6Wl0otdZRJa25XIPfbVhJklPwan9SMW Vrcy0pUARv29TeOVLzt3QA1zn9omwgkF/vpYUPw9GOgraQStVMaOMAF9ZAGn9Wp7RCJ3 7TuNwMjT6F/DemveW2AGd3C2ROjnMnpG6iyf5gbDyLV9+NL4VrlL0dqF8Vn1+44RF58u t6IHHjjbiFRkO93Bsag7xTYMppTwXP/O5t8vGe9Q/Z5KZ37tgE7Po/6t5Wketsjig47z 3WLQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id c35si41377lfv.2.2021.08.18.10.39.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Aug 2021 10:39:06 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id 17IHd5lc008825 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Aug 2021 19:39:05 +0200 Received: from [167.87.0.29] ([167.87.0.29]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 17IHd40a006846; Wed, 18 Aug 2021 19:39:05 +0200 Subject: Re: [PATCH v5 0/5] Restore downstream mounts compatibility From: Jan Kiszka To: Anton Mikanovich , isar-users@googlegroups.com References: <20210817123808.3563834-1-amikan@ilbers.de> <641cb94c-e2f2-0beb-9c94-7b8073313aef@siemens.com> Message-ID: Date: Wed, 18 Aug 2021 19:39:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <641cb94c-e2f2-0beb-9c94-7b8073313aef@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: L93jmUihH0iz On 18.08.21 18:24, Jan Kiszka wrote: > On 17.08.21 14:38, Anton Mikanovich wrote: >> Revert commit d21d49578e5a3b0019075d1946bd93a95914fcca which has broken >> compatibility with downstream projects. Move try-finally from >> dpkg_runbuild(), etc. to the caller, do_dpkg_build(). >> >> Also enable reference counting for image mounts for several image tasks >> running in parallel (like e.g. ubi-ubifs-img). >> >> Tested with kas-iot2050-example project from: >> https://github.com/siemens/meta-iot2050 >> >> --- >> Changes sinse v4: >> - Fix while loop counts. >> - Move unmount warnings under debug. >> Changes since v3: >> - Warn on first entering in umount while loop. >> - Do not warn on left mounts by default. >> - Remote incorrect dpkg unmount usage protection. >> - Rebase on next. >> - Improve commit messages. >> Changes since v2: >> - Remove incorrect buildchroot/rootfs mount/unmount usage protection. >> - Remove task fail handler. >> - Implement double mount protection by try-finally. >> Changes since v1: >> - Get back while loop in dpkg_undo_mounts. >> - Exit dpkg_undo_mounts if already mounted. >> - Do not ignore exceptions in safe_exec. >> >> Anton Mikanovich (5): >> Revert "dpkg: Make mount buildroot reliable" >> dpkg: Limit unmount loop >> image: Add reference counter >> dpkg-base: Clean up unmounting in do_dpkg_build() >> events: Do not warn on left mounts by default >> >> meta/classes/dpkg-base.bbclass | 125 +++++++++++++------------------ >> meta/classes/dpkg-gbp.bbclass | 8 +- >> meta/classes/dpkg.bbclass | 14 +--- >> meta/classes/image.bbclass | 39 +++++++++- >> meta/classes/isar-events.bbclass | 2 +- >> 5 files changed, 97 insertions(+), 91 deletions(-) >> > > I've pushed that to our CI as well, and if that runs fine, I can give a > try in one or two downstream layers (which are not on any mount change > so far). But from reading things, it looks good and fairly consistent now. Unfortunately: Setting up git-buildpackage (0.8.12.2) ... umount: /builds/BLKE9aZ_/2/ebsy/debian/isar/build/tmp/work/debian-stretch-amd64/buildchroot-target/1.0-r0/rootfs/sys/fs/cgroup: target is busy. WARNING: exit code 32 from a shell command. ERROR: Logfile of failure stored in: /builds/BLKE9aZ_/2/ebsy/debian/isar/build/tmp/work/debian-stretch-amd64/cowsay/git-r0/temp/log.do_install_builddeps.32372 Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux