From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7327579432489582592 X-Received: by 2002:a19:7415:0:b0:511:54a6:1642 with SMTP id v21-20020a197415000000b0051154a61642mr480975lfe.45.1707123401766; Mon, 05 Feb 2024 00:56:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:4859:b0:511:4864:dd3e with SMTP id ep25-20020a056512485900b005114864dd3els130563lfb.0.-pod-prod-08-eu; Mon, 05 Feb 2024 00:56:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IElPBYdcTWTaGqipFiTXpeG9pvyLCL+ZInwXo2+Ze0dA9EC1P1zPyLRmKClVBjPsf3pPGzp X-Received: by 2002:a05:6512:4011:b0:511:4995:c196 with SMTP id br17-20020a056512401100b005114995c196mr4291552lfb.59.1707123399425; Mon, 05 Feb 2024 00:56:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707123399; cv=pass; d=google.com; s=arc-20160816; b=j60fkTepS4KQMqKKy2vOBXto83qiZN5DUfWluUmZ4wPm3E2TMXT8ARXsVXaJHoy02z 8gs8XVG6Ub8zIwfeBTajo061PibvYO74VGdKrRs20U88DHWudOg4gXZbLPPOcYTtkHCM qfBS+NUxN19f35r1DMnqhCVVHraZ1zx7lVDktriJDgrY/dGYXCvRad1G0XXzTFWaG5Oi C3RvdxYzoEeOvBKL/hXAGww19t4aN0P4uO8x+FRjUgNO7TPhPToYOTfdEIFoqUcshnBL Yii5dWJsjH34byOfbApaJ42oY1OHtrixFef1INJ5gAY8jfzeO3p6CLHIdxFA5G1a6xuO wrKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=QWGsn8omzW6dsMl9947r+m0TRRPYU+sueFKBfWtp/MI=; fh=aRHZwU756Ejd1X3FCH1jfbMjVB0cfpPPji3mtAfnYBQ=; b=hOqXWK0ox1sMWIj7FUkrln/cz8U1lki9Hw7qoFEjnuMSuXXju864qe1di7G1dwfGbe lXCiiZM34I+85p+YfF355YZY+sd73R6ocdaUVvXEGijmsbYoppwgUUgRJerGT07mfMPo SCzKfePE4t8zxXv4j4KyJaKL1gkWsTPL6nFW2OlecPsb7h4XIAh9/u+IS7PTrtKvZrXO 7caAuHIcsFTLYu9wCV1vvlCKNcZqp0G8Tp978lMig65gGwcFLlWk9XJZV8YeKq7xIfRr i83W2BDeztP7bgUrXQcva9XIfO/YVTHb7Cu3TmM7xErUE+AXr4rxTKVa2NPm2BduCB00 9p3Q==; dara=google.com ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=bpmdnDtx; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::61b as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com X-Forwarded-Encrypted: i=1; AJvYcCUe9hj7VUAFDYjuEkrHxDn3xJfDI7mzJ2RDBkFH30uXaBXd4ufRNgzb5t8iLgEq8rgDCDOaqCqRxFn1z1JNXlyGx/xGWA64VvTjrlY= Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061b.outbound.protection.outlook.com. [2a01:111:f400:7e1a::61b]) by gmr-mx.google.com with ESMTPS id p2-20020a05600c1d8200b0040fcae66937si333675wms.1.2024.02.05.00.56.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2024 00:56:39 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::61b as permitted sender) client-ip=2a01:111:f400:7e1a::61b; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=bpmdnDtx; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1a::61b as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YtBEWsNX2Axf2nuy+yeFV8ZTxPGorwusHKzGFP3cW2Hcw0htdYfvuqzpUSdA10P3ud8SLKI1Ts9NI2mg8yfUa129TxFq/D0aDXfN7Vm2U0RwoEoANJBXLHDOV42yTPc1pI6L1wQjNwqyiWHxWx+IopqGiAONVOLA+E23uBjp/ou6QR7mBI3Q2WycXOkH20ctxbrbE76/TMftYDTtJD40TNJoGNn9QPAQ8NvgeT/qM6McsbFXieLpJjk1CLZs9IH95yOMQGVfokHxeIxoXfsSoxRKSu3nMmDRHuLVh2tApU7TNyzGD/plBCdiUo0jIJXFaVRTeZWA2RnGdUEmOsoIsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QWGsn8omzW6dsMl9947r+m0TRRPYU+sueFKBfWtp/MI=; b=c3iW/mZ3q6FUxc20he0F8l7oSYG0xFMIxTxQYw5WIdxVfdiB0aomaNjvTsntJX46EDsb4AIZWDNoWmNDaT6CnPcQDVxH6apcBUS59Myzgn1et/AobRvmdTLZQS/jfuLmgP4I7XEgrufMAPL0prxqiJkWRJZf45jV/Bpc3uOrDCV8NYZ2htvI1c9sdytC5Z+ITaraxF7Sr2i3Sg/GDFmzIe8c/W7rQQI3e/8tdwYyqFSsoaKP7V3VWxeDz2Xokd75JXuZ3Cbieomxfg5k/LzAfIN+bOe2Xu+a53DJJi54V0/Nrq3eSDQLiqtOZR0J9uWO9TtJGAEc+B9fGo2WiOaycw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QWGsn8omzW6dsMl9947r+m0TRRPYU+sueFKBfWtp/MI=; b=bpmdnDtxJnlL33rSERrqymwSW1lB0YlCrpQj0q6/H0gNic4cJE+KNErwp9Zx4ErgT8D/vHtDMnhjCnwLlYYPyHTac1HVe4y9EDvWhiqHJ5541l3kocSDCfG85wPVjfcOcbcHc9wV1w7FrDl+GXRLzRZ/byGA1gvC5vuuD05d+wnrZkWc8ZlqLoV/1hl4UzCbRpHAIo5/EQd4T9A3oNBEdhDLHL3d8AA9t3r0WflqCkT1jWYrgQ3oyaOeLrP3QtiaxaC9sczk6lE+uiUeozGW/2za8eaABwidsPRPg4SHIMYHnptd8nSWDwVxeR+R0I2Ytrj7b1cowkCSjv//8/FfJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DB4PR10MB7421.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3f2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.34; Mon, 5 Feb 2024 08:56:38 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe%3]) with mapi id 15.20.7249.027; Mon, 5 Feb 2024 08:56:37 +0000 Message-ID: Date: Mon, 5 Feb 2024 09:56:36 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] dpkg-runbuild: start with clean apt-cache Content-Language: en-US To: "Moessbauer, Felix (T CED OES-DE)" , "ubely@ilbers.de" , "isar-users@googlegroups.com" Cc: "Schmidt, Adriaan (T CED EDC-DE)" References: <20240124083016.177845-1-felix.moessbauer@siemens.com> <5ea67af2f0709033b0d3ab32d84a9ab9e8415845.camel@ilbers.de> <7247dd4f13b0e918e775422dd866de8b21cec731.camel@siemens.com> From: Jan Kiszka In-Reply-To: <7247dd4f13b0e918e775422dd866de8b21cec731.camel@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:92::11) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DB4PR10MB7421:EE_ X-MS-Office365-Filtering-Correlation-Id: 09b24746-d2f6-43e9-96a2-08dc26285cdd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ulR11Jd/jlzgAnO3sM33fk9J1Fzwo4J52sQFFTKKjEB6bA/9qSZlIOPcSeHzfoGXTHVjIM73uAcnGIomPUJZoJbV1vMiTMH2FJQm51QB/wO59uhSzmBiUKsRVAu/Jljlc86Aje3AOYwwF1FJGu9FbO++vxMz0QXTxL18jIN+0IQ1e1JeULM+pY8PugvDcHAEGGZc4f7FfxrB4x+I7JyMX3dHriXgBmi1H4VHmWQF0FakbWLBJcxzA3T8dZyE77lO9TIvc7jPWs4QVO6RewbrM4iCMMyyrol+LR7tG6QXTEc7omhzb7lAZEH2LhCBpxCHNPmozyyliN9WDs/9zpw+TJ7c/JFKggBkZ1ZIY/D1nSXfaeHkCJgI0Q+oxe3FmhD2DyO2l+8D79AhXa+7AILyQzwxaT9r8t4e8tK5Jy0QrkADe6dBUujzQHxyxkmYk85czlGS3MzmxpAtHMtd41/MDuvhHUM/gFC1y4KZ0wbHs484eHskym+NDmjMKT4jL5d1+seYx/wsvCrN1CY13osQ/S+u8cMUHZJJ8BYxEbzgckWrMoqX7n73uE0v1hECJ75wusERZk3FpkxWRKtF/bU954UBst1NTGarKuplFvdPElcmkzzk+TdY0xh/yqxc35k+A8NPyTLKj80liTlp0tzGVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(366004)(346002)(136003)(396003)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(41300700001)(82960400001)(38100700002)(44832011)(5660300002)(4326008)(66556008)(36756003)(8936002)(8676002)(2906002)(31696002)(86362001)(6486002)(107886003)(478600001)(26005)(53546011)(6506007)(2616005)(66476007)(66946007)(316002)(6512007)(110136005)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2pZZjRYSkd6b1FGb1JJdUNaWFhEUWJDNS8wYzBZS1ZqUS9Jamgwb0Vaa1pw?= =?utf-8?B?MVNrbktIeEVvY0RRNVZDcGNwZjUxSEhCSHhPUWtMK09qZng0Ukp2SXppczQ1?= =?utf-8?B?ZWl6djdqOFJWNGY5VFU0ZzB3Q1lsLzhLRTBwZkZYaWlwNVcrc1VqL3BoNkZB?= =?utf-8?B?RGNXNDJMQ0E0a0ZyRnNNM1F0UFdxQmtzdzVoOUptcmdwWmQxWFUrU1Z0aGRt?= =?utf-8?B?Z0hqSmpRZGY1YXB3citJOE5uMjV4ald0cXpJMFk3Y2lIMm03TDVFcFBaTG5r?= =?utf-8?B?T09KcFUzUHpUOXQrWEFwWWE5eUplM2VsM2t2RFIvbWhDTlZvbDRnTHpvdWlC?= =?utf-8?B?SGJlOUMyaUJJOFdkR1JpUzBJaVVHUy9KaDBMSU14engvQ1Yzc0hZNmFJeXVh?= =?utf-8?B?bm0wd3ZUQ0dhRXNpTlpTV25XdDVaalJRRG9pTjExQ2JFT0d3T1BJbFVLU3BU?= =?utf-8?B?aG9EL0tDbHRuVElpVDJMWEdMZk1TbnIwaS85cUc5QXhPTXhZay9UbkZWKzho?= =?utf-8?B?ZVVkcDR3a2U4K0dIdEo0ZTFlTEZwdXh3TzRQaWhqK1d0alVrd0ZRN08yNVMw?= =?utf-8?B?V2ZYam5qVWhNdjNFbWlJd1FHOG1BaWhrL3A2bkhsWDBkSXJRbERRTlZyYlFZ?= =?utf-8?B?bk9VREJDOStTZUtBbEtGdXA0ajdFWXpXdnpqdDQzV2wxQTlwbFFzN25KT0p2?= =?utf-8?B?UEJ1SnY0RFZFdFJ5TXhuamNab3ZwNUZPSUdmbm1zTHFqOTA4dXI1Zkp1Nm5W?= =?utf-8?B?TW15TXlTSG5nVGI4MmtyaWMyMUJOclpPOGQwaEhNU05IWTFxRDR5QUJycmRG?= =?utf-8?B?aS9WL3BkS003cEs4c25xbjEvWU1rWHVNV2JGL1FGMkdoL0oxRDh1MEc1NFlN?= =?utf-8?B?dkRGMUM2V3ROT0J3cTdMYXM3eWZnV093c3VQbjZkeXNmWFc4Ym9MVWxZWTJm?= =?utf-8?B?emtYam81Q3V1UUthWjNjYVVmZ1VqNnp5RjFuTzVJRFhNQ3oxeXptL0l5VG9E?= =?utf-8?B?SDM1S2JQRnhIR0FJMWJodStDU3dMRjk1U0VvaXBLbHdZR2VISmRWR01idU9H?= =?utf-8?B?bzQ5WnJIUjRwUThiSklkUnRzUjRKeHo3d2Y0WlFucDYxdldFdVZiL051MitZ?= =?utf-8?B?KzR6dTEyOUJqZ05WejB2MHBvcTd0Y2NKYXNxTjY2REpReTR6cHV1NjZIOWNG?= =?utf-8?B?akFORlM0UEJlR2JMaHc4ZmtjV3NBelNpUUl0TXJTK3BtWmFFSStNYkRPMng5?= =?utf-8?B?M1c5NFZmVWZoZ1FqMDhpcDFUNUFabmk2SC9ZY0xQYmZmNzVyZkZwdVdtZGVp?= =?utf-8?B?RGNvR2RaaWNkR3FlQW5NUlVHVEljOHZCUWhYNERyYTNkcmg4c3dUTElOQWhO?= =?utf-8?B?RUZzTUdIcnJYNXg0V04rNHhFbWpLMU95TWFKSXhXZDVkYWxwL0FYUWt4QzQ5?= =?utf-8?B?am9oMmkyUkV6OUk3YTdZY2NUK281MjFmM05nMDNReitkZDVGWTFmUEdnUGww?= =?utf-8?B?ZnhvRVZKVVo4NlpZZXZaZlIzYU4xdVlOMkZyZndxZ25XR2k2NmRGWEhDUlUr?= =?utf-8?B?QTREdDhyUU5EZjJVNko0Z2cyTUxONkIwWmZ0KzVpZkRwUHFqMnlvdFVKMEZh?= =?utf-8?B?d0l2Z1NmNDJmM1ExODl2dTZUMW94SVBUUWNVTXl3VW16VlZSYlBSeDBoaWNi?= =?utf-8?B?RWpucXZDeGVGVXJsMXlvS3ErZXJKY1pLQmlDTlU5YXE1L0RaWXVJRTJvTHkz?= =?utf-8?B?RldiaWt3WUFKSlRUeVJ3MW81YmpPK3I4bjdabFVia0hyQXJJZytZeWVMaVpZ?= =?utf-8?B?TTBiZE1ucGM3UVdJTnFtZS9XL1ZIbk93VG1LQVd1cWdRS1FoQ0ZON2ZjSUh5?= =?utf-8?B?YXJ6V2ZnRTFIb0NudlZsK0lBNnp6RnlEN2pJc1JyOFlmbzdaR0h1TEx3Qi8r?= =?utf-8?B?YmJiVE1Kd2FpdGg3YkxiZnlNYlAra2FMdEhpakNMa0MrcTA1emJ2RTBxK1hv?= =?utf-8?B?NFFUalI4cWJDajVveUJFYmYxN2hKNEJjTVNidjB1R2Y3WTZoZmtJRzNPRFQx?= =?utf-8?B?aStEVzhEc1dwS2Q4amJKdG1LQlFzWXpYODArQUJjdzRLWW9MSjhWQjhnTWFB?= =?utf-8?B?VWVGS1h0dnBYZDkwQmZvaVlhYk4zRDVhRlZBbHRremNhSkpkRFl4aXFQV1N6?= =?utf-8?B?VEE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09b24746-d2f6-43e9-96a2-08dc26285cdd X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2024 08:56:37.9251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s8Xx7KLavKTXWLnVjMhPxsARZubLlinG+yb+DkI7Yp0MZCfP3tYd2MjzW0PaDhCyZUd6CQLno6E2nxJEtYWA1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR10MB7421 X-TUID: yu760Kh7yQ0A On 05.02.24 08:35, Moessbauer, Felix (T CED OES-DE) wrote: > On Sun, 2024-02-04 at 12:10 +0100, Jan Kiszka wrote: >> On 29.01.24 11:50, Uladzimir Bely wrote: >>> On Wed, 2024-01-24 at 09:30 +0100, 'Felix Moessbauer' via isar- >>> users >>> wrote: >>>> The global apt-cache is imported during dpkg-runbuild and cleaned >>>> once >>>> the function completes. This works properly on successfull >>>> builds. >>>> However, in case of a build failure, the apt-cache dir is not >>>> cleaned >>>> and re-read on the next build, leading to unstable builds in case >>>> erronous data was added to the cache. >>>> >>>> This patch adds the local apt-cache dir to the cleandirs and by >>>> that >>>> cleans it before the function is executed. >>>> >>>> Signed-off-by: Felix Moessbauer >>>> --- >>>>  meta/classes/dpkg.bbclass | 1 + >>>>  1 file changed, 1 insertion(+) >>>> >>>> diff --git a/meta/classes/dpkg.bbclass >>>> b/meta/classes/dpkg.bbclass >>>> index 3057329f..8800ce41 100644 >>>> --- a/meta/classes/dpkg.bbclass >>>> +++ b/meta/classes/dpkg.bbclass >>>> @@ -34,6 +34,7 @@ CP_FLAGS ?= "-Ln --no-preserve=owner" >>>>  CP_FLAGS:sid ?= "-L --update=none --no-preserve=owner" >>>>   >>>>  # Build package from sources using build script >>>> +dpkg_runbuild[cleandirs] += "${WORKDIR}/rootfs" >>>>  dpkg_runbuild[vardepsexclude] += >>>> "${SBUILD_PASSTHROUGH_ADDITIONS}" >>>>  dpkg_runbuild() { >>>>      E="${@ isar_export_proxies(d)}" >>>> -- >>>> 2.39.2 >>>> >>> Applied to next, thanks. >>> >> >> This does not work that cleanly as it suggests: rootfs requires sudo >> rights to be cleaned reliably. I'm now getting build failures on > > Despite the name, this is NOT a rootfs but just a regular directory > with only the apt cache in it. All artifacts inside this cache should > be writable by non root. > >> rebuilds due to that. Maybe using the root_cleandirs flag instead >> would >> work? > > Another undocumented feature... But yes, the code looks like this would > solve the issue. Will you have a look? I'd like to not have this regression in the upcoming release. Jan -- Siemens AG, Technology Linux Expert Center