public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'MOESSBAUER, Felix' via isar-users" <isar-users@googlegroups.com>
To: "amikan@ilbers.de" <amikan@ilbers.de>,
	"isar-users@googlegroups.com" <isar-users@googlegroups.com>,
	"Kiszka, Jan" <jan.kiszka@siemens.com>
Subject: Re: [PATCH] sbuild: Declare using random build path
Date: Wed, 19 Mar 2025 06:59:50 +0000	[thread overview]
Message-ID: <ba9b5e8c7f036594651ce6db0e41ee5fc39b2d3a.camel@siemens.com> (raw)
In-Reply-To: <6866b9a3-9953-4f41-b1dc-9074edf91012@siemens.com>

On Tue, 2025-03-18 at 22:20 +0100, 'Jan Kiszka' via isar-users wrote:
> On 18.03.25 16:50, Anton Mikanovich wrote:
> > After 0.87.1 version of sbuild BUILD_PATH value is no more random
> > by
> > default. It is better for reproducibility but breaks concurrent
> > builds
> > because this path got removed during cleanup stage.
> 
> Can you elaborate?
> 
> > To keep sbuild choose a random build location (just like it is in
> > older
> > package versions) set the empty string to build-path option.
> 
> Err, no. We clearly need reproducibility as well.

According to the "reproducible" definition of Debian, this change
should not matter, as long as we apply the -fdebug-prefix-map switch on
compilation (which we do).

If this change really does not break reproducibility needs to be
verified, though.

Felix

> 
> Jan
> 
> > 
> > More details can be found in sbuild commit:
> > 14cc3a41f7eed7d9bd62e3c443d077b0f345cb24
> > 
> > This fixes Isar building on Trixie hosts.
> > 
> > Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> > ---
> >  meta/classes/dpkg.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
> > index 64404103..0e5a495d 100644
> > --- a/meta/classes/dpkg.bbclass
> > +++ b/meta/classes/dpkg.bbclass
> > @@ -124,7 +124,7 @@ dpkg_runbuild() {
> >          --finished-build-commands="rm -f ${deb_dir}/sbuild-build-
> > depends-main-dummy_*.deb" \
> >          --finished-build-commands="find ${deb_dir} -maxdepth 1 -
> > type f -name '*.deb' -print -exec cp ${CP_FLAGS} -t ${ext_deb_dir}/
> > {} +" \
> >          --finished-build-commands="cp /var/log/dpkg.log
> > ${ext_root}/dpkg_partial.log" \
> > -        --build-dir=${WORKDIR} --dist="${DEBDISTRONAME}"
> > ${DSC_FILE}
> > +        --build-path="" --build-dir=${WORKDIR} --
> > dist="${DEBDISTRONAME}" ${DSC_FILE}
> >  
> >      sbuild_dpkg_log_export "${WORKDIR}/rootfs/dpkg_partial.log"
> >      deb_dl_dir_export "${WORKDIR}/rootfs" "${distro}"
> 
> -- 
> Siemens AG, Foundational Technologies
> Linux Expert Center

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/ba9b5e8c7f036594651ce6db0e41ee5fc39b2d3a.camel%40siemens.com.

  reply	other threads:[~2025-03-19  7:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18 15:50 Anton Mikanovich
2025-03-18 21:20 ` 'Jan Kiszka' via isar-users
2025-03-19  6:59   ` 'MOESSBAUER, Felix' via isar-users [this message]
2025-03-19  7:32   ` Anton Mikanovich
2025-03-25 16:57 ` Uladzimir Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba9b5e8c7f036594651ce6db0e41ee5fc39b2d3a.camel@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=amikan@ilbers.de \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox