From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6924371667242188800 X-Received: by 2002:a2e:8503:: with SMTP id j3mr5271260lji.272.1614680841535; Tue, 02 Mar 2021 02:27:21 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:391a:: with SMTP id g26ls3380797lja.4.gmail; Tue, 02 Mar 2021 02:27:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRkkBt2KSAAMHcw9sqQGcFvcG/B9dmWg0mFO2aIG8FkdADTSKDPuGuKe2G27u4/keN3vB9 X-Received: by 2002:a2e:8e27:: with SMTP id r7mr11784360ljk.414.1614680840362; Tue, 02 Mar 2021 02:27:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614680840; cv=none; d=google.com; s=arc-20160816; b=mICmL1mdu6V7HzvbM8A5Hezdmmx7BOP8UFIZ1EP+0hC4YRI3IhtCwAAL0xNQaVrSNk dBHf392Eht5aQpFVjbaIHO1wgLo8CU0KTTP1ZV6z4uin2Yg2ZPA7h+qippkdjryD9oT8 kyeNXfE/T88VtBOaD4vmo7PaWlng9+dBrdCKIG+/iqeN3FvRUeawtbsvhgIQimuPRrOQ ejlOQyvJ+9TGpVYWqkqPmXE6rs8rxWlhOwyUh4u1ve7LtdpENMiLmnZdiyUiiICtIdaE RCWOyYwW4hIn02+gUBvUBvBRNxugd919EcJbNVfVtypJnjE6qxREkiaBw0EMEtmdYsm0 xNYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=OwQrOR6K+NevkJZ3chAEf8YuC2vEJFvkHOvK/z0qEJc=; b=EvSu9VC0rjTqLozEYC9fBRbCT6HzjemmAIkhvvGocFv8jMGTLKgE8vW9SOKQesa2UM 8yWQS4rxJxBOKVIF09YkF7NXLGXK7V5L37RCH2hZQb6PObzW7eiw5nzQF2hIFus1Oc0r rIjcNsoIrkJz4/mceswcz72nB5pLtPmQY8xZ4GHYTFB/GIaM2Idb0OfibJzUPGnmy99u F4CUegyd0v3WCvAwe1MFn8BndsDA5jUZG+1b1sbHKUGR1NgdS4ebilVjudOPzcdA4JML yHAbC0puAY3KVeROvLRlEh98gnSfpm+7AyAOu1SbOt2Ow/cy8lGwy5zBBzw3Wl/lbbL9 Ye7A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id m17si845491lfg.0.2021.03.02.02.27.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Mar 2021 02:27:20 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 122ARJX7031256 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Mar 2021 11:27:19 +0100 Received: from [167.87.26.118] ([167.87.26.118]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 122ACIGv027758; Tue, 2 Mar 2021 11:12:19 +0100 Subject: Re: [PATCH] wic: Warn if an ext filesystem affected by the Y2038 problem is used To: Henning Schild , Florian Bezdeka Cc: isar-users@googlegroups.com, ibr@radix50.net References: <20210217115643.GD20742@yssyq.m.ilbers.de> <20210301151823.64574-1-florian.bezdeka@siemens.com> <20210302102058.4acf2774@md1za8fc.ad001.siemens.net> From: Jan Kiszka Message-ID: Date: Tue, 2 Mar 2021 11:12:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210302102058.4acf2774@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ZQBadZCBGuXH On 02.03.21 10:20, Henning Schild wrote: > We usually try to not backport but bump the whole bitbake. There have > been exceptions, but usually because maintainer did not enforce that, > not because commits have been "super important". > While this one looks good, i would say it does not justify such forking > and will need to wait for the next bitbake version bump. > > But feel free to bump all of bitbake, might be smooth or a significant > amount of work. s/bitbake/wic/g, I suspect... Jan > > Henning > > Am Mon, 1 Mar 2021 16:18:23 +0100 > schrieb Florian Bezdeka : > >> This is the backport for upstream (openembedded-core) >> eecbe6255584 ("wic: Warn if an ext filesystem affected by the Y2038 >> problem is used") >> >> We are getting closer and closer to the year 2038 where the 32 bit >> time_t overflow will happen. While products (= embedded systems) with >> an expected life time of 15 years are still save the situation may >> change if your system has to survive the next 20 years. >> >> ext2 and ext3 filesystems are always affected by the time overflow, so >> let's warn the user if these filesystems are still being used. >> >> If ext4 is affected depends on the inode size chosen during filesystem >> creation. At least 256 bytes are necessary to be safe. As ext4 is >> used very often (and partitions may be created small first and >> extended later) this might be an issue for many users. >> >> Signed-off-by: Florian Bezdeka >> --- >> scripts/lib/wic/misc.py | 1 + >> scripts/lib/wic/partition.py | 15 +++++++-------- >> 2 files changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/scripts/lib/wic/misc.py b/scripts/lib/wic/misc.py >> index 4b08d64..c4332d5 100644 >> --- a/scripts/lib/wic/misc.py >> +++ b/scripts/lib/wic/misc.py >> @@ -26,6 +26,7 @@ logger = logging.getLogger('wic') >> >> # executable -> recipe pairs for exec_native_cmd >> NATIVE_RECIPES = {"bmaptool": "bmap-tools", >> + "dumpe2fs": "e2fsprogs", >> "grub-mkimage": "grub-efi", >> "isohybrid": "syslinux", >> "mcopy": "mtools", >> diff --git a/scripts/lib/wic/partition.py >> b/scripts/lib/wic/partition.py index 4a5a31e..e6bcc9e 100644 >> --- a/scripts/lib/wic/partition.py >> +++ b/scripts/lib/wic/partition.py >> @@ -432,26 +432,25 @@ class Partition(): >> if part.mountpoint: >> args = [part.fstype, "mounted at %s" % >> part.mountpoint] elif part.label: >> - args = [part.fstype, "labeled %s" % part.label] >> + args = [part.fstype, "labeled '%s'" % part.label] >> elif part.part_name: >> - args = [part.fstype, "in partition %s" % >> part.part_name] >> + args = [part.fstype, "in partition '%s'" % >> part.part_name] else: >> - args = [part.fstype, ""] >> + args = [part.fstype, "in partition %s" % part.num] >> return err.format(*args) >> >> - ret, out = exec_native_cmd("dumpe2fs %s" % rootfs, >> native_sysroot) - >> # ext2 and ext3 are always affected by the Y2038 problem >> if self.fstype in ["ext2", "ext3"]: >> logger.warn(get_err_str(self)) >> return >> >> + ret, out = exec_native_cmd("dumpe2fs %s" % rootfs, >> native_sysroot) + >> # if ext4 is affected by the Y2038 problem depends on the >> inode size >> - # Remember: inode size depends on the file system size >> for line in out.splitlines(): >> if line.startswith("Inode size:"): >> size = int(line.split(":")[1].strip()) >> if size < 256: >> - logger.warn("%s Inodes (of size %d) are too >> small." % \ >> + logger.warn("%s Inodes (of size %d) are too >> small." % (get_err_str(self), size)) >> - break >> \ No newline at end of file >> + break >