From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7031105237209317376 X-Received: by 2002:a5d:548f:: with SMTP id h15mr27543389wrv.99.1637218247527; Wed, 17 Nov 2021 22:50:47 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:fe0b:: with SMTP id n11ls2047826wrr.0.gmail; Wed, 17 Nov 2021 22:50:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzcf159d358E4YpYHrFss5yAw4unulHm+Y30iP+QZR4SvHoujQmlDNf1/fau4CvVvrBINVE X-Received: by 2002:a5d:64c3:: with SMTP id f3mr28882955wri.377.1637218246672; Wed, 17 Nov 2021 22:50:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637218246; cv=none; d=google.com; s=arc-20160816; b=mHtE88ClpkqTFOfKyOnOMPM32VjCSus2JevRf6dU/wDHk7tiaeUT0MyUxrUJKMUtnc V4tOHgN6ltvQnHgQrhmQXzIVw36GGK6TtGRFOLogaPZqbDCjN6Nig+B9qAKOA2QQoF15 hyt1Yy1wOPTaDdjhEtl6fHEwOLrLUpmgGWo+skCLCrXldZHT0zsYpOxvKNb2+/DX48my YuRuEe44aqDR+8jp5KsGyvNuYxYtlQNGUkTGy3Izvnpn7yeSXPE/S44si38RkiVtbSL/ 8QpO2MsdA5ucofHj1VZ1gRXo1zYC2nYx3Y8uvto9cjUFMX/X03Lwn5Qf9wkLrcedbO91 Fb1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=z8XpIQgWNz7Lko3jn5QjcFUdGSc4NUV3q2lwkmfZkv8=; b=0PHzFspLduSCiYJvODM0iGfxabPs6wl4ibPToc7S1a2rS/0NjdqBLonWpSqlCkFcNY X6GliVCVCT2IbIXGSyNY7QENMCjjhBoy2QQuQUKmBNtSWN2zTdxZHofJgNr+W2Lmo2vC fZAMsSZrjG5zqbtkXZ+DW+8euG8KFdjT5TcxTSG4E649SgjjmJfWv/yGA1wRfQ2O4A4a jFpsXvsm4v0dIY0PW0s2cLzdwVizdTMACt/tFAnmVa47/RPaxJ8v5DsFOIqya2SG8Arj kEzhp3a7LOr2FPOq6tsfFZ4Tbo2P/t6ujZSlkIbxXzO82f9t9m4hQfWQgYIv1YpFnet+ deBg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id d9si103382wrf.0.2021.11.17.22.50.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Nov 2021 22:50:46 -0800 (PST) Received-SPF: pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of amikan@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=amikan@ilbers.de Received: from [192.168.67.164] (mm-55-56-214-37.mgts.dynamic.pppoe.byfly.by [37.214.56.55] (may be forged)) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id 1AI6ojxw015035 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Nov 2021 07:50:45 +0100 Subject: Re: [PATCH] isar-bootstrap: Fail on invalid apt source list To: Henning Schild Cc: isar-users@googlegroups.com References: <20211116095907.198455-1-amikan@ilbers.de> <20211117181224.6699a2a8@md1za8fc.ad001.siemens.net> From: Anton Mikanovich Message-ID: Date: Thu, 18 Nov 2021 09:50:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211117181224.6699a2a8@md1za8fc.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 8GX4HmSKAo4N 17.11.2021 20:12, Henning Schild wrote: > Am Tue, 16 Nov 2021 12:59:07 +0300 > schrieb Anton Mikanovich : > >> Returning empty list leads to ambiguous errors, so we should fail >> early if distro sources.list is empty or incorrect. >> >> Fix issue #72 > Not sure that will work. In case you want github to close on "master" > merge. > > Fixes > Closes > > should work > https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue This format will be shown inside the issue like `username added a commit that referenced this issue` whenever it pushed. See https://github.com/ilbers/isar/issues/73 as reference. We are not using pull requests, so not sure if more deep integration is really needed. >> Signed-off-by: Anton Mikanovich >> --- >> meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc >> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index >> e9f92916..20a9afaf 100644 --- >> a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ >> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -163,11 >> +163,10 @@ def generate_distro_sources(d): yield parsed >> >> def get_distro_primary_source_entry(d): >> - apt_sources_list = get_aptsources_list(d) > maybe that should be its own patch? Looks like a drive-by fix. Ok, will separate in v2. -- Anton Mikanovich Promwad Ltd. External service provider of ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn, Germany +49 (89) 122 67 24-0 Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov