From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6743100217749405696 X-Received: by 2002:a5d:63c6:: with SMTP id c6mr1434466wrw.117.1570001382331; Wed, 02 Oct 2019 00:29:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:d18d:: with SMTP id i135ls507316wmg.4.canary-gmail; Wed, 02 Oct 2019 00:29:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpmbtjbtiVuO9Ohs/6mZNREot7mo30N7iCHFcmiAflR3iE7wN06wM1LyLZSlY7K++XavR1 X-Received: by 2002:a05:600c:2153:: with SMTP id v19mr1669985wml.146.1570001381810; Wed, 02 Oct 2019 00:29:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570001381; cv=none; d=google.com; s=arc-20160816; b=vGdO7JZ/cCpiS7H89Zpnaxr3b/z/cuYtPE4765szTA+M/9EzM/3aaT8CJA/5WyjVnr XSEUhMiUM0yik0hs4gYhNU0Cn03fxeHEWUpRFiK4IzhjoLyJCE65P/SEtbyIgQveIyjR /uneSrZ5DJm4FWUX30kdWZfAzED6TWevQBuMGziJQOZOite5CiByljp/evMDbkFCoYFp ZNMejklqTtknt3F/HRDIc4TEYwNQeT6ut2I+HhZRhNrByYByZ7c/M+kdY1VRHgs/pm23 S0AewgP/lkFdQG2lLUwiRt/3R2YNfr/3sNYMKexSRAkXAXXhI2ZjSl7S8SsTbjOrHvHv kvQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=ixA1afVOpaIfkeK9G8H8dzXPM+is2AonO50ohw18Q5c=; b=vZG4521eUvz61tTg3VRM68iLJRhur63BkzXH2c+LTKNDkGXPFovzr46gzBzWVAysTv 9O/T6npehGjQ9qcgtQE1bz7AxwnW8mzYzHzHut5d/7M3tcwDRRgg+KDX3JSy292eRpS4 D/6M9TbIMJqTN8tqZ16B7MQQ8FkM7ZxEepQbi3+kEhW8OZDSgCB4HZxWnckMSZt3nX+h ye1dUu+rWQjiBJJd5irNjqYFJbk8oy5l89I7fSZr7j+dkCWd1fc1wKekdYYrTaMwYG+N CkfFaPnZNUcXOAexYqQP6fxehmN/wblg7fJLmm1es9tIt/q4+uuqBvx9vbSt2sW7/jxT vtig== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id s194si283606wme.2.2019.10.02.00.29.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Oct 2019 00:29:41 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x927Tf0R022903 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Oct 2019 09:29:41 +0200 Received: from [167.87.6.48] ([167.87.6.48]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x927Te6V005962; Wed, 2 Oct 2019 09:29:41 +0200 Subject: Re: [PATCH] dpkg-base: Warn about unmounting problems To: Baurzhan Ismagulov , isar-users@googlegroups.com References: <20191002071241.17792-1-ibr@radix50.net> From: Jan Kiszka Message-ID: Date: Wed, 2 Oct 2019 09:29:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191002071241.17792-1-ibr@radix50.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: MdLMPorNAfe3 On 02.10.19 09:12, Baurzhan Ismagulov wrote: > From: Baurzhan Ismagulov > > If a problem occurs, log umount's error messages and warn the user about > retrying. > > Signed-off-by: Baurzhan Ismagulov > --- > meta/classes/dpkg-base.bbclass | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 2e8a0d1..42eca62 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -1,5 +1,6 @@ > # This software is a part of ISAR. > # Copyright (C) 2017-2019 Siemens AG > +# Copyright (C) 2019 ilbers GmbH > # > # SPDX-License-Identifier: MIT > > @@ -78,8 +79,9 @@ dpkg_do_mounts() { > } > > dpkg_undo_mounts() { > - while ! sudo umount ${BUILDROOT} 2>/dev/null; do > - sleep 0.1 > + while ! sudo umount ${BUILDROOT}; do > + bbwarn "${BUILDROOT}: Couldn't unmount, retrying..." > + sleep 1 This needlessly extends the waiting time by using a course-grained delay. And let's only warn warn after a some seconds. Jan > done > sudo rmdir ${BUILDROOT} > } > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux