From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 23 Oct 2025 09:58:51 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-lj1-f192.google.com (mail-lj1-f192.google.com [209.85.208.192]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 59N7woc9025878 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 23 Oct 2025 09:58:50 +0200 Received: by mail-lj1-f192.google.com with SMTP id 38308e7fff4ca-36d99707249sf2254481fa.3 for ; Thu, 23 Oct 2025 00:58:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1761206325; cv=pass; d=google.com; s=arc-20240605; b=WmM1T9LODOpQwA0upvKCSldJHPjjyuSC2rr8Xai3fcXAuVQ7NUdkcrqooiD3zyD3Tg QAVeAf1qBoIeBGzaLV/cFD2e/aT9dp4fvr4zSufbon77wjMKUlvnUIH7OanjU2pZZy/r WWEPNEs0FNZQNFjctxKn3BnIeaQCb4aNBq2F0e7ihOFAakElSTdnOlsrw2g4ykAiL/OD YAFgWvz3YFIrBpdifM/CTBAFTGWh+CnxXqKsnqp0cJzvkaCUdcHcqfrvXMuXGbG8V1lo 5Xcd+O1UkSPdCaO88DMyCkGuVdofHbjF0PJTN/UwEbnaQR/8wMkPfiLRpJk4D+LZYW53 PTow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:dkim-signature; bh=V6J92E+8aHY36Cu93jwjw8bHl4esdJYuXxfA5ymbPkc=; fh=L0QeDJOfBhILUHDXXwGOyYc8ZQG3gxgeGYhWqo6U2/w=; b=kroILyn3J4Bfpoxxd/SzBf5TB7lnvoTFdFkzpGaOQhYqWSSuvxG3WneZH0i6UY6bQ4 JKVxFnY2+P23gweuIQ+8mSGSmghMe2gD7JHBg1vexaQFWPCg9NqjyudmQPM6wHcHc0/m i5gv9aDJFu4k4I3b6fmCnVVMthJSg5bY2U6Vpv2lkzRWGMB8qgVkK8iqML0w012uMaeG +LU4xzS8qArzqaBhQQhYvE4tTLk5ubMVDDeEesp5Mn3iWUDAUChcCQHzR2/ZxGnww6Pk sdyLa+lpacTzwN5YFW/6TqHHDsi1mQgYhn1G7O/NLa3y6Rb2SsT5e5obufvnZ8DJ3xoL WZYQ==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1761206325; x=1761811125; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:in-reply-to:from:content-language:references:cc :to:subject:user-agent:mime-version:date:message-id:sender:from:to :cc:subject:date:message-id:reply-to; bh=V6J92E+8aHY36Cu93jwjw8bHl4esdJYuXxfA5ymbPkc=; b=pPajzrVeVnd3aIXrYyEuFJl04LQSfKfmy5xZ4O6uJxKk3yYGmB4ZVdw6mqPf6mZawE 9R/idaKDzeB8m0MWzg6zRmSryPk5wLvCkVGj9OWTMRFtbuCASlOhnAEyfx8eoiG0bB4h pQkCaYphRJk+8YCoAFiq7KfzgyUb20ijDKuHOqPf7l+/tECZyN+4+RhHcf1JCs3yTzw6 cGu82SJAUFt+5XzGJGPWMj4OMJRAjAp3SdcYLTRrAgJsR6xiy5KhoyiiSpyw/83J+bDM clV7zhdWj59aScR7whNseJi+MnUP8WLmufhqodH+agjomp4fENQxRcvdWWk3tUHmCQvV q0hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761206325; x=1761811125; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:in-reply-to :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:x-beenthere:x-gm-message-state:sender :from:to:cc:subject:date:message-id:reply-to; bh=V6J92E+8aHY36Cu93jwjw8bHl4esdJYuXxfA5ymbPkc=; b=mj/K5sise/KnSh5p/GRJvL1vG++PBiKQ8qQsNpO7SFVPwvckNe+e4Ae9SZ/O/9ISx2 0GfHyiBruf/nuBDasdBPUpFADIj3DDG90n7sSxET31unk70JApBK7pd6+cc/KOiU0B7J ageyyZnv8FB8/yTjAzSrYqIPYsUhZMN33EJEwnNd4CF0QMJjlL245cjvEmORg6Sdn5eE R4qbjAvxI+ZpfOhy2BFwnu0Lt9XR/vYjlL/3v4yHeHNMGTbpig2zxBnBETspH3XITmgI Tkpltehi0jAN7FsBmEctJw0+Xk5WgSxa1pH/ZtCmKTKp8eSk6Uql0Sk5wDc12m9l77ct MbGQ== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCUpxrWlub6lBhEPaeo1gvZK2eduVA27ZndNT0l3t9raXR92oPuapAnkHov3Jsdgg4gWaRlT@ilbers.de X-Gm-Message-State: AOJu0YwtHS7VWvrxGpNLM9hDlNDGHpjBSqp7VHCb8jl2G5IlnwXjuqvG a6tOxDJnTa+sZnz9E+7dHlUCj7NF+OQoHgQEoT9sl7KU47xBMLgq9fIk X-Google-Smtp-Source: AGHT+IGs3Kcf8jOMaRo8dX1XteQMBhqyTxk7bHkcld9007O4SHi+pTN1Ghk9U4dY2f2qUPtPzeqMag== X-Received: by 2002:a2e:bc28:0:b0:372:945c:cdbd with SMTP id 38308e7fff4ca-377978f0fc3mr66151841fa.20.1761206324846; Thu, 23 Oct 2025 00:58:44 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com; h="ARHlJd4gctDuoSBhJo4z/U2jceLnNpy3BtyAziPxlSRMtmbOhQ==" Received: by 2002:a05:651c:4403:20b0:337:e84b:ec3 with SMTP id 38308e7fff4ca-378d6388390ls729251fa.0.-pod-prod-04-eu; Thu, 23 Oct 2025 00:58:42 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWvmaH53kzOpjD2VkNthSONcw92vfob2NnGRQjJGeb1sYayBJW042311wVbBrHpVd5Zp8RgRpIkkGgb@googlegroups.com X-Received: by 2002:a05:651c:1606:b0:372:932f:4656 with SMTP id 38308e7fff4ca-377979febdamr68459221fa.29.1761206321795; Thu, 23 Oct 2025 00:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1761206321; cv=none; d=google.com; s=arc-20240605; b=eJKKRHU6JZQffCEcmeLIK1mmx8g2W4tM4bGoG6XqmLZjjOOxVdPKHLz1h+2ZcTyrK9 FjDRouIxCwwYelT+YgI7xupWvmkuotekiVmoJ5i6L3RT/P1ixjIbfYHK3CGH+oB1BjwX wpp5qdRGniRDAdwUC0sgAmL1MS52bNNk+sbBxoJRIKuut3cf7ql5WQrnkqrAa8X81hJJ PnMZvvIjUdTSzVny15cGN70p3gNnHyv8M+g/Lgyzf3oVPbBUCnCtTPL3iXCUAk4+uczk nzeRQhHO5FzBa60W+XZRv+Wc0SdDpj0sL/P2LSm6zlZzfKedQV6JDVw8nHUOT0wNV4wH iemw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=kt133goHTptwgX76N05z+z66qshVcTIXXyUpZB0rMyk=; fh=LE9WgxipzerfD5x//RcV4JnJ0pM/psgS2IAdPSAJGEM=; b=Cc1wLCrpyLKdNAWDdpen3lBWjeCL865HIUm2Gtf1QyanTUXJJqavC4zuf/9vd1sIOl pVUUg+xJmtAx6yzuceEcLl7SJj7xbrbWwr66/nbMEd5zpT5cJ0U1X3QTnAA1PqlFfWlI w8GB4F3a/fWnpISzgWTnFlWUDG05/vNaKMVyaTCjXK9OO7CYPpE3dZbG4CnE3jvDS6dj SqnnXnIkTmw7qvEa01nfANgFPYkSQozxnWd1kdSaZ7pXoQ35QuNLEvfAwLZ3zrUKTC3g HuC2leAJgVRoWqZDbwtHb519H4cn/YMdqT0BX9FAyMzKhlbqYWVMSK9h/lENMjIb//Do mf4Q==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 38308e7fff4ca-378d67da1d1si185771fa.8.2025.10.23.00.58.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Oct 2025 00:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [192.168.178.117] ([88.130.203.42]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 59N7we1c025866 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Oct 2025 09:58:40 +0200 Message-ID: Date: Thu, 23 Oct 2025 09:58:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] image: Fix construction of do_image_tools dependencies To: Jan Kiszka , isar-users , Anton Mikanovich Cc: Felix Moessbauer , Quirin Gylstorff , "Schmidt, Adriaan" References: <0f16240d-aca7-4f03-b0f7-1567c5b4c26f@siemens.com> Content-Language: en-US From: Zhihang Wei In-Reply-To: <0f16240d-aca7-4f03-b0f7-1567c5b4c26f@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: wzh@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of wzh@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=wzh@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: wHPeyf5LCc5f Applied to next, thanks. Best regards, Zhihang On 10/16/25 20:51, 'Jan Kiszka' via isar-users wrote: > From: Jan Kiszka > > The attempt to translate IMAGER_BUILD_DEPS into do_image_tools[depends] > via an anonymous python functions failed because of an ordering issue > between the anonymous functions in image-tools-extension.bbclass and > image.bbclass. The latter was expanding IMAGER_BUILD_DEPS: > after image-tools-extension translated this variable into > do_image_tools[depends]. Resolve this by using an inline function for > the latter step. > > Signed-off-by: Jan Kiszka > --- > > Too bad that none of the isar tests detected it, only isar-cip-core > after updating its isar revision far enough. Looks like we have no self- > built packages for IMAGER_BUILD_DEPS here. > > meta/classes/image-tools-extension.bbclass | 8 +++----- > meta/classes/image.bbclass | 2 +- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/meta/classes/image-tools-extension.bbclass b/meta/classes/image-tools-extension.bbclass > index 5e248f2e..3f284b39 100644 > --- a/meta/classes/image-tools-extension.bbclass > +++ b/meta/classes/image-tools-extension.bbclass > @@ -1,5 +1,5 @@ > # This software is a part of ISAR. > -# Copyright (C) Siemens AG, 2019-2024 > +# Copyright (C) Siemens AG, 2019-2025 > # > # SPDX-License-Identifier: MIT > # > @@ -10,10 +10,8 @@ inherit sbuild > IMAGER_INSTALL ??= "" > IMAGER_BUILD_DEPS ??= "" > > -python() { > - for dep in d.getVar('IMAGER_BUILD_DEPS').split(): > - d.appendVarFlag('do_image_tools', 'depends', ' ' + dep + ':do_deploy_deb') > -} > +do_image_tools[depends] += " \ > + ${@' '.join(dep + ':do_deploy_deb' for dep in d.getVar('IMAGER_BUILD_DEPS').split())}" > > SCHROOT_MOUNTS = "${WORKDIR}:${PP_WORK} ${IMAGE_ROOTFS}:${PP_ROOTFS} ${DEPLOY_DIR_IMAGE}:${PP_DEPLOY}" > SCHROOT_MOUNTS += "${REPO_ISAR_DIR}/${DISTRO}:/isar-apt" > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index bd1b8552..441ea936 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -373,7 +373,7 @@ python do_image_tools() { > addtask image_tools before do_build after do_rootfs > > # all imagetypes are depend on schroot and isar-apt > -do_image_tools[depends] = "${SCHROOT_DEP} isar-apt:do_cache_config" > +do_image_tools[depends] += "${SCHROOT_DEP} isar-apt:do_cache_config" > do_image_tools[deptask] = "do_deploy_deb" > > python do_image() { -- You received this message because you are subscribed to the Google Groups "isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/bbbe0806-40cb-44e7-8c65-223f33ba11dd%40ilbers.de.