From: Uladzimir Bely <ubely@ilbers.de>
To: isar-users@googlegroups.com
Subject: Re: [PATCH] expand-on-first-boot: Fix "label: gpt" detection
Date: Mon, 03 Jun 2024 09:38:18 +0300 [thread overview]
Message-ID: <bbe1dfd871f8d3f430532074abace1455766051f.camel@ilbers.de> (raw)
In-Reply-To: <20240529120924.14501-1-ubely@ilbers.de>
On Wed, 2024-05-29 at 15:09 +0300, Uladzimir Bely wrote:
> Commit 991d2e9 introduced the issue when the whole script early exits
> (due to "set -x") in case grep doesn't find the pattern and produces
> an error code.
>
> In this case last partition remains non-expanded.
>
> Fix this by masking error with "echo 0".
>
> Signed-off-by: Uladzimir Bely <ubely@ilbers.de>
> ---
> .../expand-on-first-boot/files/expand-last-partition.sh | 2
> +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/expand-on-first-boot/files/expand-
> last-partition.sh b/meta/recipes-support/expand-on-first-
> boot/files/expand-last-partition.sh
> index 0cb2ee21..8ab0f8f0 100755
> --- a/meta/recipes-support/expand-on-first-boot/files/expand-last-
> partition.sh
> +++ b/meta/recipes-support/expand-on-first-boot/files/expand-last-
> partition.sh
> @@ -41,7 +41,7 @@ if [ "$DISK_SIZE" -lt "$MINIMAL_SIZE" ]; then
> exit 0
> fi
>
> -IS_GPT="$(sfdisk -d "${BOOT_DEV}" 2>/dev/null | grep -q "label: gpt"
> && echo 1)"
> +IS_GPT="$(sfdisk -d "${BOOT_DEV}" 2>/dev/null | grep -q "label: gpt"
> && echo 1 || echo 0)"
> if [ "$IS_GPT" = "1" ]; then
> dd if="${BOOT_DEV}" of=/dev/shm/__mbr__.bak count=1
> fi
> --
> 2.44.1
>
Applied to next.
--
Best regards,
Uladzimir.
prev parent reply other threads:[~2024-06-03 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 12:09 Uladzimir Bely
2024-06-03 6:38 ` Uladzimir Bely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbe1dfd871f8d3f430532074abace1455766051f.camel@ilbers.de \
--to=ubely@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox