From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6795913180323250176 X-Received: by 2002:a5d:474b:: with SMTP id o11mr52034094wrs.255.1582309737641; Fri, 21 Feb 2020 10:28:57 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:6385:: with SMTP id x127ls1489298wmb.2.gmail; Fri, 21 Feb 2020 10:28:56 -0800 (PST) X-Google-Smtp-Source: APXvYqzlJcsGeCCyfcZi9k2p/mJUBkD8cvA+LVKh+1TI/GmFlWzDP8l2OD4jNmQ4FG8izBCkI/4d X-Received: by 2002:a1c:dc85:: with SMTP id t127mr5571236wmg.16.1582309736903; Fri, 21 Feb 2020 10:28:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582309736; cv=none; d=google.com; s=arc-20160816; b=g8gYX8K9WxkqLYBeoUBt1XkHiOdIQ9nw7AcIU1IoJ87TfBcxSt68NzPcz4A3pZhLo5 l6K6BFDXTFWdM/XsPpbYboLwvwOKdD+hI8nz056EaoFAA3396h2LKBmkQ2dDAayxBeNe Uz+lfO7wR0IgeSU4OPZ0g8UWyoP2UAZ4FBojRxpIPFZzy+iCr3EW+HzBQ+PewjiBmXMW /10v8vv3MeKbOz+hao5yvD1LtmZy883IEX7+OKFkQWDTTxx6Zy5byxdJZmjQkHCZ9/jn Y7hwQeB6QFr9lUJhm+Q1YUFvN7JYxb7dijh3kL6AZ1vynJg73bZ0QYQyH+nSOSbi6Y7p PLvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=9aVVfevR63uQHAFvKQ9x+aJYJocrxWJLneX1wDdM+Bs=; b=OXca4jL7/vYdJHBzqStSoZyDsrTcPlLMjpr6tezbK8ilsoFNzeOqi0IgMonN46e/d6 qmroyrP/dehiUox10J+gyDkENk6OuT4PS9krFwjkOj+wPoWY+Nf9MZLs8a+JVAfqzdXr xf+22+oDJSywmObmXAPs5ONiO1caHwe9cqouK3JEuMNbhaYn81lfyCbyAD4LVIuuJ5ve Oen7vvqWrhyAdK13ZJ1WSa6xvFuHU+VHKoxKwi8FO7ene3vKMikGivtDy+JD5I/1zypW pXecdzdE+ld6TwaSzP3+r2AiJyqtjgWDNT9nCHW4OD46isKU4RpWM/GALLyqVTsDTo/Y WtWg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id y185si293362wmg.0.2020.02.21.10.28.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Feb 2020 10:28:56 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id 01LISu4U027002 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 21 Feb 2020 19:28:56 +0100 Received: from [139.25.68.37] ([139.25.68.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 01LIStWG014218; Fri, 21 Feb 2020 19:28:55 +0100 Subject: Re: [RFC 1/2] meta/classes: Add remove packages to rootfs postprocessing To: "Q. Gylstorff" , isar-users@googlegroups.com, henning.schild@siemens.com References: <20200221145348.24250-1-Quirin.Gylstorff@siemens.com> <20200221145348.24250-2-Quirin.Gylstorff@siemens.com> From: Jan Kiszka Message-ID: Date: Fri, 21 Feb 2020 19:28:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200221145348.24250-2-Quirin.Gylstorff@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: ys0YzUMZTEae On 21.02.20 15:53, Q. Gylstorff wrote: > From: Quirin Gylstorff > > Remove non-essential packages to reduce the amount of packages > to be cleared. It can also to used to reduce the foot print > of a image. Lacks documentation: This does not remove non-essential packages by itself. It provides a configuration channel (ROOTFS_PACKAGES_FORCE_REMOVE) to request arbitrary package removals. That should be clearly described, along with the warning about this weapon (expert tool). Do you also have a set of removal candidates to share with users? > > Signed-off-by: Quirin Gylstorff > --- > meta/classes/image.bbclass | 2 +- > meta/classes/rootfs.bbclass | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 6bcc6cd..62d6f46 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -60,7 +60,7 @@ image_do_mounts() { > } > > ROOTFSDIR = "${IMAGE_ROOTFS}" > -ROOTFS_FEATURES += "copy-package-cache clean-package-cache finalize-rootfs generate-manifest" > +ROOTFS_FEATURES += "copy-package-cache clean-package-cache finalize-rootfs generate-manifest remove_packages" > ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}" > ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" > > diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass > index 64eaef7..0329f55 100644 > --- a/meta/classes/rootfs.bbclass > +++ b/meta/classes/rootfs.bbclass > @@ -187,6 +187,19 @@ rootfs_postprocess_clean_package_cache() { > /usr/bin/apt-get clean > sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"* > } > +ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'remove_packages', 'rootfs_rm_packages', '', d)}" > +rootfs_rm_packages () { > + if [ -n "${ROOTFS_PACKAGES_FORCE_REMOVE}" ]; then > + RMPKGS=$(sudo -E chroot "${ROOTFSDIR}" \ > + dpkg-query \ > + -f '${Package}\n' \ > + -W ${ROOTFS_PACKAGES_FORCE_REMOVE} 2>/dev/null || true) > + fi > + if [ -n "${RMPKGS}" ]; then > + sudo -E chroot "${ROOTFSDIR}" \ > + dpkg --purge --force-depends ${RMPKGS} > + fi > +} > > ROOTFS_POSTPROCESS_COMMAND += "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', 'rootfs_generate_manifest', '', d)}" > rootfs_generate_manifest () { > Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux