From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7345378448314990592 X-Forwarded-Encrypted: i=2; AJvYcCXyW9znyusHLHVlH4FCzYsgMFRR1af52+rO+MTkpuNp1RPP1HN5ftykNwHXzXdDzuKIWq4SPsog3keRcE4aajKDarDhVrmksGG+POo= X-Received: by 2002:a2e:b98b:0:b0:2d6:a1f7:2a12 with SMTP id p11-20020a2eb98b000000b002d6a1f72a12mr440845ljp.38.1711483278599; Tue, 26 Mar 2024 13:01:18 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:7019:0:b0:2d4:9683:bb0b with SMTP id l25-20020a2e7019000000b002d49683bb0bls355950ljc.0.-pod-prod-04-eu; Tue, 26 Mar 2024 13:01:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWyU2LGL10EYwcxD11QzZbwgcNjFUrgAOGnjOVx6xEWRT+GoilYZ4qf6ua7nCm2N7mBFZBcxt8UUU9TdzWZStvfHffrHkWNST2gA94= X-Google-Smtp-Source: AGHT+IH/WcCb4TbdcJS9p4HickUfm38WofpJVlC+DDNWNmfCsXahDA22sECMSlTcOy5NquJlH82S X-Received: by 2002:a2e:b536:0:b0:2d6:acb7:9349 with SMTP id z22-20020a2eb536000000b002d6acb79349mr463068ljm.7.1711483275737; Tue, 26 Mar 2024 13:01:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711483275; cv=none; d=google.com; s=arc-20160816; b=zdYhHcJDw6Wp465QzDZL260KzsHxhBkaYK52y1V3TMVSmwDb/YalOFRhZQ7qey3RY9 X0EDlry1WUXBcfopdhmkjVUNQJrD1i3LixlV9QITeFah2Mk2cQRVR3aon5j5s1xzIXKQ fy7N0M831te9IIC6Mr203qeNr+NXLlNtnQAOU9K2gRrF0CPDJgsvsKlV6j8o9IF1kTBs Vxj9t1OsCoKPY/ZHSdsNUoSkMcAk47uCfgtTLWgwnNRIsJkpFqcGvr8MGdSuru4fmnX5 j5bI1C5FH/xg8NVK0dfX+e66i9QZBPgLPeydsbZ+JW+ICu6a06pgVcDu7PYzMGhuwRde IwDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=Z2GkuzoU3npC27MgFba3ZLkQ4Mukjtc3Hs1n42idGVo=; fh=1x/T85rXr8yhgzXWAa7zssXnuyt2jGlhJYPIGFWr6UE=; b=bXdDyu+ykxB/AyI2sYHxsHtTaWkjdDY9mRvp5dWwCssTzjijKMcg+b0gKO31eRf+Tp iqZ0Vr9KjIjCEjqpAuLsTk3shzpBkj8V/RKQO7COFcr6uJymnSC9tNmp/z9xNMJKXboY DfRffRnPeisxt5crBg0CQUJDtzwveEn8SgKFAwYi9yj7hfsty97RJH5Va6Tm09TIbRfB P6UEVxB9HXG46fU3q5++yftAckV/neDOfOTsYpaXmGtYMl8tmYW5NBX9Stc0ZrPyS4B9 pw3mCT+ZQJWgohTedzbwVoolsu7cfZrQm6iUsm7vKjOSzlqUIgQbX60vFFFSEJJmOoJT oDDQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id s13-20020a2e81cd000000b002d2a204e243si413859ljg.3.2024.03.26.13.01.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2024 13:01:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 42QK1CfD019212 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 21:01:14 +0100 Message-ID: Subject: Re: [PATCH] image: limit search for *.core to regular files From: Uladzimir Bely To: Cedric Hombourger , isar-users@googlegroups.com Date: Tue, 26 Mar 2024 23:01:12 +0300 In-Reply-To: <20240312073935.331457-1-cedric.hombourger@siemens.com> References: <20240312073935.331457-1-cedric.hombourger@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: 6XsuHuzh18Uu On Tue, 2024-03-12 at 08:39 +0100, 'Cedric Hombourger' via isar-users wrote: > Code to search and delete core dumps in the build tree assumes that > the build host has a kernel.core_pattern setting which would result > in core dumps having a .core file suffix: this is not guaranteed. One > may also argue that the build should have failed if a process > executed > under qemu-user got to crash (and we should check why qemu has > crashed > and fix it). My vote would be to kill that code but for now, make it > less wrong by restricting the search to regular files suffixed with > .core (this would at least stop isar from moving directories such as > "org.eclipse.equinox.p2.core" out of the image). >=20 > Signed-off-by: Cedric Hombourger > --- > =C2=A0meta/classes/image.bbclass | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index 73f1d52c..793c21a2 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -457,7 +457,7 @@ EOSUDO > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 # Sometimes qemu-user-static generates coredumps= in chroot, move > them > =C2=A0=C2=A0=C2=A0=C2=A0 # to work temporary directory and inform user ab= out it. > -=C2=A0=C2=A0=C2=A0 for f in $(sudo find ${ROOTFSDIR} -name *.core); do > +=C2=A0=C2=A0=C2=A0 for f in $(sudo find ${ROOTFSDIR} -type f -name *.cor= e); do > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sudo mv "${f}" "${WORKDI= R}/temp/" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bbwarn "found core dump = in rootfs, check it in > ${WORKDIR}/temp/${f##*/}" > =C2=A0=C2=A0=C2=A0=C2=A0 done > --=20 > 2.39.2 >=20 Applied to next, thanks.