Re: [RFC v1 2/3] Refactor gpg code to use apt code

[cedric_hombourger@mentor.com]

[-- Attachment #1.1: Type: text/plain, Size: 1030 bytes --]


>
> diff --git a/meta/classes/isar-bootstrap-helper.bbclass 
> b/meta/classes/isar-bootstrap-helper.bbclass 
> index d780b85..df6fbee 100644 
> --- a/meta/classes/isar-bootstrap-helper.bbclass 
> +++ b/meta/classes/isar-bootstrap-helper.bbclass 
> @@ -119,6 +119,14 @@ setup_root_file_system() { 
>      export LANG=C 
>      export LANGUAGE=C 
>      export LC_ALL=C 
> + 
> +    if [ -d ${TMPDIR}/aptkeys ]; then 
> +        for keyfile in ${TMPDIR}/aptkeys/* 
> +        do 
> +            cp $keyfile "$ROOTFSDIR"/tmp/$(basename $keyfile) 
>

I have seen repos name their key debian.gpg or some other generic name
I am concerned that we may get repositories using the same key names and 
only the last key would be added
Should we do something like:

tmpkey=$(mktemp -p  "$ROOTFSDIR"/tmp)
cp $keyfile $tmpkey
sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-key add /tmp/$(basename $tmpkey)
rm -f   $tmpkey

+            sudo -E chroot "$ROOTFSDIR" /usr/bin/apt-key add 
> /tmp/$(basename $keyfile) 
> +        done 
> +    fi 
>


>

[-- Attachment #1.2: Type: text/html, Size: 1694 bytes --]