From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6654500580778573824 X-Received: by 2002:a1c:7d03:: with SMTP id y3mr208427wmc.8.1549445274147; Wed, 06 Feb 2019 01:27:54 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:b706:: with SMTP id h6ls199335wmf.2.gmail; Wed, 06 Feb 2019 01:27:53 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib1zVPwFMbpYLwh6f+fX/Gr+yAzi+xBWCsf5zFuYlDA11gJ7khxMc5zD0EPQIlQWCfszvQd X-Received: by 2002:a1c:e703:: with SMTP id e3mr218141wmh.1.1549445273741; Wed, 06 Feb 2019 01:27:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549445273; cv=none; d=google.com; s=arc-20160816; b=K1IxfX4fPeWEUGozWs/REIXl9HUpRlE7u4iSlAImhoBifQq45MJp8ZeQiTh89E39DR FxRENieLYTdYjtqOsHYH8eNQYw2mvGkf0g//68QbcnmujeypJWBItIJsMLshmKNKo1U5 CzcK+3XCvHbtfNgzofQOFYUgkkkQKvFcVAQwoXibD26oCEhXCWbTR1rkYsUr7C0MVTAu fv+UuLiN81Z7Fo8r9ECIKoRGD5VJE/HmKR5HZ0/Qu33ZRGyjv8eMN176HKvKDIdpfIfX 3Qcy8QkqfZfsfXnxZtg0AiBnsd9Y74aQ79R6wLhBdlNCVuo8IHbLpof7qn1lRm2MuBe0 ULlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id; bh=8Y2hE+HnCdervFW6y3am7uE/UiSRzGoUu5ZI1txGV+Q=; b=ytCeho30dgLhR2NPlmEpHSlGp7jpCsyR5StCDcOm/IWtwWbx6f6Xj1FdC6qVlyGlww 6XWJM0O3+VZv17PJwgssf4x95AlEsWzObaqoy/0usrxTZjAxNh3a1ic38obe4zoSbjSi v9TvinAcLwZCcMCAlQZYWMhUSThVpIbq4ZJROFbDt3U7VAYJruym2ZqGqSuOdqCweVyj 19RNHq45esfhdGMhVNraJdNb0hww19jidSmaYZKojBuLYbDORB5r6wMvAQeJ4al6YriK m0vGk6/fJl8C1w3cR7v1h+XkfV+b3nlNp2FptEmvdKi1GDYR/mObpT5exl5/zKcfQANe 8Xug== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.10]) by gmr-mx.google.com with ESMTPS id s124si699078wmf.0.2019.02.06.01.27.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 01:27:53 -0800 (PST) Received-SPF: neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of hws@denx.de) client-ip=212.18.0.10; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.10 is neither permitted nor denied by best guess record for domain of hws@denx.de) smtp.mailfrom=hws@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43vbhT42bBz1r3jX; Wed, 6 Feb 2019 10:27:53 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43vbhT3r35z1r2Gw; Wed, 6 Feb 2019 10:27:53 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id fAENpAaCHZXF; Wed, 6 Feb 2019 10:27:52 +0100 (CET) X-Auth-Info: Lqdw0wkr9akN+nrBWMzZPn96i9hAZN5y5K836a3qyVs= Received: from elite.denx.de (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 6 Feb 2019 10:27:52 +0100 (CET) Message-ID: Subject: Re: [PATCH 1/2] Fix all shell-script expansions From: Harald Seiler To: Claudius Heine , isar-users@googlegroups.com Date: Wed, 06 Feb 2019 10:27:51 +0100 In-Reply-To: <639d7105-ec7f-d004-ffb3-2514eddb643b@siemens.com> References: <20190205130004.15200-1-hws@denx.de> <20190205130004.15200-2-hws@denx.de> <639d7105-ec7f-d004-ffb3-2514eddb643b@siemens.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.4 (3.30.4-1.fc29) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUID: ro5GWN4U7cxe Hi Claudius, On Wed, 2019-02-06 at 08:49 +0100, Claudius Heine wrote: > Hi Harald, > > > On 05/02/2019 14.00, Harald Seiler wrote: > > Expansions behave weirdly if paths contain special characters. > > This commit fixes expansions in all applicable shell-scripts. > > > > Signed-off-by: Harald Seiler > > --- > > isar-init-build-env | 6 ++-- > > meta-isar/conf/distro/raspbian-configscript.sh | 2 +- > > .../isar-bootstrap/files/chroot-setup.sh | 8 ++--- > > meta/recipes-devtools/buildchroot/files/common.sh | 2 +- > > meta/recipes-kernel/linux/files/build-kernel.sh | 36 +++++++++++----------- > > .../enable-fsck/files/enable-fsck.sh | 4 +-- > > .../files/expand-last-partition.sh | 16 +++++----- > > scripts/ci_build.sh | 14 ++++----- > > scripts/mount_chroot.sh | 12 ++++---- > > scripts/rpm2cpio.sh | 4 +-- > > 10 files changed, 52 insertions(+), 52 deletions(-) > > Great idea! > > I think you used shellcheck to find most of those issues. I think you > forgot one: > > In ./meta/recipes-kernel/linux-module/files/debian/postinst line 2: > depmod -a $(ls /lib/modules) > ^-- SC2046: Quote this to prevent word splitting. > > Maybe while you are at it, you could fix this one as well ;) Ah, I see ... I only checked files ending in .sh so I missed all postinst files ... I think I'll send another patchset for fixes in those + shell-scripts in recipes. > Thanks, > Claudius > -- Harald DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-62 Fax: +49-8142-66989-80 Email: hws@denx.de