From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6917993065941565440 X-Received: by 2002:a17:906:2681:: with SMTP id t1mr17166266ejc.29.1610973356277; Mon, 18 Jan 2021 04:35:56 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:d115:: with SMTP id b21ls5566897ejz.11.gmail; Mon, 18 Jan 2021 04:35:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZuA0wdE8kiNGwJ7kjD0eBUuiwy3E/ZRq+73PrNc7aqrgbedh849G6Pk0Oak5HurkCMvE/ X-Received: by 2002:a17:906:e28a:: with SMTP id gg10mr16999611ejb.11.1610973355277; Mon, 18 Jan 2021 04:35:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610973355; cv=none; d=google.com; s=arc-20160816; b=Xy6YB3Ng/wQHQ7rjIuX8SWCRg8yI2RlLW6DV0qwkov5Jx/gVtPm/LLty1BlVhmSxdb Q1KaO4ZmH4oJtP5eOEscB29WI713bF5swOWKV7Zdn3nNNkIc2x8UsGIY7LVyoZMIgyox U+ruw1AVHZ+YHFZUJ3kg+eISCvijZjB/8EFyLtBaFm8LvKLLvYIV3trtphgSxr1djTZR Oyqg8odf5Zxifwn+KqSUd+tncWzFP65xYoULPHqx38uaPRFDs0CALP7oQIkshSY6lWJp PaA6u8ylIFHW+EdsqgOW3k+f1ZsFJkwwpdPLrSBB08Y8IqEeQIOcyFzISrGgv6CMNq+J TlkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=ONh4ydLXsW/kCo1ua7UDiONsPyxqA5bSIUL/3LM/cpU=; b=wTzhP4hfCanDEAw1dgkcmZTfwNwn2Ql4toXl0Hgp4SS7kmOCFNhxSsLMEQnhtPRn3J rZuemAUQez8a0Dwv82Hy1TZZWWa1MYhzmU/qeQ3dchCtA4QzsEJv+bqitoEjxYGWduNo iGknEWx+HdLP/8ZSFpkRT2xUhLsqA+iSgctcl0rlxANp3IcMz+BPShMWaSvRrQaXbdIW qg+SCF4y6avB8oB55epe96FDzwfROl4y32oNH+x+d+TyYC61C/DRGddVHSsGxEyoclyI vA0EnfHqRUXawtobpnPyLjAgityQV532D2tonwbbjKrKMfwmjhkos9q9XsCwGEhBudGo UvAQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [212.18.0.9]) by gmr-mx.google.com with ESMTPS id m5si211550edr.1.2021.01.18.04.35.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jan 2021 04:35:55 -0800 (PST) Received-SPF: neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) client-ip=212.18.0.9; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 212.18.0.9 is neither permitted nor denied by best guess record for domain of ch@denx.de) smtp.mailfrom=ch@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DKB8q0sZ7z1qskV; Mon, 18 Jan 2021 13:35:55 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DKB8q0dwBz1tSQ8; Mon, 18 Jan 2021 13:35:55 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id W9vOZ6YiItuK; Mon, 18 Jan 2021 13:35:54 +0100 (CET) X-Auth-Info: dgPgo2rULJYgoGADf4bJJBjCO/WUPFZG/5xjFzu2XxA= Received: from [10.88.0.186] (dslb-002-207-026-175.002.207.pools.vodafone-ip.de [2.207.26.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 18 Jan 2021 13:35:54 +0100 (CET) Subject: Re: image-postproc-extension.bbclass modifying /etc/os-release To: Silvano Cirujano Cuesta , isar-users@googlegroups.com References: <67e1fac9-5af5-29aa-de57-9a0de0cdd165@siemens.com> <79cdea42-8338-2e7f-33dd-f396db634a14@siemens.com> From: Claudius Heine Organization: Denx Software Engineering Message-ID: Date: Mon, 18 Jan 2021 13:35:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <79cdea42-8338-2e7f-33dd-f396db634a14@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: pcOBZAhgcvDX Hi Silvano, On 2021-01-18 12:35, Silvano Cirujano Cuesta wrote: > I might try to provide a fix, if we agree that the current implementation has an issue. > > @Claudius: you wrote the original code [1]. Do you remember why you implemented it this way? Do you remember if you were aware of the issue I mentioned and you provided a mitigation for the issue that I see (assuming my analysis is right)? > > [1] https://github.com/ilbers/isar/commit/13ce96e5bc84b60f2fa7ccfe93dde045461884e6 > >   Silvano > > On 15/01/2021 15:26, [ext] Silvano Cirujano Cuesta wrote: >> Hi, >> >> I've noticed that '/etc/os-release' is being changed on the image in meta/classes/image-postproc-extension.bbclass [1].  What BTW ends up changing '/usr/lib/os-release', since it's only a symlink. But both '/etc/os-release' and '/usr/lib/os-release' are owned by 'base-files'... >> >> An upgrade of 'base-files' would be replacing (silently, since is not marked as a configuration file) '/usr/lib/os-release' with the version of the upstream 'base-files' package and possibly breaking any tools in the system relying on certain values in that file. >> >> Is there a reason that I'm missing for doing so instead of the Debian-way (file diversion with dpkg-divert)? Or any hack that I've overseen that avoids the mentioned breakage? Interesting, I didn't remember that `/etc/os-release` is a symlink, could that be something that has changed in more recent debian versions? If so then, of course that needs to be fixed. regards, Claudius