From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shymkent.ilbers.de ([unix socket]) by shymkent (Cyrus 2.5.10-Debian-2.5.10-3+deb9u2) with LMTPA; Thu, 24 Oct 2024 12:41:53 +0200 X-Sieve: CMU Sieve 2.4 Received: from mail-wr1-f63.google.com (mail-wr1-f63.google.com [209.85.221.63]) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPS id 49OAfmxL017998 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 24 Oct 2024 12:41:49 +0200 Received: by mail-wr1-f63.google.com with SMTP id ffacd0b85a97d-37d563a1af4sf372100f8f.2 for ; Thu, 24 Oct 2024 03:41:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1729766503; cv=pass; d=google.com; s=arc-20240605; b=e90rfuubqKJko0qA5AxO4jg0KA2cn250PJB12+HSgBGvx5ENLiOhOCuPAMtlTcLeKe 1p6PzFqL5wv0motXcfQ4q/fMdjHghheVitVhMnR+wQAPdth540SVyRefIpQA+BvpAgL6 UMS4n68eF3l1VAb6yQJn8LJTtASdXlhQDW2pdfK/7RGR4i+BqrEWcKuGQ1a8LM67lR14 ynboDTdIPvQqP4A7S0KpInaiZGdOoPo3Uq7ntdoxM62b+/YcMlp3ZjwO/L55ClMSZswe 0a20RzFn/P1HhZ4+7YG5UzFXBc9FY2Cr9IHDMPzdPwkQ0O7Paxbcq64ZrvN+bpkDrruF Aplg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:sender:dkim-signature; bh=L7SX924h4YVHnOXHx18fxa22u2l5b0VaQugGUh7E9XM=; fh=znMqv9+deFbzaMf8KR5Euuiyj4tGIlt/3xtuBHNh4B8=; b=OdAX2mgUF5ldS7m7DzwFNkswbElJpFHd7TLReuOv8Pn0IG1H3pl76q6scNboOUFDOu /OKZEC4SmUJ1/JnPYo8bLDZ/wg9q7gk+fDVpTO+utriZWLCdU7uXmFFpYvSu7P/gOdMu kIDuXCMKJqSKz63wnJw3Muc31f7f0ittOa05G/6cc96A2cdbZ5H7QFWFCyPxaPv40kBB oR+GEq7QgFs3iF19NKUO0CogAAwFKwzgchC0KYVzvhT+jWsemTLD1O1LwbZT6hQVgEbc wi/RmhPa/+ccFZG1z/tASh09Ry7JSPCviMK+7b0cuaYYPS40TUGF6mJpGtDMnmnHGstG BqZw==; darn=ilbers.de ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1729766503; x=1730371303; darn=ilbers.de; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:user-agent:content-transfer-encoding :references:in-reply-to:date:to:from:subject:message-id:sender:from :to:cc:subject:date:message-id:reply-to; bh=L7SX924h4YVHnOXHx18fxa22u2l5b0VaQugGUh7E9XM=; b=vFcyinhA88YIBgqd18L8s15860XFr/h1GSWvB3COTNWbXEiu6wl63vix5OgBGGSEbR eLXvFv+LiT1fG1JKp1jgZoQahDGL/oHsbITSw7pH3ugZ+iHyt+4++almeHTMCot6bvW8 kTf7I5QLgPPVulH3bC6NkqBaecCC3bBB54Igl6w64gKfOMkVbHRtLm1t6dAuxazPhAIs NcykqjocApB44kI5aPMZYJmGJeYU5EVDhyu6NR0luJC6/rSYaYxjeLOGbIh/boyrcqdW wXZVG2hi5ypQebyUammtdvrWXwFSPxodck0S2sRibJNZH2dqNIzKc/fIxIsQZpUHYN0b Zf9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729766503; x=1730371303; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :user-agent:content-transfer-encoding:references:in-reply-to:date:to :from:subject:message-id:x-beenthere:x-gm-message-state:sender:from :to:cc:subject:date:message-id:reply-to; bh=L7SX924h4YVHnOXHx18fxa22u2l5b0VaQugGUh7E9XM=; b=Uf3Q2xZ3cjo4cdWNSsU4BvZ9tHd0nhPjM+cKqK562u54LY06KvuJxsYbqIlXlhjIr6 nF/b6qx5ZLpq6CKwYXQZfggwATtcVuIbAEl88yykGLFIJ0MNNdCEetOkF3/JIikLDk1j 2MCFy3lCq6mhGMpYsB767GVi7iZm0SBpuybj5Os/GF2AKunzjJemwQm9zBAaChA8GMNd 0DbVIkRn12SI9pKgfHwrBArfpWSSz3Z7aikCZa4PUidki3N0wrb85trqxLhd5Jsqi9R1 UqP5pqN5QZ2cofel0iJmpnioATv+iS4zS9863llxhxrAXX9m/X/jZ8D/F3+VIk8t1mTS FliA== Sender: isar-users@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVqNuPY6niYhWlikegTEyU2aIoRU1sxjlMqp/hP+SeOE6D8hQECRtb8uYkJUQKfkHxu2W5C@ilbers.de X-Gm-Message-State: AOJu0YyAFq+Qw7S0JkKZJHVjXIcwWinOTRkH6Rdb9zH0BQMep74oZ0F3 6MF/1MhzOJ7bn85r3ZWvvuVnLFXawJA39woF0zEExbpAaq15VZxx X-Google-Smtp-Source: AGHT+IGVVJQqYhkRFefmIOuiFVgLrGxnwFYwOC/c1ceACQzp8SnR+AsyWqzupCIHInvSdqZae6I3tw== X-Received: by 2002:adf:ea8b:0:b0:374:fa0a:773c with SMTP id ffacd0b85a97d-37efcf849d6mr3451434f8f.47.1729766502965; Thu, 24 Oct 2024 03:41:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6000:ccc:b0:37d:45ee:cb9e with SMTP id ffacd0b85a97d-37f598ebcb7ls322773f8f.2.-pod-prod-06-eu; Thu, 24 Oct 2024 03:41:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVS6cntIW5MZZhqkD28Stj+PGycRPv9/GzgxRSRL8hZV8FQwGqJm/mvhf9KlWEAIAGXn19WJEBbL942@googlegroups.com X-Received: by 2002:a5d:55c1:0:b0:374:bd48:fae9 with SMTP id ffacd0b85a97d-37efcf0b5e0mr3347875f8f.20.1729766500804; Thu, 24 Oct 2024 03:41:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1729766500; cv=none; d=google.com; s=arc-20240605; b=Gs9VbMJL/xfypp2LouOa5mUWa9Vi40BRCHGZ/CrCFPo4eZCII4Y6bQKDk4TDW7tk8n pPKW/PbHa2bvziMFbKC5sL0t37QI41LdMhQrPvXl8sUTpIcrcdpYLIKQ7UnxpTTIKLa3 s5ce9aIEQI61mxzfByfnQ1Gh1FbmmJkSbydOXn3DZsKcCSI1mD2+GIqmXf6LB3EENP5e zJlghQb68NDkHq5BQEHaajv/vv0uYYlswEpKyl3kX5QHNPgupZRaK5k/Ic0YwNCRFTnE jSIOCrze0TRGifYmMOdiJT+D+zr0A3yGRSF1PhicUPBuqHApVhQ2gTrJZAcBeIJVPMV3 TfKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id; bh=kdV/Slw6KHYpbS3cG4esXUqsKxOf/rgkABlkES1mZUo=; fh=JZvUnqoG0jWph92hWpw0EINycbLveqkIcdkusZDYok4=; b=YaQ2vIqC3tLt18WfAVk2wLjTKlho5JYMYY7HAhDz9WD7MG6OdL1Ysay/K7GATlyIfW t5vWWPmknlClBjmUzmJCxmhw4nBnlkbbNf1DbRaukLMdio4ITIMy1b6hdXEgoRfqNe3O DWiK3esLv3vnlZ6jUtuFxmLhigXA/yU+p/TuNGSulw7F3y2BiLAsl3IRAmC9Z0pkA+dw xnOUh0s1SSv57o+MUmimSfwzoXVFnlVgdruJS3fvoqEO3ZU1utJa4mpuFVcqht7cZYbB i3PIK78AiAPMjF65Bv1zt8HMK6nWyex+lI07XqvkMv7iAMijzuDyUkY8n89+Ej7v6yQA 73sQ==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-4317d03e705si1685155e9.0.2024.10.24.03.41.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Oct 2024 03:41:40 -0700 (PDT) Received-SPF: pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Received: from [127.0.0.1] (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8+deb9u1) with ESMTPSA id 49OAfba5017992 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Oct 2024 12:41:39 +0200 Message-ID: Subject: Re: [PATCH v2] deb-dl-dir: Avoid hanging mounts on failed download From: Uladzimir Bely To: Anton Mikanovich , isar-users@googlegroups.com Date: Thu, 24 Oct 2024 13:41:37 +0300 In-Reply-To: <20241024100946.214428-1-amikan@ilbers.de> References: <20241024100946.214428-1-amikan@ilbers.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.0 (by Flathub.org) MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_RP_CERTIFIED,RCVD_IN_RP_RNBL,RCVD_IN_RP_SAFE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-Original-Sender: ubely@ilbers.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of ubely@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=ubely@ilbers.de Precedence: list Mailing-list: list isar-users@googlegroups.com; contact isar-users+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: isar-users@googlegroups.com X-Google-Group-Id: 914930254986 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , X-TUID: 2P0SYCmBREiD On Thu, 2024-10-24 at 13:09 +0300, Anton Mikanovich wrote: > If apt-get fails during debsrc_download execution, one mount will be > left behind. If ISAR_FAIL_ON_CLEANUP is set to 1, an additional error > will be observed: >=20 > > Err:1 http://ftp.de.debian.org/debian=C2=A0bookworm/main rtmpdump > > 2.4+20151223.gitfa8646d.1-2 (dsc) > > =C2=A0 Could not connect to ftp.de.debian.org:80=C2=A0(141.76.2.4), > > connection timed out > > Err:2 http://ftp.de.debian.org/debian=C2=A0bookworm/main rtmpdump > > 2.4+20151223.gitfa8646d.1-2 (tar) > > =C2=A0 Unable to connect to ftp.de.debian.org:80: > > Err:3 http://ftp.de.debian.org/debian=C2=A0bookworm/main rtmpdump > > 2.4+20151223.gitfa8646d.1-2 (diff) > > =C2=A0 Unable to connect to ftp.de.debian.org:80: > > E: Failed to fetch > > http://ftp.de.debian.org/debian/pool/main/r/rtmpdump/rtmpdump_2.4%2b201= 51223.gitfa8646d.1-2.dsc > > =C2=A0 Could not connect to ftp.de.debian.org:80=C2=A0(141.76.2.4), > > connection timed out > > E: Failed to fetch > > http://ftp.de.debian.org/debian/pool/main/r/rtmpdump/rtmpdump_2.4%2b201= 51223.gitfa8646d.1.orig.tar.gz > > =C2=A0 Unable to connect to ftp.de.debian.org:80: > > E: Failed to fetch > > http://ftp.de.debian.org/debian/pool/main/r/rtmpdump/rtmpdump_2.4%2b201= 51223.gitfa8646d.1-2.debian.tar.xz > > =C2=A0 Unable to connect to ftp.de.debian.org:80: > > E: Failed to fetch some archives. > > WARNING: exit code 100 from a shell command. > > DEBUG: Executing shell function rootfs_do_umounts > > DEBUG: Shell function rootfs_do_umounts finished > > DEBUG: Python function do_rootfs_postprocess finished > NOTE: recipe isar-image-ci-1.0-r0: task do_rootfs_postprocess: Failed > NOTE: Tasks Summary: Attempted 699 tasks of which 391 didn't need to > be rerun and 1 failed. > ERROR: build/tmp/work/debian-bookworm-armhf/isar-image-ci- > qemuarm/1.0-r0/rootfs/deb-src left mounted >=20 > Protect mounting with a trap for cleanup in case of failure. >=20 > Signed-off-by: Anton Mikanovich > --- > =C2=A0meta/classes/deb-dl-dir.bbclass | 3 +++ > =C2=A01 file changed, 3 insertions(+) >=20 > diff --git a/meta/classes/deb-dl-dir.bbclass b/meta/classes/deb-dl- > dir.bbclass > index 55e56c50..7ebd057e 100644 > --- a/meta/classes/deb-dl-dir.bbclass > +++ b/meta/classes/deb-dl-dir.bbclass > @@ -48,6 +48,9 @@ debsrc_download() { > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 debsrc_do_mounts "${rootfs}" > =C2=A0 > +=C2=A0=C2=A0=C2=A0 trap 'exit 1' INT HUP QUIT TERM ALRM USR1 > +=C2=A0=C2=A0=C2=A0 trap 'debsrc_undo_mounts "${rootfs}"' EXIT > + > =C2=A0=C2=A0=C2=A0=C2=A0 ( flock 9 > =C2=A0=C2=A0=C2=A0=C2=A0 set -e > =C2=A0=C2=A0=C2=A0=C2=A0 printenv | grep -q BB_VERBOSE_LOGS && set -x > --=20 > 2.34.1 >=20 Since patch v2 is technically a v1 with updated commit message, already well-tested in CI, we would like to merge it soon (e.g. 2024-10-25), if there are no objections. --=20 Best regards, Uladzimir. --=20 You received this message because you are subscribed to the Google Groups "= isar-users" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to isar-users+unsubscribe@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/isar-users/= bcfcb58316941bc9e6f26fca824044c9042bdb69.camel%40ilbers.de.