* [PATCH] meta/classes/initramfs: remove unused variable
@ 2024-05-09 10:59 srinuvasan.a
2024-05-21 7:19 ` Srinuvasan Arjunan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: srinuvasan.a @ 2024-05-09 10:59 UTC (permalink / raw)
To: isar-users; +Cc: jan.kiszka, Srinuvasan A
From: Srinuvasan A <srinuvasan.a@siemens.com>
The variable INITRAMFS_IMAGE_FILE is nowhere used across
the repository, hence remove the unused variable.
Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
meta/classes/initramfs.bbclass | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
index 5b5943f2..6886b95a 100644
--- a/meta/classes/initramfs.bbclass
+++ b/meta/classes/initramfs.bbclass
@@ -14,7 +14,6 @@ INITRAMFS_INSTALL ?= ""
INITRAMFS_PREINSTALL ?= ""
INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
-INITRAMFS_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}"
# Install proper kernel
INITRAMFS_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME")) if d.getVar("KERNEL_NAME") else ""}"
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meta/classes/initramfs: remove unused variable
2024-05-09 10:59 [PATCH] meta/classes/initramfs: remove unused variable srinuvasan.a
@ 2024-05-21 7:19 ` Srinuvasan Arjunan
2024-05-21 8:32 ` Jan Kiszka
2024-05-28 6:02 ` Uladzimir Bely
2 siblings, 0 replies; 4+ messages in thread
From: Srinuvasan Arjunan @ 2024-05-21 7:19 UTC (permalink / raw)
To: isar-users
[-- Attachment #1.1: Type: text/plain, Size: 50 bytes --]
Hi All,
Any Update?
Thanks,
Srinu.
[-- Attachment #1.2: Type: text/html, Size: 133 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meta/classes/initramfs: remove unused variable
2024-05-09 10:59 [PATCH] meta/classes/initramfs: remove unused variable srinuvasan.a
2024-05-21 7:19 ` Srinuvasan Arjunan
@ 2024-05-21 8:32 ` Jan Kiszka
2024-05-28 6:02 ` Uladzimir Bely
2 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2024-05-21 8:32 UTC (permalink / raw)
To: srinuvasan.a, isar-users, Moessbauer, Felix (T CED SES-DE)
On 09.05.24 12:59, srinuvasan.a@siemens.com wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> The variable INITRAMFS_IMAGE_FILE is nowhere used across
> the repository, hence remove the unused variable.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
> meta/classes/initramfs.bbclass | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
> index 5b5943f2..6886b95a 100644
> --- a/meta/classes/initramfs.bbclass
> +++ b/meta/classes/initramfs.bbclass
> @@ -14,7 +14,6 @@ INITRAMFS_INSTALL ?= ""
> INITRAMFS_PREINSTALL ?= ""
> INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
> INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
> -INITRAMFS_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}"
>
> # Install proper kernel
> INITRAMFS_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME")) if d.getVar("KERNEL_NAME") else ""}"
Looks good. Would look even better when pointing to the commit that
obsoleted it (4b3382a98f3a).
Jan
--
Siemens AG, Technology
Linux Expert Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] meta/classes/initramfs: remove unused variable
2024-05-09 10:59 [PATCH] meta/classes/initramfs: remove unused variable srinuvasan.a
2024-05-21 7:19 ` Srinuvasan Arjunan
2024-05-21 8:32 ` Jan Kiszka
@ 2024-05-28 6:02 ` Uladzimir Bely
2 siblings, 0 replies; 4+ messages in thread
From: Uladzimir Bely @ 2024-05-28 6:02 UTC (permalink / raw)
To: srinuvasan.a, isar-users; +Cc: jan.kiszka
On Thu, 2024-05-09 at 16:29 +0530, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
>
> The variable INITRAMFS_IMAGE_FILE is nowhere used across
> the repository, hence remove the unused variable.
>
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
> meta/classes/initramfs.bbclass | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/classes/initramfs.bbclass
> b/meta/classes/initramfs.bbclass
> index 5b5943f2..6886b95a 100644
> --- a/meta/classes/initramfs.bbclass
> +++ b/meta/classes/initramfs.bbclass
> @@ -14,7 +14,6 @@ INITRAMFS_INSTALL ?= ""
> INITRAMFS_PREINSTALL ?= ""
> INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
> INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
> -INITRAMFS_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}"
>
> # Install proper kernel
> INITRAMFS_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME"))
> if d.getVar("KERNEL_NAME") else ""}"
> --
> 2.34.1
>
Applied (with a slight commit message modification pointing to
appropriate commit hash) to next, thanks.
--
Best regards,
Uladzimir.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-28 6:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-09 10:59 [PATCH] meta/classes/initramfs: remove unused variable srinuvasan.a
2024-05-21 7:19 ` Srinuvasan Arjunan
2024-05-21 8:32 ` Jan Kiszka
2024-05-28 6:02 ` Uladzimir Bely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox