Re: [PATCH v2 0/5] Python refactoring

["Maxim Yu. Osipov" <mosipov@ilbers.de>]

Hi Harald,

I've applied your series (patch #2 has to be rebased) and ran "fast" CI:
'./scripts/ci_build.sh -q -f'.

Build has been failed:

See for detail:
http://isar-build.org:8080/job/isar_mosipov_develop/43/console

Thanks,
Maxim.

P.S. I'll send a rebased patch in separate email.

On 2/12/19 5:56 PM, Harald Seiler wrote:
> This series contains a number of improvements to python code in isar:
> 
> * All instancess of subprocess.{call,Popen,check_call}() have been changed to
>    never use `shell=True`.  This will hopefully prevent bugs in the future.
> * The use of the % formatter was replaced by other methods, as % was deprecated
>    because it can behave weirdly.  Unfortunately, as we have to support python
>    back to 3.5, we can not yet make use of f-Strings, so other options had to be
>    used.  I decided to use string concatenation for simple cases where the use
>    of .format() would have been too verbose.
> * A recursive call in get_image_name was removed in favor of an imperative code
>    style.  This should make the respective function easier to read.
> 
> Changes in v2:
> 
>      * Remove redundant encoding parameter
>      * Fix formatting
>      * Refactor a task that I previously missed
>      * Add a commit for general style fixes
> 
> Harald Seiler (5):
>    Remove all uses of subprocess.call(shell=True)
>    Use modern python formatting
>    image: Remove recursion in get_image_name
>    wic: Refactor fakeroot script
>    Fix python style
> 
>   .../example-module/example-module.bb               |  8 ++-
>   meta/classes/base.bbclass                          | 70 ++++++++++++++--------
>   meta/classes/image.bbclass                         | 22 +++++--
>   meta/classes/isar-bootstrap-helper.bbclass         |  8 +--
>   meta/classes/isar-events.bbclass                   | 14 ++---
>   meta/classes/patch.bbclass                         | 13 ++--
>   meta/classes/wic-img.bbclass                       | 21 +++++--
>   .../isar-bootstrap/isar-bootstrap-host.bb          |  9 ++-
>   .../isar-bootstrap/isar-bootstrap-target.bb        |  5 +-
>   .../recipes-core/isar-bootstrap/isar-bootstrap.inc | 12 ++--
>   scripts/wic_fakeroot                               |  9 +--
>   11 files changed, 120 insertions(+), 71 deletions(-)
> 


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov