From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6657041487194226688 X-Received: by 2002:a1c:c3c5:: with SMTP id t188mr1420183wmf.15.1550496573797; Mon, 18 Feb 2019 05:29:33 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:ce03:: with SMTP id m3ls1769126wmc.10.canary-gmail; Mon, 18 Feb 2019 05:29:32 -0800 (PST) X-Google-Smtp-Source: AHgI3IasvpBO2QH2iW1k8lOM+I74hKp+3ZmszCibed3RifJGrsOFFpLBlYefIbIBtJ1OTrKpmEsi X-Received: by 2002:a1c:1a4a:: with SMTP id a71mr247356wma.21.1550496572956; Mon, 18 Feb 2019 05:29:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550496572; cv=none; d=google.com; s=arc-20160816; b=GLzoZajRf5n3CEq5qAxIrSPAKkHQCvnEKXI1zaqGaVCXukWPmAPfNurt6AtmAX8DqJ IQa2bzCWslkwitlLayuZa634lxGFjOouly5d7sqpTu9+ahMaYCStAfE9plrjwS6dYpwQ cB6HhKJOasTD31OvZcvcSRsT/P6tWl7jZr75c7FGbH3i/yOMxsAMHmRijo0gvZC0reIB ZGLQTvToKCTPPZBZGkdRB16h7HJadOrgdoNfVEamT9ygNXcVDYyn4lruPlu5PN9LaFdi j6lMTIWQ2Wj0zIabRVcYCIzGp0YOA+1tHD3elm25vVAqtsikOeQPIT+Ktcg42T62GAIN lh6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:from:references:to:subject; bh=rQO/junfZwllD/1om/SYMNwW0GQFAN9C8m48lodGiYo=; b=NKqQxiGNTMdaJGjpV/GfRGRBjGsmFLFKYIYMzSsl406vxGqt1Jr06FnLe01vkE4EdA 7u+4XDbsoMQaKnIYXSw4MmmNF87yDdjyDkaVtPeLvdp3WqEicW3xqmwbJdnPgAV0aw0G PT2ETFRV2nNaUoqKJvdA2b/E/8/iIvGPv7fYc+ylp/JyQvMgYKnF9zEIKfE+70OJtZ4f hlXRupymyVGjsBkRJuSU4rpApStYnU7eRCo011T8OuHZYcjJ5Gfya4RPJBLukoV93ig/ BpSqWYSCI6PhrFkvYGS89btHAIu1BJdrSv7wfqokIGtxi5cHq8nwnWWWloIFzgf5jwiR gquA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from shymkent.ilbers.de (shymkent.ilbers.de. [85.214.156.166]) by gmr-mx.google.com with ESMTPS id b8si307678wru.1.2019.02.18.05.29.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Feb 2019 05:29:32 -0800 (PST) Received-SPF: pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) client-ip=85.214.156.166; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mosipov@ilbers.de designates 85.214.156.166 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from [192.168.50.163] (d51A48A80.access.telenet.be [81.164.138.128]) (authenticated bits=0) by shymkent.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPSA id x1IDTUsJ013990 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Feb 2019 14:29:31 +0100 Subject: Re: [PATCH v2 0/5] Python refactoring To: Harald Seiler , isar-users@googlegroups.com References: <20190212165637.19970-1-hws@denx.de> From: "Maxim Yu. Osipov" Organization: ilbers GmbH Message-ID: Date: Mon, 18 Feb 2019 14:29:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190212165637.19970-1-hws@denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on shymkent.ilbers.de X-TUID: B/cF+8KcZ6Gm Hi Harald, I've applied your series (patch #2 has to be rebased) and ran "fast" CI: './scripts/ci_build.sh -q -f'. Build has been failed: See for detail: http://isar-build.org:8080/job/isar_mosipov_develop/43/console Thanks, Maxim. P.S. I'll send a rebased patch in separate email. On 2/12/19 5:56 PM, Harald Seiler wrote: > This series contains a number of improvements to python code in isar: > > * All instancess of subprocess.{call,Popen,check_call}() have been changed to > never use `shell=True`. This will hopefully prevent bugs in the future. > * The use of the % formatter was replaced by other methods, as % was deprecated > because it can behave weirdly. Unfortunately, as we have to support python > back to 3.5, we can not yet make use of f-Strings, so other options had to be > used. I decided to use string concatenation for simple cases where the use > of .format() would have been too verbose. > * A recursive call in get_image_name was removed in favor of an imperative code > style. This should make the respective function easier to read. > > Changes in v2: > > * Remove redundant encoding parameter > * Fix formatting > * Refactor a task that I previously missed > * Add a commit for general style fixes > > Harald Seiler (5): > Remove all uses of subprocess.call(shell=True) > Use modern python formatting > image: Remove recursion in get_image_name > wic: Refactor fakeroot script > Fix python style > > .../example-module/example-module.bb | 8 ++- > meta/classes/base.bbclass | 70 ++++++++++++++-------- > meta/classes/image.bbclass | 22 +++++-- > meta/classes/isar-bootstrap-helper.bbclass | 8 +-- > meta/classes/isar-events.bbclass | 14 ++--- > meta/classes/patch.bbclass | 13 ++-- > meta/classes/wic-img.bbclass | 21 +++++-- > .../isar-bootstrap/isar-bootstrap-host.bb | 9 ++- > .../isar-bootstrap/isar-bootstrap-target.bb | 5 +- > .../recipes-core/isar-bootstrap/isar-bootstrap.inc | 12 ++-- > scripts/wic_fakeroot | 9 +-- > 11 files changed, 120 insertions(+), 71 deletions(-) > -- Maxim Osipov ilbers GmbH Maria-Merian-Str. 8 85521 Ottobrunn Germany +49 (151) 6517 6917 mosipov@ilbers.de http://ilbers.de/ Commercial register Munich, HRB 214197 General Manager: Baurzhan Ismagulov